diff --git a/app/i18n.py b/app/i18n.py index 8392468..cd5db1d 100644 --- a/app/i18n.py +++ b/app/i18n.py @@ -77,6 +77,8 @@ EVENT_TYPE_LABELS = { "swap_accepted": "Troca aceite", "swap_approved": "Troca aprovada", "swap_rejected": "Troca recusada", + "assignment_updated": "Turno atribuído", + "assignment_changed": "Turno retirado", "shift_reminder": "Lembrete de turno", "reminder": "Lembrete", } diff --git a/app/templates/admin_schedule.html b/app/templates/admin_schedule.html index 4ab3055..d4e3d49 100644 --- a/app/templates/admin_schedule.html +++ b/app/templates/admin_schedule.html @@ -97,5 +97,38 @@ {% endif %} + +
+

Pedidos de troca

+

Um administrador pode atribuir o turno a outra pessoa, mesmo que essa pessoa não entre na aplicação. Só se aplica se quem pediu a troca continuar a ser o titular do turno.

+ +
{% endblock %} diff --git a/app/templates/admin_schedules.html b/app/templates/admin_schedules.html index 22907ed..9804640 100644 --- a/app/templates/admin_schedules.html +++ b/app/templates/admin_schedules.html @@ -1,6 +1,6 @@ {% extends "base.html" %} {% block content %} -

Escalas

Uma página por tipo de escala. A escala da noite é fixa e repete todos os meses; o almoço de sábado e o de domingo são rotações independentes. Os turnos já gerados não são reescritos quando uma rotação muda.

+

Escalas

{% for card in cards %} {% set schedule = card.schedule %} diff --git a/app/templates/admin_user_delete.html b/app/templates/admin_user_delete.html new file mode 100644 index 0000000..9529d6f --- /dev/null +++ b/app/templates/admin_user_delete.html @@ -0,0 +1,31 @@ +{% extends "base.html" %} +{% block title %}Remover {{ person.name }} · {{ settings.app_name }}{% endblock %} +{% block content %} +
+
+

Pessoas

+

Remover pessoa

+

Isto é definitivo e não pode ser desfeito.

+
+
+
+

{{ person.name }}

+

{% if person.can_login %}@{{ person.username }}{% else %}Sem login, apenas aparece na escala.{% endif %}

+

Só é possível remover quem ainda não tem turnos atribuídos. Primeiro transfira os turnos desta pessoa para outras; assim o registo de quem trabalhou cada data mantém-se.

+

Ao remover, acontece o seguinte:

+ +

Se só quiser que esta pessoa deixe de receber turnos, desative-a em vez de a remover.

+
+
+ + +
+ Cancelar +
+
+{% endblock %} \ No newline at end of file diff --git a/app/templates/admin_users.html b/app/templates/admin_users.html index 9f47b71..990f1e9 100644 --- a/app/templates/admin_users.html +++ b/app/templates/admin_users.html @@ -41,6 +41,7 @@
+ {% if person.id in removable_ids %}
Remover
{% endif %} {% endfor %} diff --git a/app/templates/swaps.html b/app/templates/swaps.html index 6770e2e..0605b0b 100644 --- a/app/templates/swaps.html +++ b/app/templates/swaps.html @@ -1,7 +1,7 @@ {% extends "base.html" %} {% block content %}
-

Pedidos de troca

Qualquer pessoa pode assumir um turno aberto ou aceitar um pedido enviado diretamente para si.

+

Pedidos de troca

diff --git a/app/web.py b/app/web.py index 19361f4..0d43ab0 100644 --- a/app/web.py +++ b/app/web.py @@ -580,12 +580,13 @@ def admin_reject_swap( @router.get("/admin/users", response_class=HTMLResponse) def admin_users(request: Request, db: Session = Depends(get_db)): - _require_admin(request, db) + admin = _require_admin(request, db) users = db.scalars(select(User).order_by(User.name)).all() + removable_ids = {user.id for user in users if _removal_blocker(db, admin, user) is None} return request.app.state.templates.TemplateResponse( request=request, name="admin_users.html", - context=_context(request, db, users=users), + context=_context(request, db, users=users, removable_ids=removable_ids), ) @@ -700,6 +701,110 @@ def admin_update_user( return _redirect("/admin/users") +def _user_removal_impact(db: Session, user: User) -> dict[str, int]: + return { + "assignments": db.scalar( + select(func.count(Assignment.id)).where(Assignment.user_id == user.id) + ) or 0, # must be zero for the removal to be allowed + "rotation": db.scalar( + select(func.count(RotationMember.id)).where(RotationMember.user_id == user.id) + ) or 0, + "pattern_days": db.scalar( + select(func.count(MonthlyPattern.id)).where(MonthlyPattern.user_id == user.id) + ) or 0, + "requests": db.scalar( + select(func.count(SwapRequest.id)).where( + SwapRequest.status.in_(["open", "pending_approval"]), + ( + (SwapRequest.requester_id == user.id) + | (SwapRequest.target_user_id == user.id) + | (SwapRequest.accepted_by_id == user.id) + ), + ) + ) or 0, + } + + +def _removal_blocker(db: Session, admin: User, user: User) -> str | None: + """Why this person cannot be removed, or None when the removal is allowed.""" + if user.id == admin.id: + return "Não pode remover a sua própria conta" + if user.is_admin and not db.scalar( + select(User.id).where(User.is_admin.is_(True), User.id != user.id) + ): + return "Não pode remover o último administrador" + if db.scalar(select(Assignment.id).where(Assignment.user_id == user.id)): + return "Não pode remover uma pessoa que ainda tem turnos atribuídos" + return None + + +def _require_removable(db: Session, admin: User, user: User) -> None: + reason = _removal_blocker(db, admin, user) + if reason: + raise HTTPException(status_code=400, detail=reason) + + +@router.get("/admin/users/{user_id}/delete", response_class=HTMLResponse) +def admin_user_delete_page( + user_id: int, + request: Request, + db: Session = Depends(get_db), +): + admin = _require_admin(request, db) + user = db.get(User, user_id) + if not user: + raise HTTPException(status_code=404, detail="Pessoa não encontrada") + _require_removable(db, admin, user) + return request.app.state.templates.TemplateResponse( + request=request, + name="admin_user_delete.html", + context=_context(request, db, person=user, impact=_user_removal_impact(db, user)), + ) + + +@router.post("/admin/users/{user_id}/delete") +def admin_user_delete( + user_id: int, + request: Request, + csrf_token: str = Form(...), + db: Session = Depends(get_db), +): + admin = _require_admin(request, db) + _check_csrf(request, csrf_token) + user = db.get(User, user_id) + if not user: + raise HTTPException(status_code=404, detail="Pessoa não encontrada") + _require_removable(db, admin, user) + + # No assignment can survive here: _require_removable refuses while the person holds one. + for swap in db.scalars( + select(SwapRequest).where(SwapRequest.requester_id == user.id) + ).all(): + db.delete(swap) + for swap in db.scalars( + select(SwapRequest).where( + (SwapRequest.target_user_id == user.id) | (SwapRequest.accepted_by_id == user.id) + ) + ).all(): + if swap.target_user_id == user.id: + swap.target_user_id = None + if swap.accepted_by_id == user.id: + swap.accepted_by_id = None + for pattern in db.scalars( + select(MonthlyPattern).where(MonthlyPattern.user_id == user.id) + ).all(): + pattern.user_id = None + for log in db.scalars( + select(NotificationLog).where(NotificationLog.user_id == user.id) + ).all(): + log.user_id = None + db.execute(delete(RotationMember).where(RotationMember.user_id == user.id)) + db.delete(user) + db.commit() + _flash(request, f"{user.name} foi removida(o).") + return _redirect("/admin/users") + + @router.get("/admin/schedules", response_class=HTMLResponse) def admin_schedules(request: Request, db: Session = Depends(get_db)): _require_admin(request, db) @@ -740,6 +845,7 @@ def admin_schedule( cards=_schedule_groups(_all_schedules(db), db), users=users, assignments=assignments, + swap_requests=_open_swap_requests(db, schedule.id), pattern_days=list(range(1, 32)), pattern=_pattern_map(db, schedule), year=year, @@ -753,6 +859,28 @@ def admin_schedule( ) +def _open_swap_requests(db: Session, schedule_id: int) -> list[SwapRequest]: + """Open and pending change requests for one schedule, oldest first.""" + return list( + db.scalars( + select(SwapRequest) + .where( + SwapRequest.assignment_id.in_( + select(Assignment.id).where(Assignment.schedule_id == schedule_id) + ), + SwapRequest.status.in_(["open", "pending_approval"]), + ) + .options( + selectinload(SwapRequest.assignment).selectinload(Assignment.schedule), + selectinload(SwapRequest.requester), + selectinload(SwapRequest.target_user), + selectinload(SwapRequest.accepted_by), + ) + .order_by(SwapRequest.created_at) + ).all() + ) + + def _pattern_map(db: Session, schedule: Schedule) -> dict[int, int]: rows = db.scalars( select(MonthlyPattern).where(MonthlyPattern.schedule_id == schedule.id) @@ -972,15 +1100,15 @@ def _save_assignments(db: Session, assignments: Sequence[Assignment], form) -> i def _notify_assignment_changes(db: Session, changed: Sequence[tuple[Assignment, User | None, User | None]]) -> None: for assignment, old_user, new_user in changed: - subject = f"Bar rota updated: {assignment.date:%d %b} – {assignment.schedule.name}" + subject = f"Escala atualizada: {day_short(assignment.date)} – {assignment.schedule.name}" if new_user: send_email_notification( db, new_user, "assignment_updated", subject, - f"You are assigned to {assignment.schedule.name} on {assignment.date:%A, %d %B %Y}.\n\n" - f"View the rota: {settings.normalized_base_url}/", + f"Está atribuído ao turno de {assignment.schedule.name} a {day_numeric_long(assignment.date)}.\n\n" + f"Ver a escala: {settings.normalized_base_url}/", ) if old_user and (not new_user or old_user.id != new_user.id): send_email_notification( @@ -988,8 +1116,8 @@ def _notify_assignment_changes(db: Session, changed: Sequence[tuple[Assignment, old_user, "assignment_changed", subject, - f"You are no longer assigned to {assignment.schedule.name} on {assignment.date:%A, %d %B %Y}.\n\n" - f"View the rota: {settings.normalized_base_url}/", + f"Já não está atribuído ao turno de {assignment.schedule.name} a {day_numeric_long(assignment.date)}.\n\n" + f"Ver a escala: {settings.normalized_base_url}/", ) @@ -1005,6 +1133,75 @@ def _month_assignments(db: Session, year: int, month: int) -> list[Assignment]: ) +@router.post("/admin/schedules/{schedule_id}/swaps/{swap_id}/assign") +def admin_schedule_assign_swap( + schedule_id: int, + swap_id: int, + request: Request, + user_id: int = Form(...), + year: str = Form(""), + month: str = Form(""), + csrf_token: str = Form(...), + db: Session = Depends(get_db), +): + """Complete a change request on behalf of the rota, including for rota-only people.""" + admin = _require_admin(request, db) + _check_csrf(request, csrf_token) + schedule = _get_schedule(db, schedule_id) + swap = db.scalar( + select(SwapRequest) + .where(SwapRequest.id == swap_id) + .options( + selectinload(SwapRequest.assignment).selectinload(Assignment.schedule), + selectinload(SwapRequest.requester), + ) + ) + if not swap or swap.assignment.schedule_id != schedule.id: + raise HTTPException(status_code=404, detail="Pedido de troca não encontrado") + if swap.status not in {"open", "pending_approval"}: + raise HTTPException(status_code=400, detail="Este pedido já não está aberto") + new_user = db.get(User, user_id) + if not new_user or not new_user.is_active or new_user.id == swap.requester_id: + raise HTTPException(status_code=400, detail="Pessoa inválida para este turno") + if swap.assignment.date < date.today(): + raise HTTPException(status_code=400, detail="Turnos passados não podem ser alterados") + # The request only applies while the person who asked for the change still owns the shift. + if swap.assignment.user_id != swap.requester_id: + swap.status = "cancelled" + db.commit() + raise HTTPException(status_code=409, detail="O turno já foi alterado") + + swap.assignment.user_id = new_user.id + swap.assignment.source = "swap" + swap.accepted_by_id = new_user.id + swap.status = "approved" + for other in db.scalars( + select(SwapRequest).where( + SwapRequest.assignment_id == swap.assignment_id, + SwapRequest.id != swap.id, + SwapRequest.status.in_(["open", "pending_approval"]), + ) + ).all(): + other.status = "cancelled" + db.commit() + + subject = "Troca de turno aprovada" + body = ( + f"{admin.name} atribuiu o turno de {schedule.name} a {day_numeric_long(swap.assignment.date)} " + f"a {new_user.name}, a pedido de {swap.requester.name}.\n\n" + f"Ver a escala: {settings.normalized_base_url}/" + ) + send_many(db, [swap.requester, new_user], "swap_approved", subject, body) + _flash(request, f"Turno de {day_short(swap.assignment.date)} atribuído a {new_user.name}.") + return _redirect(f"{_schedule_page(schedule.id, year, month)}#swap-requests") + + +def _schedule_page(schedule_id: int, year: str, month: str) -> str: + if year.isdigit() and month.isdigit(): + return f"/admin/schedules/{schedule_id}?year={int(year)}&month={int(month)}" + return f"/admin/schedules/{schedule_id}" + + @router.post("/admin/schedules/{schedule_id}/assignments") async def admin_schedule_assignments( schedule_id: int, diff --git a/docs/DOMAIN.md b/docs/DOMAIN.md index 9af58dd..e5fc383 100644 --- a/docs/DOMAIN.md +++ b/docs/DOMAIN.md @@ -57,6 +57,7 @@ Every assignment on a lunch schedule page has a **Regenerate** button. An admini - A username, when set, is unique. - Rota-only people can be assigned by an administrator, appear in rotations, and can be named as the target of a change request, but cannot accept it; an administrator completes the transfer on the schedule's own configuration page. - A person cannot remove their own login. +- An administrator can remove a person permanently from `/admin/users`, after a confirmation page that lists the impact. A person who still holds any assignment, past ones included, cannot be removed: those shifts must first be handed over, so the record of who worked each date stays intact. SQLite cascades are not enforced by the application, so the removal clears the remaining references explicitly: night-pattern days lose their person, rotation positions are deleted, that person's own change requests are deleted and the ones that merely targeted or accepted by them lose those references, and notification logs keep their history without the person. - Nobody may remove their own account or the last remaining administrator. The people page only shows the remove button for the people who pass these checks; the endpoints enforce them again. Deactivating is the non-destructive alternative. ## Access @@ -76,6 +77,7 @@ Other terminal states: `rejected`, `cancelled`. - If the schedule requires manager approval, acceptance moves to `pending_approval`. - Approval transfers the assignment and sets its source to `swap`. - If the requester no longer owns the assignment, the request must not be applied. +- On a schedule's configuration page, an administrator can complete an `open` or `pending_approval` request on someone's behalf by choosing any other active member. This is the only way a rota-only person gives up or receives a shift. The same ownership rule applies, other open requests for that assignment are cancelled, and the requester and the new person are both notified. Past dates are refused. ## Notifications diff --git a/tests/test_admin_schedule_assignments.py b/tests/test_admin_schedule_assignments.py index f141d02..860bac0 100644 --- a/tests/test_admin_schedule_assignments.py +++ b/tests/test_admin_schedule_assignments.py @@ -630,3 +630,117 @@ def test_new_generation_controls_require_admin_and_csrf(client, db, action): token = CSRF_RE.search(client.get("/login").text).group(1) client.post("/login", data={"username": "member", "password": "member-password", "csrf_token": token}) assert client.post(url, data={**data, "csrf_token": token}).status_code == 403 + + +def _open_request(db, schedule: Schedule, owner: User, target: User | None = None) -> SwapRequest: + ensure_month_assignments(db, YEAR, MONTH) + assignment = db.scalar( + select(Assignment).where( + Assignment.schedule_id == schedule.id, + Assignment.date > date.today(), + ).order_by(Assignment.date) + ) + assignment.user_id = owner.id + swap = SwapRequest( + assignment_id=assignment.id, + requester_id=owner.id, + target_user_id=target.id if target else None, + status="open", + ) + db.add(swap) + db.commit() + return swap + + +def test_admin_completes_a_change_request_on_the_schedule_page(client, db): + night, sat, sun, ana, bruno, admin = seed(db) + token = sign_in(client) + rota_only = User(name="Rota Only", is_active=True, notify_email=True, email="rota@example.com") + db.add(rota_only) + db.commit() + swap = _open_request(db, sat, ana) + + page = client.get(f"/admin/schedules/{sat.id}").text + assert "Pedidos de troca" in page + assert f"/admin/schedules/{sat.id}/swaps/{swap.id}/assign" in page + assert "Turnos passados não podem ser alterados" not in page + + response = client.post( + f"/admin/schedules/{sat.id}/swaps/{swap.id}/assign", + data={"csrf_token": token, "user_id": rota_only.id, "year": str(YEAR), "month": str(MONTH)}, + follow_redirects=True, + ) + + db.refresh(swap) + assignment = db.get(Assignment, swap.assignment_id) + assert swap.status == "approved" + assert swap.accepted_by_id == rota_only.id + assert assignment.user_id == rota_only.id + assert assignment.source == "swap" + assert "atribuído a Rota Only" in response.text + notified = db.scalars( + select(NotificationLog).where(NotificationLog.event_type == "swap_approved") + ).all() + assert {log.user_id for log in notified} == {ana.id, rota_only.id} + + +def test_admin_completes_a_request_that_already_has_an_accepter(client, db): + _, sat, _, ana, bruno, _ = seed(db) + token = sign_in(client) + swap = _open_request(db, sat, ana, target=bruno) + + client.post( + f"/admin/schedules/{sat.id}/swaps/{swap.id}/assign", + data={"csrf_token": token, "user_id": bruno.id}, + follow_redirects=False, + ) + + db.refresh(swap) + assert swap.status == "approved" + assert db.get(Assignment, swap.assignment_id).user_id == bruno.id + + +def test_admin_assignment_fails_when_the_requester_no_longer_owns_the_shift(client, db): + _, sat, _, ana, bruno, _ = seed(db) + token = sign_in(client) + swap = _open_request(db, sat, ana) + swap.assignment.user_id = bruno.id + db.commit() + + response = client.post( + f"/admin/schedules/{sat.id}/swaps/{swap.id}/assign", + data={"csrf_token": token, "user_id": bruno.id}, + ) + + assert response.status_code == 409 + db.refresh(swap) + assert swap.status == "cancelled" + assert db.get(Assignment, swap.assignment_id).user_id == bruno.id + + +def test_admin_assignment_rejects_bad_input_and_protects_the_route(client, db): + night, sat, _, ana, bruno, admin = seed(db) + swap = _open_request(db, sat, ana) + url = f"/admin/schedules/{sat.id}/swaps/{swap.id}/assign" + assert client.post(url, data={"csrf_token": "invalid", "user_id": bruno.id}).status_code == 401 + token = sign_in(client) + assert client.post(url, data={"csrf_token": "invalid", "user_id": bruno.id}).status_code == 400 + assert client.post(url, data={"csrf_token": token, "user_id": ana.id}).status_code == 400 + inactive = User(name="Gone", is_active=False, notify_email=False) + db.add(inactive) + db.commit() + assert client.post(url, data={"csrf_token": token, "user_id": inactive.id}).status_code == 400 + assert client.post(f"/admin/schedules/{night.id}/swaps/{swap.id}/assign", + data={"csrf_token": token, "user_id": bruno.id}).status_code == 404 + db.refresh(swap) + assert swap.status == "open" + assert db.get(Assignment, swap.assignment_id).user_id == ana.id + + client.post("/logout", data={"csrf_token": token}) + token = CSRF_RE.search(client.get("/login").text).group(1) + member = User(name="Member", username="member", password_hash=hash_password("member-password"), is_active=True) + db.add(member) + db.commit() + client.post("/login", data={"username": "member", "password": "member-password", "csrf_token": token}) + token = CSRF_RE.search(client.get("/").text).group(1) + assert client.post(url, data={"csrf_token": token, "user_id": bruno.id}).status_code == 403 diff --git a/tests/test_users.py b/tests/test_users.py index 8b40679..72c5e6f 100644 --- a/tests/test_users.py +++ b/tests/test_users.py @@ -1,4 +1,5 @@ import re +from datetime import date import pytest from fastapi.testclient import TestClient @@ -176,3 +177,170 @@ def test_signed_in_home_is_the_rota_and_nav_has_no_rota_link(client, db, admin): assert 'Escalas' in nav assert 'Trocas' in nav assert 'href="/"' in nav # the brand stays the home link for signed-in members + + +def delete_person(client: TestClient, user_id: int) -> str: + return client.get(f"/admin/users/{user_id}/delete").text + + +def test_removing_a_person_clears_every_reference(client, db, admin): + from app.models import ( + Assignment, + MonthlyPattern, + NotificationLog, + RotationMember, + Schedule, + SwapRequest, + ) + + login(client, "admin", "admin-password") + page = add_person(client, name="Rota Only") + assert f'href="/admin/users/{db.scalar(select(User.id).where(User.name == "Rota Only"))}/delete"' in page + person = db.scalar(select(User).where(User.name == "Rota Only")) + schedule = Schedule( + name="Almoço - Sábados", + slug="saturday-lunch", + schedule_type="rotation", + weekdays="5", + label_time="Almoço", + requires_manager_approval=True, + is_active=True, + rotation_anchor_date=date(2026, 1, 3), + ) + db.add(schedule) + db.flush() + assignment = Assignment(schedule_id=schedule.id, date=date(2026, 10, 3), user_id=person.id) + pattern = MonthlyPattern(schedule_id=schedule.id, day_of_month=1, user_id=person.id) + member = RotationMember(schedule_id=schedule.id, user_id=person.id, position=0) + log = NotificationLog(user_id=person.id, event_type="swap_requested", subject="x", body="x", status="skipped") + db.add_all([assignment, pattern, member, log]) + db.flush() + db.add(SwapRequest(assignment_id=assignment.id, requester_id=person.id, status="open")) + db.commit() + + # Someone who still holds a shift cannot be removed, not even from the past. + token = csrf(client, "/admin/users") + assert client.get(f"/admin/users/{person.id}/delete").status_code == 400 + assert client.post( + f"/admin/users/{person.id}/delete", data={"csrf_token": token} + ).status_code == 400 + assert db.get(User, person.id) is not None + assert db.get(Assignment, assignment.id).user_id == person.id + assert f'href="/admin/users/{person.id}/delete"' not in client.get("/admin/users").text + + # Freeing the shift makes the removal possible again. + assignment.user_id = None + db.commit() + assert f'href="/admin/users/{person.id}/delete"' in client.get("/admin/users").text + + confirm = delete_person(client, person.id) + assert "Remover definitivamente" in confirm + assert "1 posição(ões) saem das rotações" in confirm + assert "1 dia(s) do padrão" in confirm + assert "1 pedido(s) de troca em aberto" in confirm + + response = client.post( + f"/admin/users/{person.id}/delete", + data={"csrf_token": csrf(client, "/admin/users")}, + follow_redirects=True, + ) + + assert "Rota Only foi removida(o)." in response.text + assert db.get(User, person.id) is None + db.refresh(log) + assert log.user_id is None + assert db.get(MonthlyPattern, pattern.id).user_id is None + assert db.get(RotationMember, member.id) is None + assert db.scalars( + select(SwapRequest).where(SwapRequest.requester_id == person.id) + ).all() == [] + + +def test_removing_a_person_keeps_other_peoples_requests_intact(client, db, admin): + from app.models import Assignment, Schedule, SwapRequest + + login(client, "admin", "admin-password") + add_person(client, name="Rota Only") + person = db.scalar(select(User).where(User.name == "Rota Only")) + schedule = Schedule( + name="Almoço - Sábados", + slug="saturday-lunch", + schedule_type="rotation", + weekdays="5", + label_time="Almoço", + requires_manager_approval=True, + is_active=True, + rotation_anchor_date=date(2026, 1, 3), + ) + db.add(schedule) + db.flush() + assignment = Assignment(schedule_id=schedule.id, date=date(2026, 10, 3), user_id=admin.id) + db.add(assignment) + db.flush() + request = SwapRequest( + assignment_id=assignment.id, + requester_id=admin.id, + target_user_id=person.id, + status="open", + ) + db.add(request) + db.commit() + + client.post( + f"/admin/users/{person.id}/delete", + data={"csrf_token": csrf(client, "/admin/users")}, + follow_redirects=True, + ) + + db.refresh(request) + assert db.get(SwapRequest, request.id) is not None + assert request.target_user_id is None + assert request.requester_id == admin.id + + +def test_a_person_cannot_be_removed_by_a_member_or_without_the_right_token(client, db, admin): + login(client, "admin", "admin-password") + add_person(client, name="Rota Only") + person = db.scalar(select(User).where(User.name == "Rota Only")) + url = f"/admin/users/{person.id}/delete" + token = csrf(client, "/admin/users") + + assert client.post(url, data={"csrf_token": "invalid"}).status_code == 400 + + add_person(client, name="Member") + member = db.scalar(select(User).where(User.name == "Member")) + update_person(client, member.id, name="Member", username="member", new_password="member-password") + client.post("/logout", data={"csrf_token": csrf(client, "/admin/users")}) + token = csrf(client, "/login") + client.post( + "/login", + data={"username": "member", "password": "member-password", "csrf_token": token}, + ) + token = csrf(client, "/") + assert client.get(url).status_code == 403 + assert client.post(url, data={"csrf_token": token}).status_code == 403 + + client.post("/logout", data={"csrf_token": token}) + assert client.get(url).status_code == 401 + assert client.post(url, data={"csrf_token": "invalid"}).status_code == 401 + assert db.get(User, person.id) is not None + + +def test_admins_cannot_remove_themselves_or_the_last_admin(client, db, admin): + login(client, "admin", "admin-password") + token = csrf(client, "/admin/users") + + assert client.get(f"/admin/users/{admin.id}/delete").status_code == 400 + assert client.post(f"/admin/users/{admin.id}/delete", data={"csrf_token": token}).status_code == 400 + assert f'href="/admin/users/{admin.id}/delete"' not in client.get("/admin/users").text + + add_person(client, name="Second Admin") + second = db.scalar(select(User).where(User.name == "Second Admin")) + update_person(client, second.id, name="Second Admin", is_admin="on") + db.refresh(second) + assert second.is_admin is True + assert f'href="/admin/users/{second.id}/delete"' in client.get("/admin/users").text + + client.post(f"/admin/users/{second.id}/delete", data={"csrf_token": token}) + assert db.get(User, second.id) is None + assert db.get(User, admin.id) is not None