401 lines
12 KiB
Python
401 lines
12 KiB
Python
import re
|
|
from datetime import date, time, timedelta
|
|
|
|
import pytest
|
|
from fastapi.testclient import TestClient
|
|
from sqlalchemy import create_engine, select
|
|
from sqlalchemy.orm import sessionmaker
|
|
from sqlalchemy.pool import StaticPool
|
|
|
|
from app.database import Base, get_db
|
|
from app.main import app
|
|
from app.i18n import day_short, month_name, weekday_name
|
|
from app.models import RotationMember, Schedule, User
|
|
from app.security import hash_password
|
|
|
|
CSRF_RE = re.compile(r'name="csrf_token" value="([^"]+)"')
|
|
|
|
|
|
@pytest.fixture()
|
|
def db():
|
|
engine = create_engine("sqlite://", connect_args={"check_same_thread": False}, poolclass=StaticPool)
|
|
Base.metadata.create_all(engine)
|
|
session = sessionmaker(bind=engine, expire_on_commit=False)()
|
|
try:
|
|
yield session
|
|
finally:
|
|
session.close()
|
|
|
|
|
|
@pytest.fixture()
|
|
def client(db):
|
|
def override_get_db():
|
|
yield db
|
|
|
|
app.dependency_overrides[get_db] = override_get_db
|
|
try:
|
|
yield TestClient(app)
|
|
finally:
|
|
app.dependency_overrides.pop(get_db, None)
|
|
|
|
|
|
def add_person(db, name: str) -> User:
|
|
user = User(
|
|
name=name,
|
|
username=None,
|
|
password_hash=None,
|
|
is_active=True,
|
|
is_admin=False,
|
|
notify_email=False,
|
|
)
|
|
db.add(user)
|
|
db.flush()
|
|
return user
|
|
|
|
|
|
def add_schedule(db, **fields) -> Schedule:
|
|
defaults = {
|
|
"schedule_type": "rotation",
|
|
"weekdays": "5",
|
|
"start_time": time(13, 0),
|
|
"end_time": time(16, 0),
|
|
"requires_manager_approval": True,
|
|
"is_active": True,
|
|
"rotation_anchor_date": date(2026, 1, 3),
|
|
}
|
|
defaults.update(fields)
|
|
schedule = Schedule(**defaults)
|
|
db.add(schedule)
|
|
db.flush()
|
|
return schedule
|
|
|
|
|
|
def add_rotation_member(db, schedule: Schedule, user: User, position: int) -> RotationMember:
|
|
member = RotationMember(schedule_id=schedule.id, user_id=user.id, position=position)
|
|
db.add(member)
|
|
db.flush()
|
|
return member
|
|
|
|
|
|
def login(client: TestClient, username: str, password: str) -> str:
|
|
match = CSRF_RE.search(client.get("/login").text)
|
|
assert match, "no csrf token on /login"
|
|
return client.post(
|
|
"/login",
|
|
data={"username": username, "password": password, "csrf_token": match.group(1)},
|
|
follow_redirects=True,
|
|
).text
|
|
|
|
|
|
def seed_schedules(db):
|
|
night = add_schedule(db, name="Noite", slug="night", schedule_type="fixed", weekdays="0,1,2,3,4,5,6")
|
|
sat = add_schedule(db, name="Almoço - Sábados", slug="sat")
|
|
sun = add_schedule(db, name="Almoço - Domingo", slug="sun", weekdays="6")
|
|
ana = add_person(db, "Ana")
|
|
bruno = add_person(db, "Bruno")
|
|
add_rotation_member(db, sat, ana, 0)
|
|
add_rotation_member(db, sat, bruno, 1)
|
|
add_rotation_member(db, sun, bruno, 0)
|
|
db.commit()
|
|
return night, sat, sun
|
|
|
|
|
|
def test_public_schedules_page_is_open_to_anonymous_visitors(client, db):
|
|
seed_schedules(db)
|
|
|
|
response = client.get("/schedules", follow_redirects=False)
|
|
|
|
assert response.status_code == 200
|
|
assert "Almoço - Sábados" in response.text
|
|
assert "Almoço - Domingo" in response.text
|
|
|
|
|
|
def test_rota_is_the_landing_page_for_signed_out_visitors(client, db):
|
|
seed_schedules(db)
|
|
|
|
page = client.get("/", follow_redirects=False).text
|
|
|
|
assert month_name(date.today().month) in page
|
|
assert '<a class="brand" href="/"' in page
|
|
assert "Almoço - Sábados" in page
|
|
assert "Entrar" in page
|
|
assert "Pedir troca" not in page
|
|
assert "/swap" not in page
|
|
assert 'class="assignment mine"' not in page
|
|
|
|
|
|
def test_signed_in_rota_shows_change_actions_for_own_shifts(client, db):
|
|
_, sat, _ = seed_schedules(db)
|
|
ana = db.scalar(select(User).where(User.name == "Ana"))
|
|
ana.username = "ana"
|
|
ana.password_hash = hash_password("a-secure-password")
|
|
db.commit()
|
|
login(client, "ana", "a-secure-password")
|
|
|
|
page = client.get("/", follow_redirects=False).text
|
|
|
|
assert "Pedir troca" in page
|
|
assert "/swap" in page
|
|
assert f"{sat.id}" in page
|
|
|
|
|
|
def test_public_schedules_show_details_and_rotation_order(client, db):
|
|
night, sat, _ = seed_schedules(db)
|
|
|
|
hub = client.get("/schedules").text
|
|
detail = client.get(f"/schedules/{sat.id}").text
|
|
|
|
assert "Noite" in hub
|
|
assert "Almoço - Sábados" in hub
|
|
assert "Ana" in detail
|
|
assert "Bruno" in detail
|
|
assert "Todos os dias" in client.get(f"/schedules/{night.id}").text
|
|
|
|
|
|
def test_fixed_schedule_is_described_as_repeating_every_month(client, db):
|
|
night, _, _ = seed_schedules(db)
|
|
|
|
page = client.get(f"/schedules/{night.id}").text
|
|
|
|
assert "repete todos os meses" in page
|
|
assert "Todos os dias" in page
|
|
|
|
|
|
def test_raw_weekday_numbers_are_never_shown(client, db):
|
|
night, sat, _ = seed_schedules(db)
|
|
|
|
for path in ("/schedules", f"/schedules/{night.id}", f"/schedules/{sat.id}"):
|
|
page = client.get(path).text
|
|
assert "0,1,2,3,4,5,6" not in page
|
|
assert "weekdays" not in page
|
|
|
|
|
|
def test_each_schedule_has_its_own_page(client, db):
|
|
night, sat, sun = seed_schedules(db)
|
|
|
|
hub = client.get("/schedules").text
|
|
for schedule in (night, sat, sun):
|
|
assert f'href="/schedules/{schedule.id}"' in hub
|
|
|
|
assert "Rotação · Sábado" in client.get(f"/schedules/{sat.id}").text
|
|
assert "Rotação · Domingo" in client.get(f"/schedules/{sun.id}").text
|
|
|
|
|
|
def test_inactive_schedule_page_is_not_public(client, db):
|
|
retired = add_schedule(db, name="Retired Shift", slug="retired", is_active=False)
|
|
db.commit()
|
|
|
|
assert client.get(f"/schedules/{retired.id}", follow_redirects=False).status_code == 404
|
|
|
|
|
|
def test_rotations_show_upcoming_dates_instead_of_weekdays(client, db):
|
|
_, sat, _ = seed_schedules(db)
|
|
|
|
page = client.get(f"/schedules/{sat.id}").text
|
|
|
|
first_saturday = date.today()
|
|
while first_saturday.weekday() != 5:
|
|
first_saturday += timedelta(days=1)
|
|
expected = day_short(first_saturday)
|
|
assert expected in page
|
|
|
|
|
|
def test_public_schedules_omit_inactive_schedules(client, db):
|
|
add_schedule(db, name="Retired Shift", slug="retired", is_active=False)
|
|
db.commit()
|
|
|
|
page = client.get("/schedules").text
|
|
|
|
assert "Retired Shift" not in page
|
|
|
|
|
|
def test_public_schedules_show_placeholder_when_none_exist(client, db):
|
|
page = client.get("/schedules").text
|
|
|
|
assert "Ainda não há escalas publicadas." in page
|
|
|
|
|
|
def test_public_schedules_offer_sign_in_to_anonymous_visitors(client, db):
|
|
seed_schedules(db)
|
|
|
|
assert "Entrar" in client.get("/schedules").text
|
|
|
|
|
|
def test_public_schedules_are_linked_for_anonymous_visitors(client, db):
|
|
seed_schedules(db)
|
|
|
|
assert 'href="/schedules"' in client.get("/login").text
|
|
|
|
|
|
def test_signed_in_member_can_also_read_public_schedules(client, db):
|
|
seed_schedules(db)
|
|
db.add(
|
|
User(
|
|
name="Member",
|
|
username="member",
|
|
password_hash=hash_password("member-password"),
|
|
is_active=True,
|
|
)
|
|
)
|
|
db.commit()
|
|
|
|
assert "Entrar" not in login(client, "member", "member-password")
|
|
assert "Almoço - Sábados" in client.get("/schedules").text
|
|
|
|
|
|
def test_rota_is_read_only_for_signed_out_visitors(client, db):
|
|
seed_schedules(db)
|
|
|
|
page = client.get("/", follow_redirects=False).text
|
|
|
|
assert month_name(date.today().month) in page
|
|
assert "Pedir troca" not in page
|
|
assert "/swap" not in page
|
|
assert client.get("/swaps", follow_redirects=False).status_code == 401
|
|
|
|
|
|
def test_pages_are_served_in_european_portuguese(client, db):
|
|
seed_schedules(db)
|
|
today = date.today()
|
|
page = client.get(f"/?year={today.year}&month={today.month}").text
|
|
|
|
assert '<html lang="pt-PT">' in page
|
|
assert month_name(today.month) in page
|
|
assert day_short(today) not in page # the rota shows the weekday, not the full date
|
|
assert f'<strong>{weekday_name(today.weekday(), short=True)}</strong>' in page
|
|
assert "Sem atribuição" in page
|
|
assert "Escalas" in page
|
|
|
|
|
|
def test_admin_schedules_page_separates_the_three_schedule_types(client, db):
|
|
night, sat, sun = seed_schedules(db)
|
|
db.add(
|
|
User(
|
|
name="Admin",
|
|
username="admin",
|
|
password_hash=hash_password("admin-password"),
|
|
is_active=True,
|
|
is_admin=True,
|
|
)
|
|
)
|
|
db.commit()
|
|
login(client, "admin", "admin-password")
|
|
|
|
hub = client.get("/admin/schedules").text
|
|
for schedule in (night, sat, sun):
|
|
assert f'href="/admin/schedules/{schedule.id}"' in hub
|
|
assert "weekdays" not in hub
|
|
|
|
assert "Ordem da rotação" not in client.get(f"/admin/schedules/{night.id}").text
|
|
assert "Ordem da rotação" in client.get(f"/admin/schedules/{sat.id}").text
|
|
assert "Ordem da rotação" in client.get(f"/admin/schedules/{sun.id}").text
|
|
|
|
|
|
def test_rotation_edits_return_to_the_schedule_page(client, db):
|
|
_, sat, _ = seed_schedules(db)
|
|
admin = User(
|
|
name="Admin",
|
|
username="admin",
|
|
password_hash=hash_password("admin-password"),
|
|
is_active=True,
|
|
is_admin=True,
|
|
)
|
|
db.add(admin)
|
|
db.commit()
|
|
login(client, "admin", "admin-password")
|
|
token = CSRF_RE.search(client.get(f"/admin/schedules/{sat.id}").text).group(1)
|
|
member = sat.rotation_members[0]
|
|
|
|
response = client.post(
|
|
f"/admin/rotation/{member.id}/remove",
|
|
data={"csrf_token": token},
|
|
follow_redirects=False,
|
|
)
|
|
|
|
assert response.headers["location"] == f"/admin/schedules/{sat.id}"
|
|
|
|
|
|
def test_adding_a_rotation_member_returns_to_the_rotation_order_anchor(client, db):
|
|
_, sat, _ = seed_schedules(db)
|
|
admin = User(
|
|
name="Admin",
|
|
username="admin",
|
|
password_hash=hash_password("admin-password"),
|
|
is_active=True,
|
|
is_admin=True,
|
|
)
|
|
db.add(admin)
|
|
newcomer = add_person(db, "Carla")
|
|
db.commit()
|
|
login(client, "admin", "admin-password")
|
|
page = client.get(f"/admin/schedules/{sat.id}").text
|
|
assert 'id="rotation-order"' in page
|
|
token = CSRF_RE.search(page).group(1)
|
|
|
|
response = client.post(
|
|
f"/admin/schedules/{sat.id}/rotation",
|
|
data={"csrf_token": token, "user_id": newcomer.id},
|
|
follow_redirects=False,
|
|
)
|
|
|
|
assert response.headers["location"] == f"/admin/schedules/{sat.id}#rotation-order"
|
|
db.refresh(sat)
|
|
assert newcomer.id in {member.user_id for member in sat.rotation_members}
|
|
|
|
|
|
def test_pages_and_static_files_survive_a_sub_path_deployment(client, db):
|
|
"""Behind a proxy serving /crr/, every link, form and asset keeps the prefix."""
|
|
_, sat, _ = seed_schedules(db)
|
|
monkey = pytest.MonkeyPatch()
|
|
monkey.setattr("app.config.settings.root_path", "/crr")
|
|
try:
|
|
page = TestClient(app, root_path="/crr").get("/schedules").text
|
|
finally:
|
|
monkey.undo()
|
|
|
|
# static assets are built with url_for, which already honours the prefix
|
|
assert 'href="http://testserver/crr/static/app.css"' in page
|
|
assert 'src="http://testserver/crr/static/logo-crr.png"' in page
|
|
# every hand written link goes through app_path
|
|
assert 'href="/crr/"' in page
|
|
assert 'href="/crr/schedules"' in page
|
|
assert f'href="/crr/schedules/{sat.id}"' in page
|
|
assert 'href="/crr/login"' in page
|
|
assert "http://testserver/crr/schedules/1" not in page
|
|
|
|
|
|
def test_redirects_keep_the_prefix_behind_a_sub_path_deployment(client, db):
|
|
seed_schedules(db)
|
|
monkey = pytest.MonkeyPatch()
|
|
monkey.setattr("app.config.settings.root_path", "/crr")
|
|
try:
|
|
response = client.post(
|
|
"/login",
|
|
data={
|
|
"username": "x",
|
|
"password": "y",
|
|
"csrf_token": CSRF_RE.search(client.get("/login").text).group(1),
|
|
},
|
|
follow_redirects=False,
|
|
)
|
|
finally:
|
|
monkey.undo()
|
|
|
|
assert response.status_code == 303
|
|
assert response.headers["location"].startswith("/crr/login")
|
|
|
|
|
|
def test_settings_url_only_prefixes_real_paths():
|
|
from app.config import Settings
|
|
|
|
plain = Settings(root_path="")
|
|
assert plain.prefix == ""
|
|
assert plain.url("/swaps") == "/swaps"
|
|
|
|
proxied = Settings(root_path="/crr/")
|
|
assert proxied.prefix == "/crr"
|
|
assert proxied.url("/swaps") == "/crr/swaps"
|
|
assert proxied.url("/?year=2026") == "/crr/?year=2026"
|
|
assert proxied.url("/admin/assign#rotation") == "/crr/admin/assign#rotation"
|
|
assert proxied.url("https://example.com/x") == "https://example.com/x"
|