Fix Soma integration connection issue (#27692)
* Added a check for Connect actually returning something before telling the user the setup succeeded * Added handling for KeyError in case API returns empty response, formatting * Trying to please the linter
This commit is contained in:
1 parent
004af97699
commit
01ef44fd68
4 files changed
+41
-9
No files matched your search
@@ -35,11 +35,31 @@ async def test_import_create(hass):
|
||||
"""Test configuration from YAML."""
|
||||
flow = config_flow.SomaFlowHandler()
|
||||
flow.hass = hass
|
||||
with patch.object(SomaApi, "list_devices", return_value={}):
|
||||
with patch.object(SomaApi, "list_devices", return_value={"result": "success"}):
|
||||
result = await flow.async_step_import({"host": MOCK_HOST, "port": MOCK_PORT})
|
||||
assert result["type"] == data_entry_flow.RESULT_TYPE_CREATE_ENTRY
|
||||
|
||||
|
||||
async def test_error_status(hass):
|
||||
"""Test Connect successfully returning error status."""
|
||||
flow = config_flow.SomaFlowHandler()
|
||||
flow.hass = hass
|
||||
with patch.object(SomaApi, "list_devices", return_value={"result": "error"}):
|
||||
result = await flow.async_step_import({"host": MOCK_HOST, "port": MOCK_PORT})
|
||||
assert result["type"] == data_entry_flow.RESULT_TYPE_ABORT
|
||||
assert result["reason"] == "result_error"
|
||||
|
||||
|
||||
async def test_key_error(hass):
|
||||
"""Test Connect returning empty string."""
|
||||
flow = config_flow.SomaFlowHandler()
|
||||
flow.hass = hass
|
||||
with patch.object(SomaApi, "list_devices", return_value={}):
|
||||
result = await flow.async_step_import({"host": MOCK_HOST, "port": MOCK_PORT})
|
||||
assert result["type"] == data_entry_flow.RESULT_TYPE_ABORT
|
||||
assert result["reason"] == "connection_error"
|
||||
|
||||
|
||||
async def test_exception(hass):
|
||||
"""Test if RequestException fires when no connection can be made."""
|
||||
flow = config_flow.SomaFlowHandler()
|
||||
@@ -55,6 +75,6 @@ async def test_full_flow(hass):
|
||||
hass.data[DOMAIN] = {}
|
||||
flow = config_flow.SomaFlowHandler()
|
||||
flow.hass = hass
|
||||
with patch.object(SomaApi, "list_devices", return_value={}):
|
||||
with patch.object(SomaApi, "list_devices", return_value={"result": "success"}):
|
||||
result = await flow.async_step_user({"host": MOCK_HOST, "port": MOCK_PORT})
|
||||
assert result["type"] == data_entry_flow.RESULT_TYPE_CREATE_ENTRY
|
||||
Reference in new issue
Block a user