UniFi - Try to handle when UniFi erroneously marks offline client as wired (#26960)
* Add controls to catch when client goes offline and UniFi bug marks client as wired * Device trackers shouldn't jump between going away and home * POE control shouldn't add normally wireless clients as POE control switches
This commit is contained in:
1 parent
0eb1d49046
commit
09c5b9feb3
8 files changed
+161
-22
No files matched your search
@@ -1,9 +1,11 @@
|
||||
"""The tests for the UniFi device tracker platform."""
|
||||
from collections import deque
|
||||
from copy import copy
|
||||
from unittest.mock import Mock
|
||||
|
||||
from datetime import timedelta
|
||||
|
||||
from asynctest import Mock
|
||||
|
||||
import pytest
|
||||
|
||||
from aiounifi.clients import Clients, ClientsAll
|
||||
@@ -19,6 +21,7 @@ from homeassistant.components.unifi.const import (
|
||||
CONF_TRACK_WIRED_CLIENTS,
|
||||
CONTROLLER_ID as CONF_CONTROLLER_ID,
|
||||
UNIFI_CONFIG,
|
||||
UNIFI_WIRELESS_CLIENTS,
|
||||
)
|
||||
from homeassistant.const import (
|
||||
CONF_HOST,
|
||||
@@ -96,7 +99,7 @@ CONTROLLER_DATA = {
|
||||
CONF_PASSWORD: "mock-pswd",
|
||||
CONF_PORT: 1234,
|
||||
CONF_SITE_ID: "mock-site",
|
||||
CONF_VERIFY_SSL: True,
|
||||
CONF_VERIFY_SSL: False,
|
||||
}
|
||||
|
||||
ENTRY_CONFIG = {CONF_CONTROLLER: CONTROLLER_DATA}
|
||||
@@ -108,7 +111,9 @@ CONTROLLER_ID = CONF_CONTROLLER_ID.format(host="mock-host", site="mock-site")
|
||||
def mock_controller(hass):
|
||||
"""Mock a UniFi Controller."""
|
||||
hass.data[UNIFI_CONFIG] = {}
|
||||
hass.data[UNIFI_WIRELESS_CLIENTS] = Mock()
|
||||
controller = unifi.UniFiController(hass, None)
|
||||
controller.wireless_clients = set()
|
||||
|
||||
controller.api = Mock()
|
||||
controller.mock_requests = []
|
||||
@@ -253,6 +258,45 @@ async def test_tracked_devices(hass, mock_controller):
|
||||
assert device_1 is None
|
||||
|
||||
|
||||
async def test_wireless_client_go_wired_issue(hass, mock_controller):
|
||||
"""Test the solution to catch wireless device go wired UniFi issue.
|
||||
|
||||
UniFi has a known issue that when a wireless device goes away it sometimes gets marked as wired.
|
||||
"""
|
||||
client_1_client = copy(CLIENT_1)
|
||||
client_1_client["last_seen"] = dt_util.as_timestamp(dt_util.utcnow())
|
||||
mock_controller.mock_client_responses.append([client_1_client])
|
||||
mock_controller.mock_device_responses.append({})
|
||||
|
||||
await setup_controller(hass, mock_controller)
|
||||
assert len(mock_controller.mock_requests) == 2
|
||||
assert len(hass.states.async_all()) == 3
|
||||
|
||||
client_1 = hass.states.get("device_tracker.client_1")
|
||||
assert client_1 is not None
|
||||
assert client_1.state == "home"
|
||||
|
||||
client_1_client["is_wired"] = True
|
||||
client_1_client["last_seen"] = dt_util.as_timestamp(dt_util.utcnow())
|
||||
mock_controller.mock_client_responses.append([client_1_client])
|
||||
mock_controller.mock_device_responses.append({})
|
||||
await mock_controller.async_update()
|
||||
await hass.async_block_till_done()
|
||||
|
||||
client_1 = hass.states.get("device_tracker.client_1")
|
||||
assert client_1.state == "not_home"
|
||||
|
||||
client_1_client["is_wired"] = False
|
||||
client_1_client["last_seen"] = dt_util.as_timestamp(dt_util.utcnow())
|
||||
mock_controller.mock_client_responses.append([client_1_client])
|
||||
mock_controller.mock_device_responses.append({})
|
||||
await mock_controller.async_update()
|
||||
await hass.async_block_till_done()
|
||||
|
||||
client_1 = hass.states.get("device_tracker.client_1")
|
||||
assert client_1.state == "home"
|
||||
|
||||
|
||||
async def test_restoring_client(hass, mock_controller):
|
||||
"""Test the update_items function with some clients."""
|
||||
mock_controller.mock_client_responses.append([CLIENT_2])
|
||||
|
||||
Reference in new issue
Block a user