Add tests for modbus binary sensor (#40367)
* Add test coverage of binary sensor. Update conftest to be generic. * Pass total config structure to run_base_test. Simple devices like sensor/switch do only have one entry in the dict array, whereas e.g. switch have multiple entries. * Use STATE_ON / _OFF for binary_sensor test. * Update coveragerc Only exclude files that uses a third party library. * Remove modbus/* from coveragerc * Remove modbus from .coveragerc * Update .coveragerc Co-authored-by: Chris Talkington <chris@talkingtontech.com>
This commit is contained in:
1 parent
ea6ec42bbd
commit
0ca19133d9
4 files changed
+174
-58
No files matched your search
@@ -6,14 +6,13 @@ from unittest import mock
|
||||
import pytest
|
||||
|
||||
from homeassistant.components.modbus.const import (
|
||||
CALL_TYPE_COIL,
|
||||
CALL_TYPE_DISCRETE,
|
||||
CALL_TYPE_REGISTER_INPUT,
|
||||
CONF_REGISTER,
|
||||
CONF_REGISTER_TYPE,
|
||||
CONF_REGISTERS,
|
||||
DEFAULT_HUB,
|
||||
MODBUS_DOMAIN as DOMAIN,
|
||||
)
|
||||
from homeassistant.const import CONF_NAME, CONF_PLATFORM, CONF_SCAN_INTERVAL
|
||||
from homeassistant.const import CONF_PLATFORM, CONF_SCAN_INTERVAL
|
||||
from homeassistant.setup import async_setup_component
|
||||
import homeassistant.util.dt as dt_util
|
||||
|
||||
@@ -38,31 +37,40 @@ class ReadResult:
|
||||
def __init__(self, register_words):
|
||||
"""Init."""
|
||||
self.registers = register_words
|
||||
self.bits = register_words
|
||||
|
||||
|
||||
async def run_test(
|
||||
hass, use_mock_hub, register_config, entity_domain, register_words, expected
|
||||
async def run_base_test(
|
||||
sensor_name,
|
||||
hass,
|
||||
use_mock_hub,
|
||||
data_array,
|
||||
register_type,
|
||||
entity_domain,
|
||||
register_words,
|
||||
expected,
|
||||
):
|
||||
"""Run test for given config and check that sensor outputs expected result."""
|
||||
"""Run test for given config."""
|
||||
|
||||
# Full sensor configuration
|
||||
sensor_name = "modbus_test_sensor"
|
||||
scan_interval = 5
|
||||
config = {
|
||||
entity_domain: {
|
||||
CONF_PLATFORM: "modbus",
|
||||
CONF_SCAN_INTERVAL: scan_interval,
|
||||
CONF_REGISTERS: [
|
||||
dict(**{CONF_NAME: sensor_name, CONF_REGISTER: 1234}, **register_config)
|
||||
],
|
||||
**data_array,
|
||||
}
|
||||
}
|
||||
|
||||
# Setup inputs for the sensor
|
||||
read_result = ReadResult(register_words)
|
||||
if register_config.get(CONF_REGISTER_TYPE) == CALL_TYPE_REGISTER_INPUT:
|
||||
if register_type == CALL_TYPE_COIL:
|
||||
use_mock_hub.read_coils.return_value = read_result
|
||||
elif register_type == CALL_TYPE_DISCRETE:
|
||||
use_mock_hub.read_discrete_inputs.return_value = read_result
|
||||
elif register_type == CALL_TYPE_REGISTER_INPUT:
|
||||
use_mock_hub.read_input_registers.return_value = read_result
|
||||
else:
|
||||
else: # CALL_TYPE_REGISTER_HOLDING
|
||||
use_mock_hub.read_holding_registers.return_value = read_result
|
||||
|
||||
# Initialize sensor
|
||||
@@ -76,8 +84,3 @@ async def run_test(
|
||||
with mock.patch("homeassistant.helpers.event.dt_util.utcnow", return_value=now):
|
||||
async_fire_time_changed(hass, now)
|
||||
await hass.async_block_till_done()
|
||||
|
||||
# Check state
|
||||
entity_id = f"{entity_domain}.{sensor_name}"
|
||||
state = hass.states.get(entity_id).state
|
||||
assert state == expected
|
||||
Reference in new issue
Block a user