Add binary_sensor support to RFlink (#17146)

* Add binary_sensor support to RFlink * Add support for aliases * Fix review comments * Refactor, add tests * Review comments * Review comments * Review comments * Review comments
2018-10-18 22:28:40 +02:00
parent cf3a97ff3c
commit 10c1378195
4 changed files with 284 additions and 2 deletions
@@ -0,0 +1,178 @@
+"""
+Test for RFlink sensor components.
+
+Test setup of rflink sensor component/platform. Verify manual and
+automatic sensor creation.
+"""
+from datetime import timedelta
+from unittest.mock import patch
+
+from ..test_rflink import mock_rflink
+from homeassistant.components.rflink import (
+    CONF_RECONNECT_INTERVAL)
+
+import homeassistant.core as ha
+from homeassistant.const import (
+    EVENT_STATE_CHANGED, STATE_ON, STATE_OFF, STATE_UNAVAILABLE)
+import homeassistant.util.dt as dt_util
+
+from tests.common import async_fire_time_changed
+
+DOMAIN = 'binary_sensor'
+
+CONFIG = {
+    'rflink': {
+        'port': '/dev/ttyABC0',
+        'ignore_devices': ['ignore_wildcard_*', 'ignore_sensor'],
+    },
+    DOMAIN: {
+        'platform': 'rflink',
+        'devices': {
+            'test': {
+                'name': 'test',
+                'device_class': 'door',
+            },
+            'test2': {
+                'name': 'test2',
+                'device_class': 'motion',
+                'off_delay': 30,
+                'force_update': True,
+            },
+        },
+    },
+}
+
+
+async def test_default_setup(hass, monkeypatch):
+    """Test all basic functionality of the rflink sensor component."""
+    # setup mocking rflink module
+    event_callback, create, _, disconnect_callback = await mock_rflink(
+        hass, CONFIG, DOMAIN, monkeypatch)
+
+    # make sure arguments are passed
+    assert create.call_args_list[0][1]['ignore']
+
+    # test default state of sensor loaded from config
+    config_sensor = hass.states.get('binary_sensor.test')
+    assert config_sensor
+    assert config_sensor.state == STATE_OFF
+    assert config_sensor.attributes['device_class'] == 'door'
+
+    # test event for config sensor
+    event_callback({
+        'id': 'test',
+        'command': 'on',
+    })
+    await hass.async_block_till_done()
+
+    assert hass.states.get('binary_sensor.test').state == STATE_ON
+
+    # test event for config sensor
+    event_callback({
+        'id': 'test',
+        'command': 'off',
+    })
+    await hass.async_block_till_done()
+
+    assert hass.states.get('binary_sensor.test').state == STATE_OFF
+
+
+async def test_entity_availability(hass, monkeypatch):
+    """If Rflink device is disconnected, entities should become unavailable."""
+    # Make sure Rflink mock does not 'recover' to quickly from the
+    # disconnect or else the unavailability cannot be measured
+    config = CONFIG
+    failures = [True, True]
+    config[CONF_RECONNECT_INTERVAL] = 60
+
+    # Create platform and entities
+    event_callback, create, _, disconnect_callback = await mock_rflink(
+        hass, config, DOMAIN, monkeypatch, failures=failures)
+
+    # Entities are available by default
+    assert hass.states.get('binary_sensor.test').state == STATE_OFF
+
+    # Mock a disconnect of the Rflink device
+    disconnect_callback()
+
+    # Wait for dispatch events to propagate
+    await hass.async_block_till_done()
+
+    # Entity should be unavailable
+    assert hass.states.get('binary_sensor.test').state == STATE_UNAVAILABLE
+
+    # Reconnect the Rflink device
+    disconnect_callback()
+
+    # Wait for dispatch events to propagate
+    await hass.async_block_till_done()
+
+    # Entities should be available again
+    assert hass.states.get('binary_sensor.test').state == STATE_OFF
+
+
+async def test_off_delay(hass, monkeypatch):
+    """Test off_delay option."""
+    # setup mocking rflink module
+    event_callback, create, _, disconnect_callback = await mock_rflink(
+        hass, CONFIG, DOMAIN, monkeypatch)
+
+    # make sure arguments are passed
+    assert create.call_args_list[0][1]['ignore']
+
+    events = []
+
+    on_event = {
+        'id': 'test2',
+        'command': 'on',
+    }
+
+    @ha.callback
+    def callback(event):
+        """Verify event got called."""
+        events.append(event)
+
+    hass.bus.async_listen(EVENT_STATE_CHANGED, callback)
+
+    now = dt_util.utcnow()
+    # fake time and turn on sensor
+    future = now + timedelta(seconds=0)
+    with patch(('homeassistant.helpers.event.'
+                'dt_util.utcnow'), return_value=future):
+        async_fire_time_changed(hass, future)
+        event_callback(on_event)
+        await hass.async_block_till_done()
+    state = hass.states.get('binary_sensor.test2')
+    assert state.state == STATE_ON
+    assert len(events) == 1
+
+    # fake time and turn on sensor again
+    future = now + timedelta(seconds=15)
+    with patch(('homeassistant.helpers.event.'
+                'dt_util.utcnow'), return_value=future):
+        async_fire_time_changed(hass, future)
+        event_callback(on_event)
+        await hass.async_block_till_done()
+    state = hass.states.get('binary_sensor.test2')
+    assert state.state == STATE_ON
+    assert len(events) == 2
+
+    # fake time and verify sensor still on (de-bounce)
+    future = now + timedelta(seconds=35)
+    with patch(('homeassistant.helpers.event.'
+                'dt_util.utcnow'), return_value=future):
+        async_fire_time_changed(hass, future)
+        await hass.async_block_till_done()
+    state = hass.states.get('binary_sensor.test2')
+    assert state.state == STATE_ON
+    assert len(events) == 2
+
+    # fake time and verify sensor is off
+    future = now + timedelta(seconds=45)
+    with patch(('homeassistant.helpers.event.'
+                'dt_util.utcnow'), return_value=future):
+        async_fire_time_changed(hass, future)
+        await hass.async_block_till_done()
+    state = hass.states.get('binary_sensor.test2')
+    assert state.state == STATE_OFF
+    assert len(events) == 3