Complete deprecation of hidden attribute (ATTR_HIDDEN) (#37041)
This commit is contained in:
1 parent
c289f9f099
commit
152a80abed
7 files changed
+4
-59
No files matched your search
@@ -202,21 +202,6 @@ class TestAlert(unittest.TestCase):
|
||||
self.hass.block_till_done()
|
||||
assert STATE_ON == self.hass.states.get(ENTITY_ID).state
|
||||
|
||||
def test_hidden(self):
|
||||
"""Test entity hiding."""
|
||||
assert setup_component(self.hass, alert.DOMAIN, TEST_CONFIG)
|
||||
hidden = self.hass.states.get(ENTITY_ID).attributes.get("hidden")
|
||||
assert hidden
|
||||
|
||||
self.hass.states.set("sensor.test", STATE_ON)
|
||||
self.hass.block_till_done()
|
||||
hidden = self.hass.states.get(ENTITY_ID).attributes.get("hidden")
|
||||
assert not hidden
|
||||
|
||||
turn_off(self.hass, ENTITY_ID)
|
||||
hidden = self.hass.states.get(ENTITY_ID).attributes.get("hidden")
|
||||
assert not hidden
|
||||
|
||||
def test_notification_no_done_message(self):
|
||||
"""Test notifications."""
|
||||
events = []
|
||||
@@ -359,8 +344,6 @@ class TestAlert(unittest.TestCase):
|
||||
self.hass.add_job(entity.begin_alerting)
|
||||
self.hass.block_till_done()
|
||||
|
||||
assert entity.hidden is True
|
||||
|
||||
def test_done_message_state_tracker_reset_on_cancel(self):
|
||||
"""Test that the done message is reset when canceled."""
|
||||
entity = alert.Alert(self.hass, *TEST_NOACK)
|
||||
|
||||
@@ -6,11 +6,9 @@ import threading
|
||||
|
||||
import pytest
|
||||
|
||||
from homeassistant.config import DATA_CUSTOMIZE
|
||||
from homeassistant.const import ATTR_DEVICE_CLASS, ATTR_HIDDEN, STATE_UNAVAILABLE
|
||||
from homeassistant.const import ATTR_DEVICE_CLASS, STATE_UNAVAILABLE
|
||||
from homeassistant.core import Context
|
||||
from homeassistant.helpers import entity, entity_registry
|
||||
from homeassistant.helpers.entity_values import EntityValues
|
||||
|
||||
from tests.async_mock import MagicMock, PropertyMock, patch
|
||||
from tests.common import get_test_home_assistant, mock_registry
|
||||
@@ -89,21 +87,6 @@ class TestHelpersEntity:
|
||||
"""Stop everything that was started."""
|
||||
self.hass.stop()
|
||||
|
||||
def test_default_hidden_not_in_attributes(self):
|
||||
"""Test that the default hidden property is set to False."""
|
||||
assert ATTR_HIDDEN not in self.hass.states.get(self.entity.entity_id).attributes
|
||||
|
||||
def test_overwriting_hidden_property_to_true(self):
|
||||
"""Test we can overwrite hidden property to True."""
|
||||
self.hass.data[DATA_CUSTOMIZE] = EntityValues(
|
||||
{self.entity.entity_id: {ATTR_HIDDEN: True}}
|
||||
)
|
||||
self.entity.schedule_update_ha_state()
|
||||
self.hass.block_till_done()
|
||||
|
||||
state = self.hass.states.get(self.entity.entity_id)
|
||||
assert state.attributes.get(ATTR_HIDDEN)
|
||||
|
||||
def test_generate_entity_id_given_hass(self):
|
||||
"""Test generating an entity id given hass object."""
|
||||
fmt = "test.{}"
|
||||
|
||||
@@ -14,7 +14,6 @@ import homeassistant.config as config_util
|
||||
from homeassistant.const import (
|
||||
ATTR_ASSUMED_STATE,
|
||||
ATTR_FRIENDLY_NAME,
|
||||
ATTR_HIDDEN,
|
||||
CONF_AUTH_MFA_MODULES,
|
||||
CONF_AUTH_PROVIDERS,
|
||||
CONF_CUSTOMIZE,
|
||||
@@ -203,7 +202,7 @@ def test_core_config_schema():
|
||||
|
||||
def test_customize_dict_schema():
|
||||
"""Test basic customize config validation."""
|
||||
values = ({ATTR_FRIENDLY_NAME: None}, {ATTR_HIDDEN: "2"}, {ATTR_ASSUMED_STATE: "2"})
|
||||
values = ({ATTR_FRIENDLY_NAME: None}, {ATTR_ASSUMED_STATE: "2"})
|
||||
|
||||
for val in values:
|
||||
print(val)
|
||||
@@ -211,8 +210,8 @@ def test_customize_dict_schema():
|
||||
config_util.CUSTOMIZE_DICT_SCHEMA(val)
|
||||
|
||||
assert config_util.CUSTOMIZE_DICT_SCHEMA(
|
||||
{ATTR_FRIENDLY_NAME: 2, ATTR_HIDDEN: "1", ATTR_ASSUMED_STATE: "0"}
|
||||
) == {ATTR_FRIENDLY_NAME: "2", ATTR_HIDDEN: True, ATTR_ASSUMED_STATE: False}
|
||||
{ATTR_FRIENDLY_NAME: 2, ATTR_ASSUMED_STATE: "0"}
|
||||
) == {ATTR_FRIENDLY_NAME: "2", ATTR_ASSUMED_STATE: False}
|
||||
|
||||
|
||||
def test_customize_glob_is_ordered():
|
||||
|
||||
Reference in new issue
Block a user