Fix: state_as_number always return float
This commit is contained in:
1 parent
e9fa1f1f83
commit
1571b33e4a
5 files changed
+14
-29
No files matched your search
@@ -89,6 +89,7 @@ class TestGraphite(unittest.TestCase):
|
||||
'bat': 'NaN',
|
||||
}
|
||||
expected = [
|
||||
'ha.entity.state 0.000000 12345',
|
||||
'ha.entity.foo 1.000000 12345',
|
||||
'ha.entity.bar 2.000000 12345',
|
||||
'ha.entity.baz 1.000000 12345',
|
||||
|
||||
@@ -7,6 +7,7 @@ Tests statsd feeder.
|
||||
import unittest
|
||||
from unittest import mock
|
||||
|
||||
import homeassistant.core as ha
|
||||
import homeassistant.components.statsd as statsd
|
||||
from homeassistant.const import STATE_ON, STATE_OFF, EVENT_STATE_CHANGED
|
||||
|
||||
@@ -78,6 +79,6 @@ class TestStatsd(unittest.TestCase):
|
||||
mock_gauge.return_value.send.reset_mock()
|
||||
|
||||
for invalid in ('foo', '', object):
|
||||
state = mock.MagicMock(state=invalid)
|
||||
handler_method(mock.MagicMock(data={'new_state': state}))
|
||||
handler_method(mock.MagicMock(data={
|
||||
'new_state': ha.State('domain.test', invalid, {})}))
|
||||
self.assertFalse(mock_gauge.return_value.send.called)
|
||||
@@ -165,24 +165,18 @@ class TestStateHelpers(unittest.TestCase):
|
||||
ha.State('domain.test', _state, {})))
|
||||
|
||||
def test_as_number_coercion(self):
|
||||
for _state in ('0', '0.0'):
|
||||
for _state in ('0', '0.0', 0, 0.0):
|
||||
self.assertEqual(
|
||||
0.0, float(state.state_as_number(
|
||||
ha.State('domain.test', _state, {}))))
|
||||
for _state in ('1', '1.0'):
|
||||
0.0, state.state_as_number(
|
||||
ha.State('domain.test', _state, {})))
|
||||
for _state in ('1', '1.0', 1, 1.0):
|
||||
self.assertEqual(
|
||||
1.0, float(state.state_as_number(
|
||||
ha.State('domain.test', _state, {}))))
|
||||
|
||||
def test_as_number_tries_to_keep_types(self):
|
||||
result = state.state_as_number(ha.State('domain.test', '1', {}))
|
||||
self.assertTrue(isinstance(result, int))
|
||||
result = state.state_as_number(ha.State('domain.test', '1.0', {}))
|
||||
self.assertTrue(isinstance(result, float))
|
||||
1.0, state.state_as_number(
|
||||
ha.State('domain.test', _state, {})))
|
||||
|
||||
def test_as_number_invalid_cases(self):
|
||||
for _state in ('', 'foo', 'foo.bar', None, False, True, None,
|
||||
object, object()):
|
||||
for _state in ('', 'foo', 'foo.bar', None, False, True, object,
|
||||
object()):
|
||||
self.assertRaises(ValueError,
|
||||
state.state_as_number,
|
||||
ha.State('domain.test', _state, {}))
|
||||
Reference in new issue
Block a user