Fix some warnings found by quantifiedcode (#8027)
* Cleanup of warnings by quantifiedcode * Fix lint * Fix test * Delete insteon_hub component * Also update .coveragerc
This commit is contained in:
1 parent
afb9cba806
commit
1fde234c78
7 files changed
+20
-159
No files matched your search
@@ -2,8 +2,8 @@
|
||||
import asyncio
|
||||
import json
|
||||
import os
|
||||
import unittest
|
||||
from collections import defaultdict
|
||||
import unittest
|
||||
from unittest.mock import patch
|
||||
|
||||
from tests.common import (assert_setup_component, fire_mqtt_message,
|
||||
@@ -187,9 +187,9 @@ REGION_LEAVE_ZERO_MESSAGE = {
|
||||
BAD_JSON_PREFIX = '--$this is bad json#--'
|
||||
BAD_JSON_SUFFIX = '** and it ends here ^^'
|
||||
|
||||
SECRET_KEY = 's3cretkey'
|
||||
TEST_SECRET_KEY = 's3cretkey'
|
||||
ENCRYPTED_LOCATION_MESSAGE = {
|
||||
# Encrypted version of LOCATION_MESSAGE using libsodium and SECRET_KEY
|
||||
# Encrypted version of LOCATION_MESSAGE using libsodium and TEST_SECRET_KEY
|
||||
'_type': 'encrypted',
|
||||
'data': ('qm1A83I6TVFRmH5343xy+cbex8jBBxDFkHRuJhELVKVRA/DgXcyKtghw'
|
||||
'9pOw75Lo4gHcyy2wV5CmkjrpKEBR7Qhye4AR0y7hOvlx6U/a3GuY1+W8'
|
||||
@@ -685,6 +685,18 @@ class TestDeviceTrackerOwnTracks(BaseMQTT):
|
||||
self.assertTrue(wayp == new_wayp)
|
||||
|
||||
|
||||
def mock_cipher():
|
||||
"""Return a dummy pickle-based cipher."""
|
||||
def mock_decrypt(ciphertext, key):
|
||||
"""Decrypt/unpickle."""
|
||||
import pickle
|
||||
(mkey, plaintext) = pickle.loads(ciphertext)
|
||||
if key != mkey:
|
||||
raise ValueError()
|
||||
return plaintext
|
||||
return (len(TEST_SECRET_KEY), mock_decrypt)
|
||||
|
||||
|
||||
class TestDeviceTrackerOwnTrackConfigs(BaseMQTT):
|
||||
"""Test the OwnTrack sensor."""
|
||||
|
||||
@@ -699,17 +711,6 @@ class TestDeviceTrackerOwnTrackConfigs(BaseMQTT):
|
||||
"""Tear down resources."""
|
||||
self.hass.stop()
|
||||
|
||||
def mock_cipher(): # pylint: disable=no-method-argument
|
||||
"""Return a dummy pickle-based cipher."""
|
||||
def mock_decrypt(ciphertext, key):
|
||||
"""Decrypt/unpickle."""
|
||||
import pickle
|
||||
(mkey, plaintext) = pickle.loads(ciphertext)
|
||||
if key != mkey:
|
||||
raise ValueError()
|
||||
return plaintext
|
||||
return (len(SECRET_KEY), mock_decrypt)
|
||||
|
||||
@patch('homeassistant.components.device_tracker.owntracks.get_cipher',
|
||||
mock_cipher)
|
||||
def test_encrypted_payload(self):
|
||||
@@ -718,7 +719,7 @@ class TestDeviceTrackerOwnTrackConfigs(BaseMQTT):
|
||||
assert setup_component(self.hass, device_tracker.DOMAIN, {
|
||||
device_tracker.DOMAIN: {
|
||||
CONF_PLATFORM: 'owntracks',
|
||||
CONF_SECRET: SECRET_KEY,
|
||||
CONF_SECRET: TEST_SECRET_KEY,
|
||||
}})
|
||||
self.send_message(LOCATION_TOPIC, MOCK_ENCRYPTED_LOCATION_MESSAGE)
|
||||
self.assert_location_latitude(2.0)
|
||||
@@ -732,7 +733,7 @@ class TestDeviceTrackerOwnTrackConfigs(BaseMQTT):
|
||||
device_tracker.DOMAIN: {
|
||||
CONF_PLATFORM: 'owntracks',
|
||||
CONF_SECRET: {
|
||||
LOCATION_TOPIC: SECRET_KEY,
|
||||
LOCATION_TOPIC: TEST_SECRET_KEY,
|
||||
}}})
|
||||
self.send_message(LOCATION_TOPIC, MOCK_ENCRYPTED_LOCATION_MESSAGE)
|
||||
self.assert_location_latitude(2.0)
|
||||
@@ -803,7 +804,7 @@ class TestDeviceTrackerOwnTrackConfigs(BaseMQTT):
|
||||
assert setup_component(self.hass, device_tracker.DOMAIN, {
|
||||
device_tracker.DOMAIN: {
|
||||
CONF_PLATFORM: 'owntracks',
|
||||
CONF_SECRET: SECRET_KEY,
|
||||
CONF_SECRET: TEST_SECRET_KEY,
|
||||
}})
|
||||
|
||||
self.send_message(LOCATION_TOPIC, ENCRYPTED_LOCATION_MESSAGE)
|
||||
|
||||
Reference in new issue
Block a user