Add config flow to Meteo-France (#29927)
* Add config flow to Meteo-France * Review 1 * Use config_entry.unique_id * Fix config_flow _show_setup_form + init * Remove empty *_setup_platform() * Avoid HomeAssistantError: Entity id already exists: sensor.[city_name]_[sensor_type]. Platform meteo_france does not generate unique IDs - when multiple district in one city * Review + abort when API error * Fix I/O * Remove monitored_conditions * Add async_unload_entry * Review 3 * Fix pipe * alert_watcher is already None * Review 4 * Better fix for "Entity id already exists" * Whoops, fix tests * Fix string
This commit is contained in:
1 parent
1efea50654
commit
201ea2557e
14 files changed
+389
-155
No files matched your search
@@ -0,0 +1 @@
|
||||
"""Tests for the Meteo-France component."""
|
||||
@@ -0,0 +1,128 @@
|
||||
"""Tests for the Meteo-France config flow."""
|
||||
from unittest.mock import patch
|
||||
|
||||
from meteofrance.client import meteofranceError
|
||||
import pytest
|
||||
|
||||
from homeassistant import data_entry_flow
|
||||
from homeassistant.components.meteo_france.const import CONF_CITY, DOMAIN
|
||||
from homeassistant.config_entries import SOURCE_IMPORT, SOURCE_USER
|
||||
|
||||
from tests.common import MockConfigEntry
|
||||
|
||||
CITY_1_POSTAL = "74220"
|
||||
CITY_1_NAME = "La Clusaz"
|
||||
CITY_2_POSTAL_DISTRICT_1 = "69001"
|
||||
CITY_2_POSTAL_DISTRICT_4 = "69004"
|
||||
CITY_2_NAME = "Lyon"
|
||||
|
||||
|
||||
@pytest.fixture(name="client_1")
|
||||
def mock_controller_client_1():
|
||||
"""Mock a successful client."""
|
||||
with patch(
|
||||
"homeassistant.components.meteo_france.config_flow.meteofranceClient",
|
||||
update=False,
|
||||
) as service_mock:
|
||||
service_mock.return_value.get_data.return_value = {"name": CITY_1_NAME}
|
||||
yield service_mock
|
||||
|
||||
|
||||
@pytest.fixture(name="client_2")
|
||||
def mock_controller_client_2():
|
||||
"""Mock a successful client."""
|
||||
with patch(
|
||||
"homeassistant.components.meteo_france.config_flow.meteofranceClient",
|
||||
update=False,
|
||||
) as service_mock:
|
||||
service_mock.return_value.get_data.return_value = {"name": CITY_2_NAME}
|
||||
yield service_mock
|
||||
|
||||
|
||||
async def test_user(hass, client_1):
|
||||
"""Test user config."""
|
||||
result = await hass.config_entries.flow.async_init(
|
||||
DOMAIN, context={"source": SOURCE_USER}
|
||||
)
|
||||
assert result["type"] == data_entry_flow.RESULT_TYPE_FORM
|
||||
assert result["step_id"] == "user"
|
||||
|
||||
# test with all provided
|
||||
result = await hass.config_entries.flow.async_init(
|
||||
DOMAIN, context={"source": SOURCE_USER}, data={CONF_CITY: CITY_1_POSTAL},
|
||||
)
|
||||
assert result["type"] == data_entry_flow.RESULT_TYPE_CREATE_ENTRY
|
||||
assert result["result"].unique_id == CITY_1_NAME
|
||||
assert result["title"] == CITY_1_NAME
|
||||
assert result["data"][CONF_CITY] == CITY_1_POSTAL
|
||||
|
||||
|
||||
async def test_import(hass, client_1):
|
||||
"""Test import step."""
|
||||
# import with all
|
||||
result = await hass.config_entries.flow.async_init(
|
||||
DOMAIN, context={"source": SOURCE_IMPORT}, data={CONF_CITY: CITY_1_POSTAL},
|
||||
)
|
||||
assert result["type"] == data_entry_flow.RESULT_TYPE_CREATE_ENTRY
|
||||
assert result["result"].unique_id == CITY_1_NAME
|
||||
assert result["title"] == CITY_1_NAME
|
||||
assert result["data"][CONF_CITY] == CITY_1_POSTAL
|
||||
|
||||
|
||||
async def test_abort_if_already_setup(hass, client_1):
|
||||
"""Test we abort if already setup."""
|
||||
MockConfigEntry(
|
||||
domain=DOMAIN, data={CONF_CITY: CITY_1_POSTAL}, unique_id=CITY_1_NAME
|
||||
).add_to_hass(hass)
|
||||
|
||||
# Should fail, same CITY same postal code (import)
|
||||
result = await hass.config_entries.flow.async_init(
|
||||
DOMAIN, context={"source": SOURCE_IMPORT}, data={CONF_CITY: CITY_1_POSTAL},
|
||||
)
|
||||
assert result["type"] == data_entry_flow.RESULT_TYPE_ABORT
|
||||
assert result["reason"] == "already_configured"
|
||||
|
||||
# Should fail, same CITY same postal code (flow)
|
||||
result = await hass.config_entries.flow.async_init(
|
||||
DOMAIN, context={"source": SOURCE_USER}, data={CONF_CITY: CITY_1_POSTAL},
|
||||
)
|
||||
assert result["type"] == data_entry_flow.RESULT_TYPE_ABORT
|
||||
assert result["reason"] == "already_configured"
|
||||
|
||||
|
||||
async def test_abort_if_already_setup_district(hass, client_2):
|
||||
"""Test we abort if already setup."""
|
||||
MockConfigEntry(
|
||||
domain=DOMAIN, data={CONF_CITY: CITY_2_POSTAL_DISTRICT_1}, unique_id=CITY_2_NAME
|
||||
).add_to_hass(hass)
|
||||
|
||||
# Should fail, same CITY different postal code (import)
|
||||
result = await hass.config_entries.flow.async_init(
|
||||
DOMAIN,
|
||||
context={"source": SOURCE_IMPORT},
|
||||
data={CONF_CITY: CITY_2_POSTAL_DISTRICT_4},
|
||||
)
|
||||
assert result["type"] == data_entry_flow.RESULT_TYPE_ABORT
|
||||
assert result["reason"] == "already_configured"
|
||||
|
||||
# Should fail, same CITY different postal code (flow)
|
||||
result = await hass.config_entries.flow.async_init(
|
||||
DOMAIN,
|
||||
context={"source": SOURCE_USER},
|
||||
data={CONF_CITY: CITY_2_POSTAL_DISTRICT_4},
|
||||
)
|
||||
assert result["type"] == data_entry_flow.RESULT_TYPE_ABORT
|
||||
assert result["reason"] == "already_configured"
|
||||
|
||||
|
||||
async def test_client_failed(hass):
|
||||
"""Test when we have errors during client fetch."""
|
||||
with patch(
|
||||
"homeassistant.components.meteo_france.config_flow.meteofranceClient",
|
||||
side_effect=meteofranceError(),
|
||||
):
|
||||
result = await hass.config_entries.flow.async_init(
|
||||
DOMAIN, context={"source": SOURCE_USER}, data={CONF_CITY: CITY_1_POSTAL},
|
||||
)
|
||||
assert result["type"] == data_entry_flow.RESULT_TYPE_ABORT
|
||||
assert result["reason"] == "unknown"
|
||||
Reference in new issue
Block a user