Fix recorder stopping after unserializable state (#36937)
* Ensure unserializable states do not collapse recording * augment test coverage * fix wal mode being set every time
This commit is contained in:
1 parent
683d960fa5
commit
2b5e7c2611
2 files changed
+82
-12
No files matched your search
@@ -5,9 +5,14 @@ import unittest
|
||||
|
||||
import pytest
|
||||
|
||||
from homeassistant.components.recorder import Recorder
|
||||
from homeassistant.components.recorder import (
|
||||
Recorder,
|
||||
run_information,
|
||||
run_information_from_instance,
|
||||
run_information_with_session,
|
||||
)
|
||||
from homeassistant.components.recorder.const import DATA_INSTANCE
|
||||
from homeassistant.components.recorder.models import Events, States
|
||||
from homeassistant.components.recorder.models import Events, RecorderRuns, States
|
||||
from homeassistant.components.recorder.util import session_scope
|
||||
from homeassistant.const import MATCH_ALL
|
||||
from homeassistant.core import ATTR_NOW, EVENT_TIME_CHANGED, callback
|
||||
@@ -284,3 +289,61 @@ def test_saving_sets_old_state(hass_recorder):
|
||||
assert states[1].old_state_id is None
|
||||
assert states[2].old_state_id == states[0].state_id
|
||||
assert states[3].old_state_id == states[1].state_id
|
||||
|
||||
|
||||
def test_saving_state_with_serializable_data(hass_recorder, caplog):
|
||||
"""Test saving data that cannot be serialized does not crash."""
|
||||
hass = hass_recorder()
|
||||
|
||||
hass.states.set("test.one", "on", {"fail": CannotSerializeMe()})
|
||||
wait_recording_done(hass)
|
||||
hass.states.set("test.two", "on", {})
|
||||
wait_recording_done(hass)
|
||||
hass.states.set("test.two", "off", {})
|
||||
wait_recording_done(hass)
|
||||
|
||||
with session_scope(hass=hass) as session:
|
||||
states = list(session.query(States))
|
||||
assert len(states) == 2
|
||||
|
||||
assert states[0].entity_id == "test.two"
|
||||
assert states[1].entity_id == "test.two"
|
||||
assert states[0].old_state_id is None
|
||||
assert states[1].old_state_id == states[0].state_id
|
||||
|
||||
assert "State is not JSON serializable" in caplog.text
|
||||
|
||||
|
||||
def test_run_information(hass_recorder):
|
||||
"""Ensure run_information returns expected data."""
|
||||
before_start_recording = dt_util.utcnow()
|
||||
hass = hass_recorder()
|
||||
run_info = run_information_from_instance(hass)
|
||||
assert isinstance(run_info, RecorderRuns)
|
||||
assert run_info.closed_incorrect is False
|
||||
|
||||
with session_scope(hass=hass) as session:
|
||||
run_info = run_information_with_session(session)
|
||||
assert isinstance(run_info, RecorderRuns)
|
||||
assert run_info.closed_incorrect is False
|
||||
|
||||
run_info = run_information(hass)
|
||||
assert isinstance(run_info, RecorderRuns)
|
||||
assert run_info.closed_incorrect is False
|
||||
|
||||
hass.states.set("test.two", "on", {})
|
||||
wait_recording_done(hass)
|
||||
run_info = run_information(hass)
|
||||
assert isinstance(run_info, RecorderRuns)
|
||||
assert run_info.closed_incorrect is False
|
||||
|
||||
run_info = run_information(hass, before_start_recording)
|
||||
assert run_info is None
|
||||
|
||||
run_info = run_information(hass, dt_util.utcnow())
|
||||
assert isinstance(run_info, RecorderRuns)
|
||||
assert run_info.closed_incorrect is False
|
||||
|
||||
|
||||
class CannotSerializeMe:
|
||||
"""A class that the JSONEncoder cannot serialize."""
|
||||
Reference in new issue
Block a user