Remove unsupported states from security systems in HomeKit (#40060)
This commit is contained in:
1 parent
d25192d8c5
commit
2b7e735e3d
2 files changed
+195
-2
No files matched your search
@@ -1,7 +1,14 @@
|
||||
"""Test different accessory types: Security Systems."""
|
||||
from pyhap.loader import get_loader
|
||||
import pytest
|
||||
|
||||
from homeassistant.components.alarm_control_panel import DOMAIN
|
||||
from homeassistant.components.alarm_control_panel.const import (
|
||||
SUPPORT_ALARM_ARM_AWAY,
|
||||
SUPPORT_ALARM_ARM_HOME,
|
||||
SUPPORT_ALARM_ARM_NIGHT,
|
||||
SUPPORT_ALARM_TRIGGER,
|
||||
)
|
||||
from homeassistant.components.homekit.const import ATTR_VALUE
|
||||
from homeassistant.components.homekit.type_security_systems import SecuritySystem
|
||||
from homeassistant.const import (
|
||||
@@ -129,3 +136,116 @@ async def test_no_alarm_code(hass, hk_driver, config, events):
|
||||
assert acc.char_target_state.value == 0
|
||||
assert len(events) == 1
|
||||
assert events[-1].data[ATTR_VALUE] is None
|
||||
|
||||
|
||||
async def test_supported_states(hass, hk_driver, events):
|
||||
"""Test different supported states."""
|
||||
code = "1234"
|
||||
config = {ATTR_CODE: code}
|
||||
entity_id = "alarm_control_panel.test"
|
||||
|
||||
loader = get_loader()
|
||||
default_current_states = loader.get_char(
|
||||
"SecuritySystemCurrentState"
|
||||
).properties.get("ValidValues")
|
||||
default_target_services = loader.get_char(
|
||||
"SecuritySystemTargetState"
|
||||
).properties.get("ValidValues")
|
||||
|
||||
# Set up a number of test configuration
|
||||
test_configs = [
|
||||
{
|
||||
"features": SUPPORT_ALARM_ARM_HOME,
|
||||
"current_values": [
|
||||
default_current_states["Disarmed"],
|
||||
default_current_states["AlarmTriggered"],
|
||||
default_current_states["StayArm"],
|
||||
],
|
||||
"target_values": [
|
||||
default_target_services["Disarm"],
|
||||
default_target_services["StayArm"],
|
||||
],
|
||||
},
|
||||
{
|
||||
"features": SUPPORT_ALARM_ARM_AWAY,
|
||||
"current_values": [
|
||||
default_current_states["Disarmed"],
|
||||
default_current_states["AlarmTriggered"],
|
||||
default_current_states["AwayArm"],
|
||||
],
|
||||
"target_values": [
|
||||
default_target_services["Disarm"],
|
||||
default_target_services["AwayArm"],
|
||||
],
|
||||
},
|
||||
{
|
||||
"features": SUPPORT_ALARM_ARM_HOME | SUPPORT_ALARM_ARM_AWAY,
|
||||
"current_values": [
|
||||
default_current_states["Disarmed"],
|
||||
default_current_states["AlarmTriggered"],
|
||||
default_current_states["StayArm"],
|
||||
default_current_states["AwayArm"],
|
||||
],
|
||||
"target_values": [
|
||||
default_target_services["Disarm"],
|
||||
default_target_services["StayArm"],
|
||||
default_target_services["AwayArm"],
|
||||
],
|
||||
},
|
||||
{
|
||||
"features": SUPPORT_ALARM_ARM_HOME
|
||||
| SUPPORT_ALARM_ARM_AWAY
|
||||
| SUPPORT_ALARM_ARM_NIGHT,
|
||||
"current_values": [
|
||||
default_current_states["Disarmed"],
|
||||
default_current_states["AlarmTriggered"],
|
||||
default_current_states["StayArm"],
|
||||
default_current_states["AwayArm"],
|
||||
default_current_states["NightArm"],
|
||||
],
|
||||
"target_values": [
|
||||
default_target_services["Disarm"],
|
||||
default_target_services["StayArm"],
|
||||
default_target_services["AwayArm"],
|
||||
default_target_services["NightArm"],
|
||||
],
|
||||
},
|
||||
{
|
||||
"features": SUPPORT_ALARM_ARM_HOME
|
||||
| SUPPORT_ALARM_ARM_AWAY
|
||||
| SUPPORT_ALARM_ARM_NIGHT
|
||||
| SUPPORT_ALARM_TRIGGER,
|
||||
"current_values": [
|
||||
default_current_states["Disarmed"],
|
||||
default_current_states["AlarmTriggered"],
|
||||
default_current_states["StayArm"],
|
||||
default_current_states["AwayArm"],
|
||||
default_current_states["NightArm"],
|
||||
],
|
||||
"target_values": [
|
||||
default_target_services["Disarm"],
|
||||
default_target_services["StayArm"],
|
||||
default_target_services["AwayArm"],
|
||||
default_target_services["NightArm"],
|
||||
],
|
||||
},
|
||||
]
|
||||
|
||||
for test_config in test_configs:
|
||||
attrs = {"supported_features": test_config.get("features")}
|
||||
|
||||
hass.states.async_set(entity_id, None, attributes=attrs)
|
||||
await hass.async_block_till_done()
|
||||
|
||||
acc = SecuritySystem(hass, hk_driver, "SecuritySystem", entity_id, 2, config)
|
||||
await acc.run_handler()
|
||||
await hass.async_block_till_done()
|
||||
|
||||
valid_current_values = acc.char_current_state.properties.get("ValidValues")
|
||||
valid_target_values = acc.char_target_state.properties.get("ValidValues")
|
||||
|
||||
for val in valid_current_values.values():
|
||||
assert val in test_config.get("current_values")
|
||||
|
||||
for val in valid_target_values.values():
|
||||
assert val in test_config.get("target_values")
|
||||
Reference in new issue
Block a user