Add monitored conditions for Unifi device_tracker (#15888)
* Add support for monitored_conditions for attributes * Update unifi tests * Add list of available attrs
This commit is contained in:
1 parent
ba2e43600e
commit
39647a15ae
2 files changed
+75
-16
No files matched your search
@@ -10,7 +10,8 @@ import voluptuous as vol
|
||||
|
||||
from homeassistant.components.device_tracker import DOMAIN, unifi as unifi
|
||||
from homeassistant.const import (CONF_HOST, CONF_USERNAME, CONF_PASSWORD,
|
||||
CONF_PLATFORM, CONF_VERIFY_SSL)
|
||||
CONF_PLATFORM, CONF_VERIFY_SSL,
|
||||
CONF_MONITORED_CONDITIONS)
|
||||
DEFAULT_DETECTION_TIME = timedelta(seconds=300)
|
||||
|
||||
|
||||
@@ -54,7 +55,7 @@ def test_config_valid_verify_ssl(hass, mock_scanner, mock_ctrl):
|
||||
assert mock_scanner.call_count == 1
|
||||
assert mock_scanner.call_args == mock.call(mock_ctrl.return_value,
|
||||
DEFAULT_DETECTION_TIME,
|
||||
None)
|
||||
None, None)
|
||||
|
||||
|
||||
def test_config_minimal(hass, mock_scanner, mock_ctrl):
|
||||
@@ -76,7 +77,7 @@ def test_config_minimal(hass, mock_scanner, mock_ctrl):
|
||||
assert mock_scanner.call_count == 1
|
||||
assert mock_scanner.call_args == mock.call(mock_ctrl.return_value,
|
||||
DEFAULT_DETECTION_TIME,
|
||||
None)
|
||||
None, None)
|
||||
|
||||
|
||||
def test_config_full(hass, mock_scanner, mock_ctrl):
|
||||
@@ -88,6 +89,7 @@ def test_config_full(hass, mock_scanner, mock_ctrl):
|
||||
CONF_PASSWORD: 'password',
|
||||
CONF_HOST: 'myhost',
|
||||
CONF_VERIFY_SSL: False,
|
||||
CONF_MONITORED_CONDITIONS: ['essid', 'signal'],
|
||||
'port': 123,
|
||||
'site_id': 'abcdef01',
|
||||
'detection_time': 300,
|
||||
@@ -101,9 +103,11 @@ def test_config_full(hass, mock_scanner, mock_ctrl):
|
||||
version='v4', site_id='abcdef01', ssl_verify=False)
|
||||
|
||||
assert mock_scanner.call_count == 1
|
||||
assert mock_scanner.call_args == mock.call(mock_ctrl.return_value,
|
||||
DEFAULT_DETECTION_TIME,
|
||||
None)
|
||||
assert mock_scanner.call_args == mock.call(
|
||||
mock_ctrl.return_value,
|
||||
DEFAULT_DETECTION_TIME,
|
||||
None,
|
||||
config[DOMAIN][CONF_MONITORED_CONDITIONS])
|
||||
|
||||
|
||||
def test_config_error():
|
||||
@@ -157,7 +161,7 @@ def test_scanner_update():
|
||||
'last_seen': dt_util.as_timestamp(dt_util.utcnow())},
|
||||
]
|
||||
ctrl.get_clients.return_value = fake_clients
|
||||
unifi.UnifiScanner(ctrl, DEFAULT_DETECTION_TIME, None)
|
||||
unifi.UnifiScanner(ctrl, DEFAULT_DETECTION_TIME, None, None)
|
||||
assert ctrl.get_clients.call_count == 1
|
||||
assert ctrl.get_clients.call_args == mock.call()
|
||||
|
||||
@@ -167,7 +171,7 @@ def test_scanner_update_error():
|
||||
ctrl = mock.MagicMock()
|
||||
ctrl.get_clients.side_effect = APIError(
|
||||
'/', 500, 'foo', {}, None)
|
||||
unifi.UnifiScanner(ctrl, DEFAULT_DETECTION_TIME, None)
|
||||
unifi.UnifiScanner(ctrl, DEFAULT_DETECTION_TIME, None, None)
|
||||
|
||||
|
||||
def test_scan_devices():
|
||||
@@ -180,7 +184,7 @@ def test_scan_devices():
|
||||
'last_seen': dt_util.as_timestamp(dt_util.utcnow())},
|
||||
]
|
||||
ctrl.get_clients.return_value = fake_clients
|
||||
scanner = unifi.UnifiScanner(ctrl, DEFAULT_DETECTION_TIME, None)
|
||||
scanner = unifi.UnifiScanner(ctrl, DEFAULT_DETECTION_TIME, None, None)
|
||||
assert set(scanner.scan_devices()) == set(['123', '234'])
|
||||
|
||||
|
||||
@@ -200,7 +204,8 @@ def test_scan_devices_filtered():
|
||||
|
||||
ssid_filter = ['foonet', 'barnet']
|
||||
ctrl.get_clients.return_value = fake_clients
|
||||
scanner = unifi.UnifiScanner(ctrl, DEFAULT_DETECTION_TIME, ssid_filter)
|
||||
scanner = unifi.UnifiScanner(ctrl, DEFAULT_DETECTION_TIME, ssid_filter,
|
||||
None)
|
||||
assert set(scanner.scan_devices()) == set(['123', '234', '890'])
|
||||
|
||||
|
||||
@@ -221,8 +226,37 @@ def test_get_device_name():
|
||||
'last_seen': '1504786810'},
|
||||
]
|
||||
ctrl.get_clients.return_value = fake_clients
|
||||
scanner = unifi.UnifiScanner(ctrl, DEFAULT_DETECTION_TIME, None)
|
||||
scanner = unifi.UnifiScanner(ctrl, DEFAULT_DETECTION_TIME, None, None)
|
||||
assert scanner.get_device_name('123') == 'foobar'
|
||||
assert scanner.get_device_name('234') == 'Nice Name'
|
||||
assert scanner.get_device_name('456') is None
|
||||
assert scanner.get_device_name('unknown') is None
|
||||
|
||||
|
||||
def test_monitored_conditions():
|
||||
"""Test the filtering of attributes."""
|
||||
ctrl = mock.MagicMock()
|
||||
fake_clients = [
|
||||
{'mac': '123',
|
||||
'hostname': 'foobar',
|
||||
'essid': 'barnet',
|
||||
'signal': -60,
|
||||
'last_seen': dt_util.as_timestamp(dt_util.utcnow())},
|
||||
{'mac': '234',
|
||||
'name': 'Nice Name',
|
||||
'essid': 'barnet',
|
||||
'signal': -42,
|
||||
'last_seen': dt_util.as_timestamp(dt_util.utcnow())},
|
||||
{'mac': '456',
|
||||
'hostname': 'wired',
|
||||
'essid': 'barnet',
|
||||
'last_seen': dt_util.as_timestamp(dt_util.utcnow())},
|
||||
]
|
||||
ctrl.get_clients.return_value = fake_clients
|
||||
scanner = unifi.UnifiScanner(ctrl, DEFAULT_DETECTION_TIME, None,
|
||||
['essid', 'signal'])
|
||||
assert scanner.get_extra_attributes('123') == {'essid': 'barnet',
|
||||
'signal': -60}
|
||||
assert scanner.get_extra_attributes('234') == {'essid': 'barnet',
|
||||
'signal': -42}
|
||||
assert scanner.get_extra_attributes('456') == {'essid': 'barnet'}
|
||||
Reference in new issue
Block a user