Improve evohome exception handling and fix bugs (#22140)
* Use latest client library, evohomeclient v0.3.1 * Fix issue #22097: Failed to call service climate/turn_on... * BUGFIX: handle case where a Zone doesn't have a temperature * BUGFIX: missing exception handler, and inappropriate delint hints * Improve exception handling, and also better messages * improve code (REDACT secrets); remove TODOs * minor refactor - improve error message * more refactoring - improve error message * remove TODOs * update to latest evohomeclient library * Use latest client library, evohomeclient v0.3.1 * Fix issue #22097: Failed to call service climate/turn_on... * BUGFIX: handle case where a Zone doesn't have a temperature * BUGFIX: missing exception handler, and inappropriate delint hints * Improve exception handling, and also better messages * improve code (REDACT secrets); remove TODOs * minor refactor - improve error message * more refactoring - improve error message * remove TODOs * update to latest evohomeclient library * fix requests for houndci-bot * Tidy up requests exception handling * Correct lint error * update to latest client library * minor de-lint * more cleanup of exceptions, messages * refactored for new exception * fix error in requirements*_all.txt * de-lint * delint unused import * import 3rd-party library only inside methods * change honeywell tests * delint, fix typo * we dont log usernames, passwords, etc. * de-lint
This commit is contained in:
1 parent
16e0953f26
commit
3bd37d6a65
6 files changed
+107
-78
No files matched your search
@@ -1,9 +1,9 @@
|
||||
"""The test the Honeywell thermostat module."""
|
||||
import socket
|
||||
import unittest
|
||||
from unittest import mock
|
||||
|
||||
import voluptuous as vol
|
||||
import requests.exceptions
|
||||
import somecomfort
|
||||
|
||||
from homeassistant.const import (
|
||||
@@ -247,7 +247,8 @@ class TestHoneywell(unittest.TestCase):
|
||||
honeywell.CONF_AWAY_TEMPERATURE: 20,
|
||||
honeywell.CONF_REGION: 'eu',
|
||||
}
|
||||
mock_evo.return_value.temperatures.side_effect = socket.error
|
||||
mock_evo.return_value.temperatures.side_effect = \
|
||||
requests.exceptions.RequestException
|
||||
add_entities = mock.MagicMock()
|
||||
hass = mock.MagicMock()
|
||||
assert not honeywell.setup_platform(hass, config, add_entities)
|
||||
|
||||
Reference in new issue
Block a user