Removing calls to mock.assert_called_once_with (#3896)

If a mock's assert_called_once_with method is misspelled (e.g. asert_called_once_with) then the test will appear as passing.  Therefore, this commit removes all instances of assert_called_once_with calls and replaces them with two assertions:

        self.assertEqual(mock.call_count, 1)
        self.assertEqual(mock.call_args, mock.call(call_args))
This commit is contained in:
Rob Capellini authored and Paulus Schoutsen committed 2016-10-16 16:13:27 -07:00
1 parent 10c9132046
commit 4891ca1610
18 files changed
+308 -109

No files matched your search

+23 -7
View File
@@ -71,8 +71,13 @@ class TestMfiSensorSetup(unittest.TestCase):
config = dict(self.GOOD_CONFIG)
del config[self.THING]['port']
assert setup_component(self.hass, self.COMPONENT.DOMAIN, config)
mock_client.assert_called_once_with(
'foo', 'user', 'pass', port=6443, use_tls=True, verify=True)
self.assertEqual(mock_client.call_count, 1)
self.assertEqual(
mock_client.call_args,
mock.call(
'foo', 'user', 'pass', port=6443, use_tls=True, verify=True
)
)
@mock.patch('mficlient.client.MFiClient')
def test_setup_with_port(self, mock_client):
@@ -80,8 +85,13 @@ class TestMfiSensorSetup(unittest.TestCase):
config = dict(self.GOOD_CONFIG)
config[self.THING]['port'] = 6123
assert setup_component(self.hass, self.COMPONENT.DOMAIN, config)
mock_client.assert_called_once_with(
'foo', 'user', 'pass', port=6123, use_tls=True, verify=True)
self.assertEqual(mock_client.call_count, 1)
self.assertEqual(
mock_client.call_args,
mock.call(
'foo', 'user', 'pass', port=6123, use_tls=True, verify=True
)
)
@mock.patch('mficlient.client.MFiClient')
def test_setup_with_tls_disabled(self, mock_client):
@@ -91,8 +101,13 @@ class TestMfiSensorSetup(unittest.TestCase):
config[self.THING]['ssl'] = False
config[self.THING]['verify_ssl'] = False
assert setup_component(self.hass, self.COMPONENT.DOMAIN, config)
mock_client.assert_called_once_with(
'foo', 'user', 'pass', port=6080, use_tls=False, verify=False)
self.assertEqual(mock_client.call_count, 1)
self.assertEqual(
mock_client.call_args,
mock.call(
'foo', 'user', 'pass', port=6080, use_tls=False, verify=False
)
)
@mock.patch('mficlient.client.MFiClient')
@mock.patch('homeassistant.components.sensor.mfi.MfiSensor')
@@ -180,4 +195,5 @@ class TestMfiSensor(unittest.TestCase):
def test_update(self):
"""Test the update."""
self.sensor.update()
self.port.refresh.assert_called_once_with()
self.assertEqual(self.port.refresh.call_count, 1)
self.assertEqual(self.port.refresh.call_args, mock.call())