Removing calls to mock.assert_called_once_with (#3896)
If a mock's assert_called_once_with method is misspelled (e.g. asert_called_once_with) then the test will appear as passing. Therefore, this commit removes all instances of assert_called_once_with calls and replaces them with two assertions:
self.assertEqual(mock.call_count, 1)
self.assertEqual(mock.call_args, mock.call(call_args))
This commit is contained in:
1 parent
10c9132046
commit
4891ca1610
18 files changed
+308
-109
No files matched your search
@@ -40,10 +40,11 @@ class TestStatsd(unittest.TestCase):
|
||||
hass = mock.MagicMock()
|
||||
hass.pool.worker_count = 2
|
||||
self.assertTrue(setup_component(hass, statsd.DOMAIN, config))
|
||||
mock_connection.assert_called_once_with(
|
||||
host='host',
|
||||
port=123,
|
||||
prefix='foo')
|
||||
self.assertEqual(mock_connection.call_count, 1)
|
||||
self.assertEqual(
|
||||
mock_connection.call_args,
|
||||
mock.call(host='host', port=123, prefix='foo')
|
||||
)
|
||||
|
||||
self.assertTrue(hass.bus.listen.called)
|
||||
self.assertEqual(EVENT_STATE_CHANGED,
|
||||
@@ -64,10 +65,11 @@ class TestStatsd(unittest.TestCase):
|
||||
hass = mock.MagicMock()
|
||||
hass.pool.worker_count = 2
|
||||
self.assertTrue(setup_component(hass, statsd.DOMAIN, config))
|
||||
mock_connection.assert_called_once_with(
|
||||
host='host',
|
||||
port=8125,
|
||||
prefix='hass')
|
||||
self.assertEqual(mock_connection.call_count, 1)
|
||||
self.assertEqual(
|
||||
mock_connection.call_args,
|
||||
mock.call(host='host', port=8125, prefix='hass')
|
||||
)
|
||||
self.assertTrue(hass.bus.listen.called)
|
||||
|
||||
@mock.patch('statsd.StatsClient')
|
||||
@@ -101,8 +103,11 @@ class TestStatsd(unittest.TestCase):
|
||||
|
||||
mock_client.return_value.gauge.reset_mock()
|
||||
|
||||
mock_client.return_value.incr.assert_called_once_with(
|
||||
state.entity_id, rate=statsd.DEFAULT_RATE)
|
||||
self.assertEqual(mock_client.return_value.incr.call_count, 1)
|
||||
self.assertEqual(
|
||||
mock_client.return_value.incr.call_args,
|
||||
mock.call(state.entity_id, rate=statsd.DEFAULT_RATE)
|
||||
)
|
||||
mock_client.return_value.incr.reset_mock()
|
||||
|
||||
for invalid in ('foo', '', object):
|
||||
@@ -146,8 +151,11 @@ class TestStatsd(unittest.TestCase):
|
||||
|
||||
mock_client.return_value.gauge.reset_mock()
|
||||
|
||||
mock_client.return_value.incr.assert_called_once_with(
|
||||
state.entity_id, rate=statsd.DEFAULT_RATE)
|
||||
self.assertEqual(mock_client.return_value.incr.call_count, 1)
|
||||
self.assertEqual(
|
||||
mock_client.return_value.incr.call_args,
|
||||
mock.call(state.entity_id, rate=statsd.DEFAULT_RATE)
|
||||
)
|
||||
mock_client.return_value.incr.reset_mock()
|
||||
|
||||
for invalid in ('foo', '', object):
|
||||
|
||||
Reference in new issue
Block a user