Clean up Z-Wave pt2 (#20842)
This commit is contained in:
1 parent
5f76628665
commit
49bab574b9
8 files changed
+141
-145
No files matched your search
@@ -2,8 +2,7 @@
|
||||
from unittest.mock import patch, MagicMock
|
||||
|
||||
from homeassistant import config_entries
|
||||
import homeassistant.components.zwave.lock as zwave
|
||||
from homeassistant.components.zwave import const
|
||||
from homeassistant.components.zwave import const, lock
|
||||
|
||||
from tests.mock.zwave import (
|
||||
MockNode, MockValue, MockEntityValues, value_changed)
|
||||
@@ -19,8 +18,8 @@ def test_get_device_detects_lock(mock_openzwave):
|
||||
alarm_level=None,
|
||||
)
|
||||
|
||||
device = zwave.get_device(node=node, values=values, node_config={})
|
||||
assert isinstance(device, zwave.ZwaveLock)
|
||||
device = lock.get_device(node=node, values=values, node_config={})
|
||||
assert isinstance(device, lock.ZwaveLock)
|
||||
|
||||
|
||||
def test_lock_turn_on_and_off(mock_openzwave):
|
||||
@@ -32,7 +31,7 @@ def test_lock_turn_on_and_off(mock_openzwave):
|
||||
alarm_type=None,
|
||||
alarm_level=None,
|
||||
)
|
||||
device = zwave.get_device(node=node, values=values, node_config={})
|
||||
device = lock.get_device(node=node, values=values, node_config={})
|
||||
|
||||
assert not values.primary.data
|
||||
|
||||
@@ -52,7 +51,7 @@ def test_lock_value_changed(mock_openzwave):
|
||||
alarm_type=None,
|
||||
alarm_level=None,
|
||||
)
|
||||
device = zwave.get_device(node=node, values=values, node_config={})
|
||||
device = lock.get_device(node=node, values=values, node_config={})
|
||||
|
||||
assert not device.is_locked
|
||||
|
||||
@@ -71,7 +70,7 @@ def test_lock_state_workaround(mock_openzwave):
|
||||
alarm_type=None,
|
||||
alarm_level=None,
|
||||
)
|
||||
device = zwave.get_device(node=node, values=values)
|
||||
device = lock.get_device(node=node, values=values)
|
||||
assert device.is_locked
|
||||
values.access_control.data = 2
|
||||
value_changed(values.access_control)
|
||||
@@ -89,15 +88,15 @@ def test_track_message_workaround(mock_openzwave):
|
||||
alarm_level=None,
|
||||
)
|
||||
|
||||
# Here we simulate an RF lock. The first zwave.get_device will call
|
||||
# Here we simulate an RF lock. The first lock.get_device will call
|
||||
# update properties, simulating the first DoorLock report. We then trigger
|
||||
# a change, simulating the openzwave automatic refreshing behavior (which
|
||||
# is enabled for at least the lock that needs this workaround)
|
||||
node.stats['lastReceivedMessage'][5] = const.COMMAND_CLASS_DOOR_LOCK
|
||||
device = zwave.get_device(node=node, values=values)
|
||||
device = lock.get_device(node=node, values=values)
|
||||
value_changed(values.primary)
|
||||
assert device.is_locked
|
||||
assert device.device_state_attributes[zwave.ATTR_NOTIFICATION] == 'RF Lock'
|
||||
assert device.device_state_attributes[lock.ATTR_NOTIFICATION] == 'RF Lock'
|
||||
|
||||
# Simulate a keypad unlock. We trigger a value_changed() which simulates
|
||||
# the Alarm notification received from the lock. Then, we trigger
|
||||
@@ -111,7 +110,7 @@ def test_track_message_workaround(mock_openzwave):
|
||||
values.primary.data = False
|
||||
value_changed(values.primary)
|
||||
assert not device.is_locked
|
||||
assert device.device_state_attributes[zwave.ATTR_LOCK_STATUS] == \
|
||||
assert device.device_state_attributes[lock.ATTR_LOCK_STATUS] == \
|
||||
'Unlocked with Keypad by user 3'
|
||||
|
||||
# Again, simulate an RF lock.
|
||||
@@ -119,7 +118,7 @@ def test_track_message_workaround(mock_openzwave):
|
||||
node.stats['lastReceivedMessage'][5] = const.COMMAND_CLASS_DOOR_LOCK
|
||||
value_changed(values.primary)
|
||||
assert device.is_locked
|
||||
assert device.device_state_attributes[zwave.ATTR_NOTIFICATION] == 'RF Lock'
|
||||
assert device.device_state_attributes[lock.ATTR_NOTIFICATION] == 'RF Lock'
|
||||
|
||||
|
||||
def test_v2btze_value_changed(mock_openzwave):
|
||||
@@ -132,7 +131,7 @@ def test_v2btze_value_changed(mock_openzwave):
|
||||
alarm_type=None,
|
||||
alarm_level=None,
|
||||
)
|
||||
device = zwave.get_device(node=node, values=values, node_config={})
|
||||
device = lock.get_device(node=node, values=values, node_config={})
|
||||
assert device._v2btze
|
||||
|
||||
assert not device.is_locked
|
||||
@@ -152,7 +151,7 @@ def test_alarm_type_workaround(mock_openzwave):
|
||||
alarm_type=MockValue(data=16, node=node),
|
||||
alarm_level=None,
|
||||
)
|
||||
device = zwave.get_device(node=node, values=values)
|
||||
device = lock.get_device(node=node, values=values)
|
||||
assert not device.is_locked
|
||||
|
||||
values.alarm_type.data = 18
|
||||
@@ -193,9 +192,9 @@ def test_lock_access_control(mock_openzwave):
|
||||
alarm_type=None,
|
||||
alarm_level=None,
|
||||
)
|
||||
device = zwave.get_device(node=node, values=values, node_config={})
|
||||
device = lock.get_device(node=node, values=values, node_config={})
|
||||
|
||||
assert device.device_state_attributes[zwave.ATTR_NOTIFICATION] == \
|
||||
assert device.device_state_attributes[lock.ATTR_NOTIFICATION] == \
|
||||
'Lock Jammed'
|
||||
|
||||
|
||||
@@ -208,28 +207,28 @@ def test_lock_alarm_type(mock_openzwave):
|
||||
alarm_type=MockValue(data=None, node=node),
|
||||
alarm_level=None,
|
||||
)
|
||||
device = zwave.get_device(node=node, values=values, node_config={})
|
||||
device = lock.get_device(node=node, values=values, node_config={})
|
||||
|
||||
assert zwave.ATTR_LOCK_STATUS not in device.device_state_attributes
|
||||
assert lock.ATTR_LOCK_STATUS not in device.device_state_attributes
|
||||
|
||||
values.alarm_type.data = 21
|
||||
value_changed(values.alarm_type)
|
||||
assert device.device_state_attributes[zwave.ATTR_LOCK_STATUS] == \
|
||||
assert device.device_state_attributes[lock.ATTR_LOCK_STATUS] == \
|
||||
'Manually Locked None'
|
||||
|
||||
values.alarm_type.data = 18
|
||||
value_changed(values.alarm_type)
|
||||
assert device.device_state_attributes[zwave.ATTR_LOCK_STATUS] == \
|
||||
assert device.device_state_attributes[lock.ATTR_LOCK_STATUS] == \
|
||||
'Locked with Keypad by user None'
|
||||
|
||||
values.alarm_type.data = 161
|
||||
value_changed(values.alarm_type)
|
||||
assert device.device_state_attributes[zwave.ATTR_LOCK_STATUS] == \
|
||||
assert device.device_state_attributes[lock.ATTR_LOCK_STATUS] == \
|
||||
'Tamper Alarm: None'
|
||||
|
||||
values.alarm_type.data = 9
|
||||
value_changed(values.alarm_type)
|
||||
assert device.device_state_attributes[zwave.ATTR_LOCK_STATUS] == \
|
||||
assert device.device_state_attributes[lock.ATTR_LOCK_STATUS] == \
|
||||
'Deadbolt Jammed'
|
||||
|
||||
|
||||
@@ -242,29 +241,29 @@ def test_lock_alarm_level(mock_openzwave):
|
||||
alarm_type=MockValue(data=None, node=node),
|
||||
alarm_level=MockValue(data=None, node=node),
|
||||
)
|
||||
device = zwave.get_device(node=node, values=values, node_config={})
|
||||
device = lock.get_device(node=node, values=values, node_config={})
|
||||
|
||||
assert zwave.ATTR_LOCK_STATUS not in device.device_state_attributes
|
||||
assert lock.ATTR_LOCK_STATUS not in device.device_state_attributes
|
||||
|
||||
values.alarm_type.data = 21
|
||||
values.alarm_level.data = 1
|
||||
value_changed(values.alarm_type)
|
||||
value_changed(values.alarm_level)
|
||||
assert device.device_state_attributes[zwave.ATTR_LOCK_STATUS] == \
|
||||
assert device.device_state_attributes[lock.ATTR_LOCK_STATUS] == \
|
||||
'Manually Locked by Key Cylinder or Inside thumb turn'
|
||||
|
||||
values.alarm_type.data = 18
|
||||
values.alarm_level.data = 'alice'
|
||||
value_changed(values.alarm_type)
|
||||
value_changed(values.alarm_level)
|
||||
assert device.device_state_attributes[zwave.ATTR_LOCK_STATUS] == \
|
||||
assert device.device_state_attributes[lock.ATTR_LOCK_STATUS] == \
|
||||
'Locked with Keypad by user alice'
|
||||
|
||||
values.alarm_type.data = 161
|
||||
values.alarm_level.data = 1
|
||||
value_changed(values.alarm_type)
|
||||
value_changed(values.alarm_level)
|
||||
assert device.device_state_attributes[zwave.ATTR_LOCK_STATUS] == \
|
||||
assert device.device_state_attributes[lock.ATTR_LOCK_STATUS] == \
|
||||
'Tamper Alarm: Too many keypresses'
|
||||
|
||||
|
||||
@@ -282,7 +281,7 @@ async def setup_ozw(hass, mock_openzwave):
|
||||
|
||||
async def test_lock_set_usercode_service(hass, mock_openzwave):
|
||||
"""Test the zwave lock set_usercode service."""
|
||||
mock_network = hass.data[zwave.zwave.DATA_NETWORK] = MagicMock()
|
||||
mock_network = hass.data[const.DATA_NETWORK] = MagicMock()
|
||||
|
||||
node = MockNode(node_id=12)
|
||||
value0 = MockValue(data=' ', node=node, index=0)
|
||||
@@ -301,10 +300,10 @@ async def test_lock_set_usercode_service(hass, mock_openzwave):
|
||||
await hass.async_block_till_done()
|
||||
|
||||
await hass.services.async_call(
|
||||
zwave.DOMAIN, zwave.SERVICE_SET_USERCODE, {
|
||||
lock.DOMAIN, lock.SERVICE_SET_USERCODE, {
|
||||
const.ATTR_NODE_ID: node.node_id,
|
||||
zwave.ATTR_USERCODE: '1234',
|
||||
zwave.ATTR_CODE_SLOT: 1,
|
||||
lock.ATTR_USERCODE: '1234',
|
||||
lock.ATTR_CODE_SLOT: 1,
|
||||
})
|
||||
await hass.async_block_till_done()
|
||||
|
||||
@@ -314,10 +313,10 @@ async def test_lock_set_usercode_service(hass, mock_openzwave):
|
||||
node.node_id: node
|
||||
}
|
||||
await hass.services.async_call(
|
||||
zwave.DOMAIN, zwave.SERVICE_SET_USERCODE, {
|
||||
lock.DOMAIN, lock.SERVICE_SET_USERCODE, {
|
||||
const.ATTR_NODE_ID: node.node_id,
|
||||
zwave.ATTR_USERCODE: '123',
|
||||
zwave.ATTR_CODE_SLOT: 1,
|
||||
lock.ATTR_USERCODE: '123',
|
||||
lock.ATTR_CODE_SLOT: 1,
|
||||
})
|
||||
await hass.async_block_till_done()
|
||||
|
||||
@@ -326,7 +325,7 @@ async def test_lock_set_usercode_service(hass, mock_openzwave):
|
||||
|
||||
async def test_lock_get_usercode_service(hass, mock_openzwave):
|
||||
"""Test the zwave lock get_usercode service."""
|
||||
mock_network = hass.data[zwave.zwave.DATA_NETWORK] = MagicMock()
|
||||
mock_network = hass.data[const.DATA_NETWORK] = MagicMock()
|
||||
node = MockNode(node_id=12)
|
||||
value0 = MockValue(data=None, node=node, index=0)
|
||||
value1 = MockValue(data='1234', node=node, index=1)
|
||||
@@ -339,12 +338,12 @@ async def test_lock_get_usercode_service(hass, mock_openzwave):
|
||||
await setup_ozw(hass, mock_openzwave)
|
||||
await hass.async_block_till_done()
|
||||
|
||||
with patch.object(zwave, '_LOGGER') as mock_logger:
|
||||
with patch.object(lock, '_LOGGER') as mock_logger:
|
||||
mock_network.nodes = {node.node_id: node}
|
||||
await hass.services.async_call(
|
||||
zwave.DOMAIN, zwave.SERVICE_GET_USERCODE, {
|
||||
lock.DOMAIN, lock.SERVICE_GET_USERCODE, {
|
||||
const.ATTR_NODE_ID: node.node_id,
|
||||
zwave.ATTR_CODE_SLOT: 1,
|
||||
lock.ATTR_CODE_SLOT: 1,
|
||||
})
|
||||
await hass.async_block_till_done()
|
||||
# This service only seems to write to the log
|
||||
@@ -355,7 +354,7 @@ async def test_lock_get_usercode_service(hass, mock_openzwave):
|
||||
|
||||
async def test_lock_clear_usercode_service(hass, mock_openzwave):
|
||||
"""Test the zwave lock clear_usercode service."""
|
||||
mock_network = hass.data[zwave.zwave.DATA_NETWORK] = MagicMock()
|
||||
mock_network = hass.data[const.DATA_NETWORK] = MagicMock()
|
||||
node = MockNode(node_id=12)
|
||||
value0 = MockValue(data=None, node=node, index=0)
|
||||
value1 = MockValue(data='123', node=node, index=1)
|
||||
@@ -373,9 +372,9 @@ async def test_lock_clear_usercode_service(hass, mock_openzwave):
|
||||
await hass.async_block_till_done()
|
||||
|
||||
await hass.services.async_call(
|
||||
zwave.DOMAIN, zwave.SERVICE_CLEAR_USERCODE, {
|
||||
lock.DOMAIN, lock.SERVICE_CLEAR_USERCODE, {
|
||||
const.ATTR_NODE_ID: node.node_id,
|
||||
zwave.ATTR_CODE_SLOT: 1
|
||||
lock.ATTR_CODE_SLOT: 1
|
||||
})
|
||||
await hass.async_block_till_done()
|
||||
|
||||
|
||||
Reference in new issue
Block a user