Replace asyncio.wait with asyncio.gather since wait ignores exceptions (#33380)

* replace asyncio.wait with asyncio.gather since wait ignores exceptions
fix for test_entity_platform so it expects the exception

* changed to log on failed domains

* discovered that this fix actually removes other uncaught exceptions

* fix in the list of ignored exceptions

* replaced a few ignores on dyson tests that work locally but fail in the CI

* two more tests that are failing on the CI and not locally

* removed assertion on multiple entries with same unique_id - replaced with log and return
reverted test_entity_platform to its original since now there is no exception thrown

* entered all the dyson tests. they all pass locally and probabilistically fail in the CI

* removed unnecessary str() for exception

* added log message for duplicate entity_id / unique_id

* removed log in case of False return value

* added exc_info

* change the use of exc_info
This commit is contained in:
Ziv authored and GitHub committed 2020-04-01 07:09:13 -07:00
1 parent 3d73f166be
commit 4dbbf93af9
5 files changed
+32 -54

No files matched your search

+7 -6
View File
@@ -183,7 +183,7 @@ class EntityPlatform:
self._tasks.clear()
if pending:
await asyncio.wait(pending)
await asyncio.gather(*pending)
hass.config.components.add(full_name)
return True
@@ -292,7 +292,7 @@ class EntityPlatform:
if not tasks:
return
await asyncio.wait(tasks)
await asyncio.gather(*tasks)
if self._async_unsub_polling is not None or not any(
entity.should_poll for entity in self.entities.values()
@@ -431,10 +431,11 @@ class EntityPlatform:
already_exists = True
if already_exists:
msg = f"Entity id already exists: {entity.entity_id}"
msg = f"Entity id already exists - ignoring: {entity.entity_id}"
if entity.unique_id is not None:
msg += f". Platform {self.platform_name} does not generate unique IDs"
raise HomeAssistantError(msg)
self.logger.error(msg)
return
entity_id = entity.entity_id
self.entities[entity_id] = entity
@@ -459,7 +460,7 @@ class EntityPlatform:
tasks = [self.async_remove_entity(entity_id) for entity_id in self.entities]
await asyncio.wait(tasks)
await asyncio.gather(*tasks)
if self._async_unsub_polling is not None:
self._async_unsub_polling()
@@ -548,7 +549,7 @@ class EntityPlatform:
tasks.append(entity.async_update_ha_state(True)) # type: ignore
if tasks:
await asyncio.wait(tasks)
await asyncio.gather(*tasks)
current_platform: ContextVar[Optional[EntityPlatform]] = ContextVar(