Improve MQTT test coverage and remove dead code (#33584)

* Improve MQTT tests and remove dead code

* Remove useless test.

* Add more test
This commit is contained in:
Erik Montnemery authored and GitHub committed 2020-04-03 09:05:58 -07:00
1 parent a813847f6e
commit 4e6fd19624
12 files changed
+761 -125

No files matched your search

+12 -12
View File
@@ -51,32 +51,32 @@ async def test_subscribing_config_topic(hass, mqtt_mock):
async def test_invalid_topic(hass, mqtt_mock):
"""Test sending to invalid topic."""
with patch(
"homeassistant.components.mqtt.discovery.async_load_platform"
) as mock_load_platform:
"homeassistant.components.mqtt.discovery.async_dispatcher_send"
) as mock_dispatcher_send:
entry = MockConfigEntry(
domain=mqtt.DOMAIN, data={mqtt.CONF_BROKER: "test-broker"}
)
mock_load_platform.return_value = mock_coro()
mock_dispatcher_send.return_value = mock_coro()
await async_start(hass, "homeassistant", {}, entry)
async_fire_mqtt_message(
hass, "homeassistant/binary_sensor/bla/not_config", "{}"
)
await hass.async_block_till_done()
assert not mock_load_platform.called
assert not mock_dispatcher_send.called
async def test_invalid_json(hass, mqtt_mock, caplog):
"""Test sending in invalid JSON."""
with patch(
"homeassistant.components.mqtt.discovery.async_load_platform"
) as mock_load_platform:
"homeassistant.components.mqtt.discovery.async_dispatcher_send"
) as mock_dispatcher_send:
entry = MockConfigEntry(
domain=mqtt.DOMAIN, data={mqtt.CONF_BROKER: "test-broker"}
)
mock_load_platform.return_value = mock_coro()
mock_dispatcher_send.return_value = mock_coro()
await async_start(hass, "homeassistant", {}, entry)
async_fire_mqtt_message(
@@ -84,19 +84,19 @@ async def test_invalid_json(hass, mqtt_mock, caplog):
)
await hass.async_block_till_done()
assert "Unable to parse JSON" in caplog.text
assert not mock_load_platform.called
assert not mock_dispatcher_send.called
async def test_only_valid_components(hass, mqtt_mock, caplog):
"""Test for a valid component."""
with patch(
"homeassistant.components.mqtt.discovery.async_load_platform"
) as mock_load_platform:
"homeassistant.components.mqtt.discovery.async_dispatcher_send"
) as mock_dispatcher_send:
entry = MockConfigEntry(domain=mqtt.DOMAIN)
invalid_component = "timer"
mock_load_platform.return_value = mock_coro()
mock_dispatcher_send.return_value = mock_coro()
await async_start(hass, "homeassistant", {}, entry)
async_fire_mqtt_message(
@@ -107,7 +107,7 @@ async def test_only_valid_components(hass, mqtt_mock, caplog):
assert "Integration {} is not supported".format(invalid_component) in caplog.text
assert not mock_load_platform.called
assert not mock_dispatcher_send.called
async def test_correct_config_discovery(hass, mqtt_mock, caplog):