Add missing Short type to set_config_param (#38618)
* Add missing Short type to set_config_param * Forgot to fix the for loop * Remove leftover return * Guard the for loop * Changed from if to else * Fixed list iteration for validating input * Adjusted per linter
This commit is contained in:
1 parent
ef039d6a65
commit
597d1e2799
2 files changed
+84
-73
No files matched your search
@@ -2,61 +2,61 @@
|
||||
from .common import setup_ozw
|
||||
|
||||
|
||||
async def test_services(hass, lock_data, sent_messages, lock_msg, caplog):
|
||||
async def test_services(hass, light_data, sent_messages, light_msg, caplog):
|
||||
"""Test services on lock."""
|
||||
await setup_ozw(hass, fixture=lock_data)
|
||||
await setup_ozw(hass, fixture=light_data)
|
||||
|
||||
# Test set_config_parameter list by label
|
||||
await hass.services.async_call(
|
||||
"ozw",
|
||||
"set_config_parameter",
|
||||
{"node_id": 10, "parameter": 1, "value": "Disabled"},
|
||||
{"node_id": 39, "parameter": 1, "value": "Disable"},
|
||||
blocking=True,
|
||||
)
|
||||
assert len(sent_messages) == 1
|
||||
msg = sent_messages[0]
|
||||
assert msg["topic"] == "OpenZWave/1/command/setvalue/"
|
||||
assert msg["payload"] == {"Value": 0, "ValueIDKey": 281475154706452}
|
||||
assert msg["payload"] == {"Value": 0, "ValueIDKey": 281475641245716}
|
||||
|
||||
# Test set_config_parameter list by index int
|
||||
await hass.services.async_call(
|
||||
"ozw",
|
||||
"set_config_parameter",
|
||||
{"node_id": 10, "parameter": 1, "value": 0},
|
||||
{"node_id": 39, "parameter": 1, "value": 1},
|
||||
blocking=True,
|
||||
)
|
||||
assert len(sent_messages) == 2
|
||||
msg = sent_messages[1]
|
||||
assert msg["topic"] == "OpenZWave/1/command/setvalue/"
|
||||
assert msg["payload"] == {"Value": 0, "ValueIDKey": 281475154706452}
|
||||
assert msg["payload"] == {"Value": 1, "ValueIDKey": 281475641245716}
|
||||
|
||||
# Test set_config_parameter int
|
||||
await hass.services.async_call(
|
||||
"ozw",
|
||||
"set_config_parameter",
|
||||
{"node_id": 10, "parameter": 6, "value": 0},
|
||||
{"node_id": 39, "parameter": 3, "value": 55},
|
||||
blocking=True,
|
||||
)
|
||||
assert len(sent_messages) == 3
|
||||
msg = sent_messages[2]
|
||||
assert msg["topic"] == "OpenZWave/1/command/setvalue/"
|
||||
assert msg["payload"] == {"Value": 0, "ValueIDKey": 1688850038259731}
|
||||
assert msg["payload"] == {"Value": 55, "ValueIDKey": 844425594667027}
|
||||
|
||||
# Test set_config_parameter invalid list int
|
||||
await hass.services.async_call(
|
||||
"ozw",
|
||||
"set_config_parameter",
|
||||
{"node_id": 10, "parameter": 1, "value": 12},
|
||||
{"node_id": 39, "parameter": 1, "value": 12},
|
||||
blocking=True,
|
||||
)
|
||||
assert len(sent_messages) == 3
|
||||
assert "Value 12 out of range for parameter 1" in caplog.text
|
||||
assert "Invalid value 12 for parameter 1" in caplog.text
|
||||
|
||||
# Test set_config_parameter invalid list string
|
||||
await hass.services.async_call(
|
||||
"ozw",
|
||||
"set_config_parameter",
|
||||
{"node_id": 10, "parameter": 1, "value": "Blah"},
|
||||
{"node_id": 39, "parameter": 1, "value": "Blah"},
|
||||
blocking=True,
|
||||
)
|
||||
assert len(sent_messages) == 3
|
||||
@@ -66,8 +66,32 @@ async def test_services(hass, lock_data, sent_messages, lock_msg, caplog):
|
||||
await hass.services.async_call(
|
||||
"ozw",
|
||||
"set_config_parameter",
|
||||
{"node_id": 10, "parameter": 6, "value": 2147483657},
|
||||
{"node_id": 39, "parameter": 3, "value": 2147483657},
|
||||
blocking=True,
|
||||
)
|
||||
assert len(sent_messages) == 3
|
||||
assert "Value 12 out of range for parameter 1" in caplog.text
|
||||
assert "Value 2147483657 out of range for parameter 3" in caplog.text
|
||||
|
||||
# Test set_config_parameter short
|
||||
await hass.services.async_call(
|
||||
"ozw",
|
||||
"set_config_parameter",
|
||||
{"node_id": 39, "parameter": 81, "value": 3000},
|
||||
blocking=True,
|
||||
)
|
||||
assert len(sent_messages) == 4
|
||||
msg = sent_messages[3]
|
||||
assert msg["topic"] == "OpenZWave/1/command/setvalue/"
|
||||
assert msg["payload"] == {"Value": 3000, "ValueIDKey": 22799473778098198}
|
||||
|
||||
# Test set_config_parameter byte
|
||||
await hass.services.async_call(
|
||||
"ozw",
|
||||
"set_config_parameter",
|
||||
{"node_id": 39, "parameter": 16, "value": 20},
|
||||
blocking=True,
|
||||
)
|
||||
assert len(sent_messages) == 5
|
||||
msg = sent_messages[4]
|
||||
assert msg["topic"] == "OpenZWave/1/command/setvalue/"
|
||||
assert msg["payload"] == {"Value": 20, "ValueIDKey": 4503600291905553}
|
||||
Reference in new issue
Block a user