Add device triggers to support setting turn_on event (#35456)

* Add device triggers to support setting turn_on event

* Add turn on event

* Add unique_id based on config entry

* Adjust tests for addition of uuid

* Supported features are now always same

* Switch to player_setup fixture that actually start platform

* Update homeassistant/components/arcam_fmj/const.py

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
This commit is contained in:
Joakim PlateandMartin Hjelmare authored and GitHub committed 2020-05-14 23:24:19 +02:00
1 parent 37cabe5562
commit 5c0d237c2d
8 files changed
+241 -38

No files matched your search

+45 -5
View File
@@ -7,8 +7,9 @@ from homeassistant.components.arcam_fmj import DEVICE_SCHEMA
from homeassistant.components.arcam_fmj.const import DOMAIN
from homeassistant.components.arcam_fmj.media_player import ArcamFmj
from homeassistant.const import CONF_HOST, CONF_PORT
from homeassistant.setup import async_setup_component
from tests.async_mock import Mock
from tests.async_mock import Mock, patch
MOCK_HOST = "127.0.0.1"
MOCK_PORT = 1234
@@ -17,7 +18,8 @@ MOCK_TURN_ON = {
"data": {"entity_id": "switch.test"},
}
MOCK_NAME = "dummy"
MOCK_ENTITY_ID = "media_player.arcam_fmj_1"
MOCK_UUID = "1234"
MOCK_ENTITY_ID = "media_player.arcam_fmj_127_0_0_1_1234_1"
MOCK_CONFIG = DEVICE_SCHEMA({CONF_HOST: MOCK_HOST, CONF_PORT: MOCK_PORT})
@@ -36,8 +38,8 @@ def client_fixture():
return client
@pytest.fixture(name="state")
def state_fixture(client):
@pytest.fixture(name="state_1")
def state_1_fixture(client):
"""Get a mocked state."""
state = Mock(State)
state.client = client
@@ -50,11 +52,49 @@ def state_fixture(client):
return state
@pytest.fixture(name="state_2")
def state_2_fixture(client):
"""Get a mocked state."""
state = Mock(State)
state.client = client
state.zn = 2
state.get_power.return_value = True
state.get_volume.return_value = 0.0
state.get_source_list.return_value = []
state.get_incoming_audio_format.return_value = (0, 0)
state.get_mute.return_value = None
return state
@pytest.fixture(name="state")
def state_fixture(state_1):
"""Get a mocked state."""
return state_1
@pytest.fixture(name="player")
def player_fixture(hass, state):
"""Get standard player."""
player = ArcamFmj(state, MOCK_NAME, None)
player = ArcamFmj(state, MOCK_UUID, MOCK_NAME, None)
player.entity_id = MOCK_ENTITY_ID
player.hass = hass
player.async_write_ha_state = Mock()
return player
@pytest.fixture(name="player_setup")
async def player_setup_fixture(hass, config, state_1, state_2, client):
"""Get standard player."""
def state_mock(cli, zone):
if zone == 1:
return state_1
if zone == 2:
return state_2
with patch("homeassistant.components.arcam_fmj.Client", return_value=client), patch(
"homeassistant.components.arcam_fmj.media_player.State", side_effect=state_mock
), patch("homeassistant.components.arcam_fmj._run_client", return_value=None):
assert await async_setup_component(hass, "arcam_fmj", config)
await hass.async_block_till_done()
yield MOCK_ENTITY_ID
@@ -0,0 +1,91 @@
"""The tests for Arcam FMJ Receiver control device triggers."""
import pytest
from homeassistant.components.arcam_fmj.const import DOMAIN
import homeassistant.components.automation as automation
from homeassistant.setup import async_setup_component
from tests.common import (
MockConfigEntry,
assert_lists_same,
async_get_device_automations,
async_mock_service,
mock_device_registry,
mock_registry,
)
@pytest.fixture
def device_reg(hass):
"""Return an empty, loaded, registry."""
return mock_device_registry(hass)
@pytest.fixture
def entity_reg(hass):
"""Return an empty, loaded, registry."""
return mock_registry(hass)
@pytest.fixture
def calls(hass):
"""Track calls to a mock service."""
return async_mock_service(hass, "test", "automation")
async def test_get_triggers(hass, device_reg, entity_reg):
"""Test we get the expected triggers from a arcam_fmj."""
config_entry = MockConfigEntry(domain=DOMAIN, data={})
config_entry.add_to_hass(hass)
device_entry = device_reg.async_get_or_create(
config_entry_id=config_entry.entry_id, identifiers={(DOMAIN, "host", 1234)},
)
entity_reg.async_get_or_create(
"media_player", DOMAIN, "5678", device_id=device_entry.id
)
expected_triggers = [
{
"platform": "device",
"domain": DOMAIN,
"type": "turn_on",
"device_id": device_entry.id,
"entity_id": f"media_player.arcam_fmj_5678",
},
]
triggers = await async_get_device_automations(hass, "trigger", device_entry.id)
assert_lists_same(triggers, expected_triggers)
async def test_if_fires_on_turn_on_request(hass, calls, player_setup, state):
"""Test for turn_on and turn_off triggers firing."""
state.get_power.return_value = None
assert await async_setup_component(
hass,
automation.DOMAIN,
{
automation.DOMAIN: [
{
"trigger": {
"platform": "device",
"domain": DOMAIN,
"device_id": "",
"entity_id": player_setup,
"type": "turn_on",
},
"action": {
"service": "test.automation",
"data_template": {"some": "{{ trigger.entity_id }}"},
},
}
]
},
)
await hass.services.async_call(
"media_player", "turn_on", {"entity_id": player_setup}, blocking=True,
)
await hass.async_block_till_done()
assert len(calls) == 1
assert calls[0].data["some"] == player_setup
@@ -7,7 +7,7 @@ import pytest
from homeassistant.components.media_player.const import MEDIA_TYPE_MUSIC
from homeassistant.core import HomeAssistant
from .conftest import MOCK_ENTITY_ID, MOCK_HOST, MOCK_NAME, MOCK_PORT
from .conftest import MOCK_ENTITY_ID, MOCK_HOST, MOCK_NAME, MOCK_PORT, MOCK_UUID
from tests.async_mock import ANY, MagicMock, Mock, PropertyMock, patch
@@ -25,7 +25,7 @@ async def update(player, force_refresh=False):
async def test_properties(player, state):
"""Test standard properties."""
assert player.unique_id is None
assert player.unique_id == f"{MOCK_UUID}-1"
assert player.device_info == {
"identifiers": {("arcam_fmj", MOCK_HOST, MOCK_PORT)},
"model": "FMJ",
@@ -54,30 +54,8 @@ async def test_powered_on(player, state):
assert data.state == "on"
async def test_supported_features_no_service(player, state):
async def test_supported_features(player, state):
"""Test support when turn on service exist."""
state.get_power.return_value = None
data = await update(player)
assert data.attributes["supported_features"] == 68876
state.get_power.return_value = False
data = await update(player)
assert data.attributes["supported_features"] == 69004
async def test_supported_features_service(hass, state):
"""Test support when turn on service exist."""
from homeassistant.components.arcam_fmj.media_player import ArcamFmj
player = ArcamFmj(state, "dummy", MOCK_TURN_ON)
player.hass = hass
player.entity_id = MOCK_ENTITY_ID
state.get_power.return_value = None
data = await update(player)
assert data.attributes["supported_features"] == 69004
state.get_power.return_value = False
data = await update(player)
assert data.attributes["supported_features"] == 69004
@@ -97,7 +75,7 @@ async def test_turn_on_with_service(hass, state):
"""Test support when turn on service exist."""
from homeassistant.components.arcam_fmj.media_player import ArcamFmj
player = ArcamFmj(state, "dummy", MOCK_TURN_ON)
player = ArcamFmj(state, MOCK_UUID, "dummy", MOCK_TURN_ON)
player.hass = Mock(HomeAssistant)
player.entity_id = MOCK_ENTITY_ID
with patch(