Make sure use_x_forward_for and trusted_proxies must config together (#15804)
* Make sure use_x_forward_for and trusted_proxies must config together * Fix unit test
This commit is contained in:
1 parent
ee180c51cf
commit
6f2000f5e2
3 files changed
+33
-7
No files matched your search
@@ -96,3 +96,31 @@ async def test_not_log_password(hass, aiohttp_client, caplog):
|
||||
# Ensure we don't log API passwords
|
||||
assert '/api/' in logs
|
||||
assert 'some-pass' not in logs
|
||||
|
||||
|
||||
async def test_proxy_config(hass):
|
||||
"""Test use_x_forwarded_for must config together with trusted_proxies."""
|
||||
assert await async_setup_component(hass, 'http', {
|
||||
'http': {
|
||||
http.CONF_USE_X_FORWARDED_FOR: True,
|
||||
http.CONF_TRUSTED_PROXIES: ['127.0.0.1']
|
||||
}
|
||||
}) is True
|
||||
|
||||
|
||||
async def test_proxy_config_only_use_xff(hass):
|
||||
"""Test use_x_forwarded_for must config together with trusted_proxies."""
|
||||
assert await async_setup_component(hass, 'http', {
|
||||
'http': {
|
||||
http.CONF_USE_X_FORWARDED_FOR: True
|
||||
}
|
||||
}) is not True
|
||||
|
||||
|
||||
async def test_proxy_config_only_trust_proxies(hass):
|
||||
"""Test use_x_forwarded_for must config together with trusted_proxies."""
|
||||
assert await async_setup_component(hass, 'http', {
|
||||
'http': {
|
||||
http.CONF_TRUSTED_PROXIES: ['127.0.0.1']
|
||||
}
|
||||
}) is not True
|
||||
@@ -159,9 +159,7 @@ class TestCheckConfig(unittest.TestCase):
|
||||
'login_attempts_threshold': -1,
|
||||
'server_host': '0.0.0.0',
|
||||
'server_port': 8123,
|
||||
'trusted_networks': [],
|
||||
'trusted_proxies': [],
|
||||
'use_x_forwarded_for': False}
|
||||
'trusted_networks': []}
|
||||
assert res['secret_cache'] == {secrets_path: {'http_pw': 'abc123'}}
|
||||
assert res['secrets'] == {'http_pw': 'abc123'}
|
||||
assert normalize_yaml_files(res) == [
|
||||
|
||||
Reference in new issue
Block a user