Switch homekit to use async_track_state_change_event (#37253)
* Switch homekit to use async_track_state_change_event Calling async_track_state_change_event directly is faster than async_track_state_change and has slightly lower latency triggering state updates in homekit * check for deleted entities * Update additional tests for linked sensor removals * Ensure removing entities does not result in an exception
This commit is contained in:
1 parent
9b77e16ffc
commit
711b8e10a3
2 files changed
+85
-24
No files matched your search
@@ -207,6 +207,7 @@ async def test_battery_service(hass, hk_driver, caplog):
|
||||
await hass.async_block_till_done()
|
||||
state = hass.states.get(entity_id)
|
||||
mock_async_update_state.assert_called_with(state)
|
||||
|
||||
assert acc._char_battery.value == 15
|
||||
assert acc._char_low_battery.value == 1
|
||||
assert acc._char_charging.value == 2
|
||||
@@ -218,6 +219,7 @@ async def test_battery_service(hass, hk_driver, caplog):
|
||||
await hass.async_block_till_done()
|
||||
state = hass.states.get(entity_id)
|
||||
mock_async_update_state.assert_called_with(state)
|
||||
|
||||
assert acc._char_battery.value == 15
|
||||
assert acc._char_low_battery.value == 1
|
||||
assert acc._char_charging.value == 2
|
||||
@@ -341,7 +343,12 @@ async def test_linked_battery_sensor(hass, hk_driver, caplog):
|
||||
|
||||
hass.states.async_set(linked_battery, 100, {ATTR_BATTERY_CHARGING: False})
|
||||
await hass.async_block_till_done()
|
||||
state = hass.states.get(entity_id)
|
||||
assert acc._char_battery.value == 100
|
||||
assert acc._char_low_battery.value == 0
|
||||
assert acc._char_charging.value == 0
|
||||
|
||||
hass.states.async_remove(linked_battery)
|
||||
await hass.async_block_till_done()
|
||||
assert acc._char_battery.value == 100
|
||||
assert acc._char_low_battery.value == 0
|
||||
assert acc._char_charging.value == 0
|
||||
@@ -396,6 +403,14 @@ async def test_linked_battery_charging_sensor(hass, hk_driver, caplog):
|
||||
mock_async_update_state.assert_called_with(state)
|
||||
assert acc._char_charging.value == 1
|
||||
|
||||
with patch(
|
||||
"homeassistant.components.homekit.accessories.HomeAccessory.async_update_state"
|
||||
) as mock_async_update_state:
|
||||
hass.states.async_remove(linked_battery_charging_sensor)
|
||||
await acc.run_handler()
|
||||
await hass.async_block_till_done()
|
||||
assert acc._char_charging.value == 1
|
||||
|
||||
|
||||
async def test_linked_battery_sensor_and_linked_battery_charging_sensor(
|
||||
hass, hk_driver, caplog
|
||||
@@ -439,6 +454,12 @@ async def test_linked_battery_sensor_and_linked_battery_charging_sensor(
|
||||
assert acc._char_low_battery.value == 0
|
||||
assert acc._char_charging.value == 0
|
||||
|
||||
hass.states.async_remove(linked_battery_charging_sensor)
|
||||
await hass.async_block_till_done()
|
||||
assert acc._char_battery.value == 50
|
||||
assert acc._char_low_battery.value == 0
|
||||
assert acc._char_charging.value == 0
|
||||
|
||||
|
||||
async def test_missing_linked_battery_charging_sensor(hass, hk_driver, caplog):
|
||||
"""Test battery service with linked_battery_charging_sensor that is mapping to a missing entity."""
|
||||
@@ -457,6 +478,24 @@ async def test_missing_linked_battery_charging_sensor(hass, hk_driver, caplog):
|
||||
)
|
||||
assert acc.linked_battery_charging_sensor is None
|
||||
|
||||
# Make sure we don't throw if the linked_battery_charging_sensor
|
||||
# is removed
|
||||
hass.states.async_remove(linked_battery_charging_sensor)
|
||||
with patch(
|
||||
"homeassistant.components.homekit.accessories.HomeAccessory.async_update_state"
|
||||
):
|
||||
await acc.run_handler()
|
||||
await hass.async_block_till_done()
|
||||
|
||||
# Make sure we don't throw if the entity_id
|
||||
# is removed
|
||||
hass.states.async_remove(entity_id)
|
||||
with patch(
|
||||
"homeassistant.components.homekit.accessories.HomeAccessory.async_update_state"
|
||||
):
|
||||
await acc.run_handler()
|
||||
await hass.async_block_till_done()
|
||||
|
||||
|
||||
async def test_missing_linked_battery_sensor(hass, hk_driver, caplog):
|
||||
"""Test battery service with missing linked_battery_sensor."""
|
||||
@@ -488,6 +527,18 @@ async def test_missing_linked_battery_sensor(hass, hk_driver, caplog):
|
||||
assert acc._char_low_battery is None
|
||||
assert acc._char_charging is None
|
||||
|
||||
with patch(
|
||||
"homeassistant.components.homekit.accessories.HomeAccessory.async_update_state"
|
||||
) as mock_async_update_state:
|
||||
hass.states.async_remove(entity_id)
|
||||
await acc.run_handler()
|
||||
await hass.async_block_till_done()
|
||||
|
||||
assert not acc.linked_battery_sensor
|
||||
assert acc._char_battery is None
|
||||
assert acc._char_low_battery is None
|
||||
assert acc._char_charging is None
|
||||
|
||||
|
||||
async def test_battery_appears_after_startup(hass, hk_driver, caplog):
|
||||
"""Test battery level appears after homekit is started."""
|
||||
@@ -514,6 +565,13 @@ async def test_battery_appears_after_startup(hass, hk_driver, caplog):
|
||||
await hass.async_block_till_done()
|
||||
assert acc._char_battery is None
|
||||
|
||||
with patch(
|
||||
"homeassistant.components.homekit.accessories.HomeAccessory.async_update_state"
|
||||
):
|
||||
hass.states.async_remove(entity_id)
|
||||
await hass.async_block_till_done()
|
||||
assert acc._char_battery is None
|
||||
|
||||
|
||||
async def test_call_service(hass, hk_driver, events):
|
||||
"""Test call_service method."""
|
||||
|
||||
Reference in new issue
Block a user