Fix poorly formatted automations (#14196)
This commit is contained in:
1 parent
5dcad89a0d
commit
853a16938b
2 files changed
+67
-8
No files matched your search
@@ -42,13 +42,13 @@ async def test_update_device_config(hass, aiohttp_client):
|
||||
client = await aiohttp_client(hass.http.app)
|
||||
|
||||
orig_data = [
|
||||
{
|
||||
'id': 'sun',
|
||||
},
|
||||
{
|
||||
'id': 'moon',
|
||||
}
|
||||
]
|
||||
{
|
||||
'id': 'sun',
|
||||
},
|
||||
{
|
||||
'id': 'moon',
|
||||
}
|
||||
]
|
||||
|
||||
def mock_read(path):
|
||||
"""Mock reading data."""
|
||||
@@ -81,3 +81,56 @@ async def test_update_device_config(hass, aiohttp_client):
|
||||
'action': [],
|
||||
}
|
||||
assert written[0] == orig_data
|
||||
|
||||
|
||||
async def test_bad_formatted_automations(hass, aiohttp_client):
|
||||
"""Test that we handle automations without ID."""
|
||||
with patch.object(config, 'SECTIONS', ['automation']):
|
||||
await async_setup_component(hass, 'config', {})
|
||||
|
||||
client = await aiohttp_client(hass.http.app)
|
||||
|
||||
orig_data = [
|
||||
{
|
||||
# No ID
|
||||
'action': {
|
||||
'event': 'hello'
|
||||
}
|
||||
},
|
||||
{
|
||||
'id': 'moon',
|
||||
}
|
||||
]
|
||||
|
||||
def mock_read(path):
|
||||
"""Mock reading data."""
|
||||
return orig_data
|
||||
|
||||
written = []
|
||||
|
||||
def mock_write(path, data):
|
||||
"""Mock writing data."""
|
||||
written.append(data)
|
||||
|
||||
with patch('homeassistant.components.config._read', mock_read), \
|
||||
patch('homeassistant.components.config._write', mock_write):
|
||||
resp = await client.post(
|
||||
'/api/config/automation/config/moon', data=json.dumps({
|
||||
'trigger': [],
|
||||
'action': [],
|
||||
'condition': [],
|
||||
}))
|
||||
|
||||
assert resp.status == 200
|
||||
result = await resp.json()
|
||||
assert result == {'result': 'ok'}
|
||||
|
||||
# Verify ID added to orig_data
|
||||
assert 'id' in orig_data[0]
|
||||
|
||||
assert orig_data[1] == {
|
||||
'id': 'moon',
|
||||
'trigger': [],
|
||||
'condition': [],
|
||||
'action': [],
|
||||
}
|
||||
Reference in new issue
Block a user