Streamlined child state lookups in universal media player

1) Removed children property because it was only being used by one
method.
2) Removed option to return state as object from _entity_lkp as it was
no longer needed.
3) Used hass.states.get to get entity state objects.
4) Revised test to remove children property.
This commit is contained in:
Ryan Kraus authored and Paulus Schoutsen committed 2016-01-12 22:15:22 -08:00
1 parent 8f3e8d29f0
commit 85d732a45a
2 files changed
+4 -32

No files matched your search

@@ -184,24 +184,6 @@ class TestMediaPlayer(unittest.TestCase):
self.assertEqual(STATE_OFF, ump.master_state)
def test_children(self):
""" test children property """
config = self.config_children_only
universal.validate_config(config)
ump = universal.UniversalMediaPlayer(self.hass, **config)
children = ump.children
check_children_ids = config['children']
check_children_ids.sort()
children_ids = list(children.keys())
children_ids.sort()
self.assertEqual(check_children_ids, children_ids)
check_children_states = [STATE_OFF, STATE_OFF]
children_states = [val.state for val in children.values()]
self.assertEqual(check_children_states, children_states)
def test_active_child_state(self):
""" test active child state property """
config = self.config_children_only