Add zwave per-node entity. (#6690)
* Add zwave per-node entity. * Disable lint import error * Add tests for base class * More tests * More tests * Sort .coveragerc * more tests * Move location, battery and wakeup to node entity * More tests * Cleanup * Make zwave node entity visible by default * Remove battery sensor * Fix tests
This commit is contained in:
1 parent
20c5f9de4b
commit
8a86ec5b74
11 files changed
+408
-133
No files matched your search
@@ -17,18 +17,6 @@ def test_get_device_detects_none(mock_openzwave):
|
||||
assert device is None
|
||||
|
||||
|
||||
def test_get_device_detects_sensor(mock_openzwave):
|
||||
"""Test get_device returns a Z-Wave Sensor."""
|
||||
node = MockNode(command_classes=[const.COMMAND_CLASS_BATTERY])
|
||||
value = MockValue(data=0, command_class=const.COMMAND_CLASS_BATTERY,
|
||||
node=node)
|
||||
values = MockEntityValues(primary=value)
|
||||
|
||||
device = zwave.get_device(node=node, values=values, node_config={})
|
||||
assert isinstance(device, zwave.ZWaveSensor)
|
||||
assert device.force_update
|
||||
|
||||
|
||||
def test_get_device_detects_alarmsensor(mock_openzwave):
|
||||
"""Test get_device returns a Z-Wave alarmsensor."""
|
||||
node = MockNode(command_classes=[const.COMMAND_CLASS_ALARM,
|
||||
@@ -61,21 +49,6 @@ def test_get_device_detects_multilevel_meter(mock_openzwave):
|
||||
assert isinstance(device, zwave.ZWaveMultilevelSensor)
|
||||
|
||||
|
||||
def test_sensor_value_changed(mock_openzwave):
|
||||
"""Test value changed for Z-Wave sensor."""
|
||||
node = MockNode(command_classes=[const.COMMAND_CLASS_BATTERY])
|
||||
value = MockValue(data=12.34, command_class=const.COMMAND_CLASS_BATTERY,
|
||||
node=node, units='%')
|
||||
values = MockEntityValues(primary=value)
|
||||
|
||||
device = zwave.get_device(node=node, values=values, node_config={})
|
||||
assert device.state == 12.34
|
||||
assert device.unit_of_measurement == '%'
|
||||
value.data = 45.67
|
||||
value_changed(value)
|
||||
assert device.state == 45.67
|
||||
|
||||
|
||||
def test_multilevelsensor_value_changed_temp_fahrenheit(mock_openzwave):
|
||||
"""Test value changed for Z-Wave multilevel sensor for temperature."""
|
||||
node = MockNode(command_classes=[const.COMMAND_CLASS_SENSOR_MULTILEVEL,
|
||||
|
||||
@@ -0,0 +1,168 @@
|
||||
"""Test Z-Wave node entity."""
|
||||
import unittest
|
||||
from unittest.mock import patch, Mock
|
||||
from tests.common import get_test_home_assistant
|
||||
import tests.mock.zwave as mock_zwave
|
||||
import pytest
|
||||
from homeassistant.components.zwave import node_entity
|
||||
|
||||
|
||||
@pytest.mark.usefixtures('mock_openzwave')
|
||||
class TestZWaveBaseEntity(unittest.TestCase):
|
||||
"""Class to test ZWaveBaseEntity."""
|
||||
|
||||
def setUp(self):
|
||||
"""Initialize values for this testcase class."""
|
||||
self.hass = get_test_home_assistant()
|
||||
|
||||
def call_soon(time, func, *args):
|
||||
"""Replace call_later by call_soon."""
|
||||
return self.hass.loop.call_soon(func, *args)
|
||||
|
||||
self.hass.loop.call_later = call_soon
|
||||
self.base_entity = node_entity.ZWaveBaseEntity()
|
||||
self.base_entity.hass = self.hass
|
||||
self.hass.start()
|
||||
|
||||
def tearDown(self): # pylint: disable=invalid-name
|
||||
"""Stop everything that was started."""
|
||||
self.hass.stop()
|
||||
|
||||
def test_maybe_schedule_update(self):
|
||||
"""Test maybe_schedule_update."""
|
||||
with patch.object(self.base_entity, 'async_update_ha_state',
|
||||
Mock()) as mock_update:
|
||||
self.base_entity.maybe_schedule_update()
|
||||
self.hass.block_till_done()
|
||||
mock_update.assert_called_once_with()
|
||||
|
||||
def test_maybe_schedule_update_called_twice(self):
|
||||
"""Test maybe_schedule_update called twice."""
|
||||
with patch.object(self.base_entity, 'async_update_ha_state',
|
||||
Mock()) as mock_update:
|
||||
self.base_entity.maybe_schedule_update()
|
||||
self.base_entity.maybe_schedule_update()
|
||||
self.hass.block_till_done()
|
||||
mock_update.assert_called_once_with()
|
||||
|
||||
|
||||
@pytest.mark.usefixtures('mock_openzwave')
|
||||
class TestZWaveNodeEntity(unittest.TestCase):
|
||||
"""Class to test ZWaveNodeEntity."""
|
||||
|
||||
def setUp(self):
|
||||
"""Initialize values for this testcase class."""
|
||||
self.node = mock_zwave.MockNode(
|
||||
query_stage='Dynamic', is_awake=True, is_ready=False,
|
||||
is_failed=False, is_info_received=True, max_baud_rate=40000,
|
||||
is_zwave_plus=False, capabilities=[], neighbors=[], location=None)
|
||||
self.entity = node_entity.ZWaveNodeEntity(self.node)
|
||||
|
||||
def test_network_node_changed_from_value(self):
|
||||
"""Test for network_node_changed."""
|
||||
value = mock_zwave.MockValue(node=self.node)
|
||||
with patch.object(self.entity, 'maybe_schedule_update') as mock:
|
||||
mock_zwave.value_changed(value)
|
||||
mock.assert_called_once_with()
|
||||
|
||||
def test_network_node_changed_from_node(self):
|
||||
"""Test for network_node_changed."""
|
||||
with patch.object(self.entity, 'maybe_schedule_update') as mock:
|
||||
mock_zwave.node_changed(self.node)
|
||||
mock.assert_called_once_with()
|
||||
|
||||
def test_network_node_changed_from_another_node(self):
|
||||
"""Test for network_node_changed."""
|
||||
with patch.object(self.entity, 'maybe_schedule_update') as mock:
|
||||
node = mock_zwave.MockNode(node_id=1024)
|
||||
mock_zwave.node_changed(node)
|
||||
self.assertFalse(mock.called)
|
||||
|
||||
def test_network_node_changed_from_notification(self):
|
||||
"""Test for network_node_changed."""
|
||||
with patch.object(self.entity, 'maybe_schedule_update') as mock:
|
||||
mock_zwave.notification(node_id=self.node.node_id)
|
||||
mock.assert_called_once_with()
|
||||
|
||||
def test_network_node_changed_from_another_notification(self):
|
||||
"""Test for network_node_changed."""
|
||||
with patch.object(self.entity, 'maybe_schedule_update') as mock:
|
||||
mock_zwave.notification(node_id=1024)
|
||||
self.assertFalse(mock.called)
|
||||
|
||||
def test_node_changed(self):
|
||||
"""Test node_changed function."""
|
||||
self.assertEqual({'node_id': self.node.node_id},
|
||||
self.entity.device_state_attributes)
|
||||
|
||||
self.node.get_values.return_value = {
|
||||
1: mock_zwave.MockValue(data=1800)
|
||||
}
|
||||
self.entity.node_changed()
|
||||
|
||||
self.assertEqual(
|
||||
{'node_id': self.node.node_id,
|
||||
'query_stage': 'Dynamic',
|
||||
'is_awake': True,
|
||||
'is_ready': False,
|
||||
'is_failed': False,
|
||||
'is_info_received': True,
|
||||
'max_baud_rate': 40000,
|
||||
'is_zwave_plus': False,
|
||||
'battery_level': 42,
|
||||
'wake_up_interval': 1800},
|
||||
self.entity.device_state_attributes)
|
||||
|
||||
self.node.can_wake_up_value = False
|
||||
self.entity.node_changed()
|
||||
|
||||
self.assertNotIn(
|
||||
'wake_up_interval', self.entity.device_state_attributes)
|
||||
|
||||
def test_name(self):
|
||||
"""Test name property."""
|
||||
self.assertEqual('Mock Node', self.entity.name)
|
||||
|
||||
def test_state_before_update(self):
|
||||
"""Test state before update was called."""
|
||||
self.assertIsNone(self.entity.state)
|
||||
|
||||
def test_state_not_ready(self):
|
||||
"""Test state property."""
|
||||
self.node.is_ready = False
|
||||
self.entity.node_changed()
|
||||
self.assertEqual('Dynamic', self.entity.state)
|
||||
|
||||
self.node.is_failed = True
|
||||
self.entity.node_changed()
|
||||
self.assertEqual('Dead (Dynamic)', self.entity.state)
|
||||
|
||||
self.node.is_failed = False
|
||||
self.node.is_awake = False
|
||||
self.entity.node_changed()
|
||||
self.assertEqual('Sleeping (Dynamic)', self.entity.state)
|
||||
|
||||
def test_state_ready(self):
|
||||
"""Test state property."""
|
||||
self.node.is_ready = True
|
||||
self.entity.node_changed()
|
||||
self.assertEqual('Ready', self.entity.state)
|
||||
|
||||
self.node.is_failed = True
|
||||
self.entity.node_changed()
|
||||
self.assertEqual('Dead', self.entity.state)
|
||||
|
||||
self.node.is_failed = False
|
||||
self.node.is_awake = False
|
||||
self.entity.node_changed()
|
||||
self.assertEqual('Sleeping', self.entity.state)
|
||||
|
||||
def test_not_polled(self):
|
||||
"""Test should_poll property."""
|
||||
self.assertFalse(self.entity.should_poll)
|
||||
|
||||
|
||||
def test_sub_status():
|
||||
"""Test sub_status function."""
|
||||
assert node_entity.sub_status('Status', 'Stage') == 'Status (Stage)'
|
||||
assert node_entity.sub_status('Status', '') == 'Status'
|
||||
+3
-1
@@ -14,7 +14,7 @@ from homeassistant.components import mqtt
|
||||
|
||||
from .common import async_test_home_assistant, mock_coro
|
||||
from .test_util.aiohttp import mock_aiohttp_client
|
||||
from .mock.zwave import SIGNAL_VALUE_CHANGED
|
||||
from .mock.zwave import SIGNAL_VALUE_CHANGED, SIGNAL_NODE, SIGNAL_NOTIFICATION
|
||||
|
||||
if os.environ.get('UVLOOP') == '1':
|
||||
import uvloop
|
||||
@@ -101,6 +101,8 @@ def mock_openzwave():
|
||||
libopenzwave = base_mock.libopenzwave
|
||||
libopenzwave.__file__ = 'test'
|
||||
base_mock.network.ZWaveNetwork.SIGNAL_VALUE_CHANGED = SIGNAL_VALUE_CHANGED
|
||||
base_mock.network.ZWaveNetwork.SIGNAL_NODE = SIGNAL_NODE
|
||||
base_mock.network.ZWaveNetwork.SIGNAL_NOTIFICATION = SIGNAL_NOTIFICATION
|
||||
|
||||
with patch.dict('sys.modules', {
|
||||
'libopenzwave': libopenzwave,
|
||||
|
||||
+34
-1
@@ -4,6 +4,8 @@ from unittest.mock import MagicMock
|
||||
from pydispatch import dispatcher
|
||||
|
||||
SIGNAL_VALUE_CHANGED = 'mock_value_changed'
|
||||
SIGNAL_NODE = 'mock_node'
|
||||
SIGNAL_NOTIFICATION = 'mock_notification'
|
||||
|
||||
|
||||
def value_changed(value):
|
||||
@@ -16,6 +18,24 @@ def value_changed(value):
|
||||
)
|
||||
|
||||
|
||||
def node_changed(node):
|
||||
"""Fire a node changed."""
|
||||
dispatcher.send(
|
||||
SIGNAL_NODE,
|
||||
node=node,
|
||||
network=node._network
|
||||
)
|
||||
|
||||
|
||||
def notification(node_id, network=None):
|
||||
"""Fire a notification."""
|
||||
dispatcher.send(
|
||||
SIGNAL_NOTIFICATION,
|
||||
args={'nodeId': node_id},
|
||||
network=network
|
||||
)
|
||||
|
||||
|
||||
class MockNode(MagicMock):
|
||||
"""Mock Z-Wave node."""
|
||||
|
||||
@@ -25,7 +45,9 @@ class MockNode(MagicMock):
|
||||
manufacturer_id='ABCD',
|
||||
product_id='123',
|
||||
product_type='678',
|
||||
command_classes=None):
|
||||
command_classes=None,
|
||||
can_wake_up_value=True,
|
||||
**kwargs):
|
||||
"""Initialize a Z-Wave mock node."""
|
||||
super().__init__()
|
||||
self.node_id = node_id
|
||||
@@ -33,12 +55,23 @@ class MockNode(MagicMock):
|
||||
self.manufacturer_id = manufacturer_id
|
||||
self.product_id = product_id
|
||||
self.product_type = product_type
|
||||
self.can_wake_up_value = can_wake_up_value
|
||||
self._command_classes = command_classes or []
|
||||
for attr_name in kwargs:
|
||||
setattr(self, attr_name, kwargs[attr_name])
|
||||
|
||||
def has_command_class(self, command_class):
|
||||
"""Test if mock has a command class."""
|
||||
return command_class in self._command_classes
|
||||
|
||||
def get_battery_level(self):
|
||||
"""Return mock battery level."""
|
||||
return 42
|
||||
|
||||
def can_wake_up(self):
|
||||
"""Return whether the node can wake up."""
|
||||
return self.can_wake_up_value
|
||||
|
||||
def _get_child_mock(self, **kw):
|
||||
"""Create child mocks with right MagicMock class."""
|
||||
return MagicMock(**kw)
|
||||
|
||||
Reference in new issue
Block a user