Apply recommendations from roku code review (#32883)

* avoid patching integration methods

* Update config_flow.py

* apply recommendations from roku code review

* Update config_flow.py
This commit is contained in:
Chris Talkington authored and GitHub committed 2020-03-17 21:15:41 +01:00
1 parent e97d21aec0
commit 9146f76b01
4 files changed
+39 -23

No files matched your search

+16 -9
View File
@@ -124,10 +124,12 @@ async def test_form_cannot_connect(hass: HomeAssistantType) -> None:
)
with patch(
"homeassistant.components.roku.config_flow.validate_input",
"homeassistant.components.roku.config_flow.Roku._call",
side_effect=RokuException,
) as mock_validate_input:
result = await async_configure_flow(hass, result["flow_id"], {CONF_HOST: HOST},)
result = await hass.config_entries.flow.async_configure(
flow_id=result["flow_id"], user_input={CONF_HOST: HOST}
)
assert result["type"] == RESULT_TYPE_FORM
assert result["errors"] == {"base": "cannot_connect"}
@@ -143,10 +145,12 @@ async def test_form_cannot_connect_request(hass: HomeAssistantType) -> None:
)
with patch(
"homeassistant.components.roku.config_flow.validate_input",
"homeassistant.components.roku.config_flow.Roku._call",
side_effect=RequestException,
) as mock_validate_input:
result = await async_configure_flow(hass, result["flow_id"], {CONF_HOST: HOST},)
result = await hass.config_entries.flow.async_configure(
flow_id=result["flow_id"], user_input={CONF_HOST: HOST}
)
assert result["type"] == RESULT_TYPE_FORM
assert result["errors"] == {"base": "cannot_connect"}
@@ -162,10 +166,12 @@ async def test_form_cannot_connect_socket(hass: HomeAssistantType) -> None:
)
with patch(
"homeassistant.components.roku.config_flow.validate_input",
"homeassistant.components.roku.config_flow.Roku._call",
side_effect=SocketGIAError,
) as mock_validate_input:
result = await async_configure_flow(hass, result["flow_id"], {CONF_HOST: HOST},)
result = await hass.config_entries.flow.async_configure(
flow_id=result["flow_id"], user_input={CONF_HOST: HOST}
)
assert result["type"] == RESULT_TYPE_FORM
assert result["errors"] == {"base": "cannot_connect"}
@@ -181,10 +187,11 @@ async def test_form_unknown_error(hass: HomeAssistantType) -> None:
)
with patch(
"homeassistant.components.roku.config_flow.validate_input",
side_effect=Exception,
"homeassistant.components.roku.config_flow.Roku._call", side_effect=Exception,
) as mock_validate_input:
result = await async_configure_flow(hass, result["flow_id"], {CONF_HOST: HOST},)
result = await hass.config_entries.flow.async_configure(
flow_id=result["flow_id"], user_input={CONF_HOST: HOST}
)
assert result["type"] == RESULT_TYPE_ABORT
assert result["reason"] == "unknown"