Use more homeassistant constants in NWS (#39690)

This commit is contained in:
MatthewFlamm authored and GitHub committed 2020-09-05 21:11:15 +02:00
1 parent d2b1918e9c
commit 958c9c08d6
4 files changed
+58 -39

No files matched your search

+6 -5
View File
@@ -1,8 +1,9 @@
"""Helpers for interacting with pynws."""
from homeassistant.components.nws.const import CONF_STATION
from homeassistant.components.nws.weather import ATTR_FORECAST_PRECIP_PROB
from homeassistant.components.weather import (
ATTR_CONDITION_LIGHTNING_RAINY,
ATTR_FORECAST_CONDITION,
ATTR_FORECAST_PRECIPITATION_PROBABILITY,
ATTR_FORECAST_TEMP,
ATTR_FORECAST_TIME,
ATTR_FORECAST_WIND_BEARING,
@@ -101,23 +102,23 @@ DEFAULT_FORECAST = [
]
EXPECTED_FORECAST_IMPERIAL = {
ATTR_FORECAST_CONDITION: "lightning-rainy",
ATTR_FORECAST_CONDITION: ATTR_CONDITION_LIGHTNING_RAINY,
ATTR_FORECAST_TIME: "2019-08-12T20:00:00-04:00",
ATTR_FORECAST_TEMP: 10,
ATTR_FORECAST_WIND_SPEED: 10,
ATTR_FORECAST_WIND_BEARING: 180,
ATTR_FORECAST_PRECIP_PROB: 90,
ATTR_FORECAST_PRECIPITATION_PROBABILITY: 90,
}
EXPECTED_FORECAST_METRIC = {
ATTR_FORECAST_CONDITION: "lightning-rainy",
ATTR_FORECAST_CONDITION: ATTR_CONDITION_LIGHTNING_RAINY,
ATTR_FORECAST_TIME: "2019-08-12T20:00:00-04:00",
ATTR_FORECAST_TEMP: round(convert_temperature(10, TEMP_FAHRENHEIT, TEMP_CELSIUS)),
ATTR_FORECAST_WIND_SPEED: round(
convert_distance(10, LENGTH_MILES, LENGTH_KILOMETERS)
),
ATTR_FORECAST_WIND_BEARING: 180,
ATTR_FORECAST_PRECIP_PROB: 90,
ATTR_FORECAST_PRECIPITATION_PROBABILITY: 90,
}
NONE_FORECAST = [{key: None for key in DEFAULT_FORECAST[0]}]
+17 -16
View File
@@ -5,7 +5,8 @@ import aiohttp
import pytest
from homeassistant.components import nws
from homeassistant.components.weather import ATTR_FORECAST
from homeassistant.components.weather import ATTR_CONDITION_SUNNY, ATTR_FORECAST
from homeassistant.const import STATE_UNAVAILABLE, STATE_UNKNOWN
from homeassistant.setup import async_setup_component
import homeassistant.util.dt as dt_util
from homeassistant.util.unit_system import IMPERIAL_SYSTEM, METRIC_SYSTEM
@@ -46,7 +47,7 @@ async def test_imperial_metric(
state = hass.states.get("weather.abc_hourly")
assert state
assert state.state == "sunny"
assert state.state == ATTR_CONDITION_SUNNY
data = state.attributes
for key, value in result_observation.items():
@@ -59,7 +60,7 @@ async def test_imperial_metric(
state = hass.states.get("weather.abc_daynight")
assert state
assert state.state == "sunny"
assert state.state == ATTR_CONDITION_SUNNY
data = state.attributes
for key, value in result_observation.items():
@@ -85,7 +86,7 @@ async def test_none_values(hass, mock_simple_nws):
await hass.async_block_till_done()
state = hass.states.get("weather.abc_daynight")
assert state.state == "unknown"
assert state.state == STATE_UNKNOWN
data = state.attributes
for key in EXPECTED_OBSERVATION_IMPERIAL:
assert data.get(key) is None
@@ -111,7 +112,7 @@ async def test_none(hass, mock_simple_nws):
state = hass.states.get("weather.abc_daynight")
assert state
assert state.state == "unknown"
assert state.state == STATE_UNKNOWN
data = state.attributes
for key in EXPECTED_OBSERVATION_IMPERIAL:
@@ -198,11 +199,11 @@ async def test_error_observation(hass, mock_simple_nws):
state = hass.states.get("weather.abc_daynight")
assert state
assert state.state == "unavailable"
assert state.state == STATE_UNAVAILABLE
state = hass.states.get("weather.abc_hourly")
assert state
assert state.state == "unavailable"
assert state.state == STATE_UNAVAILABLE
# second update happens faster and succeeds
instance.update_observation.side_effect = None
@@ -213,7 +214,7 @@ async def test_error_observation(hass, mock_simple_nws):
state = hass.states.get("weather.abc_daynight")
assert state
assert state.state == "sunny"
assert state.state == ATTR_CONDITION_SUNNY
state = hass.states.get("weather.abc_hourly")
assert state
@@ -229,11 +230,11 @@ async def test_error_observation(hass, mock_simple_nws):
state = hass.states.get("weather.abc_daynight")
assert state
assert state.state == "sunny"
assert state.state == ATTR_CONDITION_SUNNY
state = hass.states.get("weather.abc_hourly")
assert state
assert state.state == "sunny"
assert state.state == ATTR_CONDITION_SUNNY
# after 20 minutes data caching expires, data is no longer shown
increment_time(timedelta(minutes=10))
@@ -241,11 +242,11 @@ async def test_error_observation(hass, mock_simple_nws):
state = hass.states.get("weather.abc_daynight")
assert state
assert state.state == "unavailable"
assert state.state == STATE_UNAVAILABLE
state = hass.states.get("weather.abc_hourly")
assert state
assert state.state == "unavailable"
assert state.state == STATE_UNAVAILABLE
async def test_error_forecast(hass, mock_simple_nws):
@@ -265,7 +266,7 @@ async def test_error_forecast(hass, mock_simple_nws):
state = hass.states.get("weather.abc_daynight")
assert state
assert state.state == "unavailable"
assert state.state == STATE_UNAVAILABLE
instance.update_forecast.side_effect = None
@@ -276,7 +277,7 @@ async def test_error_forecast(hass, mock_simple_nws):
state = hass.states.get("weather.abc_daynight")
assert state
assert state.state == "sunny"
assert state.state == ATTR_CONDITION_SUNNY
async def test_error_forecast_hourly(hass, mock_simple_nws):
@@ -294,7 +295,7 @@ async def test_error_forecast_hourly(hass, mock_simple_nws):
state = hass.states.get("weather.abc_hourly")
assert state
assert state.state == "unavailable"
assert state.state == STATE_UNAVAILABLE
instance.update_forecast_hourly.assert_called_once()
@@ -307,4 +308,4 @@ async def test_error_forecast_hourly(hass, mock_simple_nws):
state = hass.states.get("weather.abc_hourly")
assert state
assert state.state == "sunny"
assert state.state == ATTR_CONDITION_SUNNY