Feedreader configurable update interval and max entries (#14487)

tests/components/test_feedreader.py

@@ -1,6 +1,6 @@
 """The tests for the feedreader component."""
 import time
-from datetime import datetime
+from datetime import datetime, timedelta
 
 import unittest
 from genericpath import exists
@@ -11,12 +11,12 @@ from unittest.mock import patch
 
 from homeassistant.components import feedreader
 from homeassistant.components.feedreader import CONF_URLS, FeedManager, \
-    StoredData, EVENT_FEEDREADER
-from homeassistant.const import EVENT_HOMEASSISTANT_START
+    StoredData, EVENT_FEEDREADER, DEFAULT_SCAN_INTERVAL, CONF_MAX_ENTRIES, \
+    DEFAULT_MAX_ENTRIES
+from homeassistant.const import EVENT_HOMEASSISTANT_START, CONF_SCAN_INTERVAL
 from homeassistant.core import callback
 from homeassistant.setup import setup_component
-from tests.common import get_test_home_assistant, assert_setup_component, \
-    load_fixture
+from tests.common import get_test_home_assistant, load_fixture
 
 _LOGGER = getLogger(__name__)
 
@@ -26,6 +26,18 @@ VALID_CONFIG_1 = {
         CONF_URLS: [URL]
     }
 }
+VALID_CONFIG_2 = {
+    feedreader.DOMAIN: {
+        CONF_URLS: [URL],
+        CONF_SCAN_INTERVAL: 60
+    }
+}
+VALID_CONFIG_3 = {
+    feedreader.DOMAIN: {
+        CONF_URLS: [URL],
+        CONF_MAX_ENTRIES: 100
+    }
+}
 
 
 class TestFeedreaderComponent(unittest.TestCase):
@@ -45,11 +57,28 @@ class TestFeedreaderComponent(unittest.TestCase):
 
     def test_setup_one_feed(self):
         """Test the general setup of this component."""
-        with assert_setup_component(1, 'feedreader'):
+        with patch("homeassistant.components.feedreader."
+                   "track_time_interval") as track_method:
             self.assertTrue(setup_component(self.hass, feedreader.DOMAIN,
                                             VALID_CONFIG_1))
+            track_method.assert_called_once_with(self.hass, mock.ANY,
+                                                 DEFAULT_SCAN_INTERVAL)
 
-    def setup_manager(self, feed_data):
+    def test_setup_scan_interval(self):
+        """Test the setup of this component with scan interval."""
+        with patch("homeassistant.components.feedreader."
+                   "track_time_interval") as track_method:
+            self.assertTrue(setup_component(self.hass, feedreader.DOMAIN,
+                                            VALID_CONFIG_2))
+            track_method.assert_called_once_with(self.hass, mock.ANY,
+                                                 timedelta(seconds=60))
+
+    def test_setup_max_entries(self):
+        """Test the setup of this component with max entries."""
+        self.assertTrue(setup_component(self.hass, feedreader.DOMAIN,
+                                        VALID_CONFIG_3))
+
+    def setup_manager(self, feed_data, max_entries=DEFAULT_MAX_ENTRIES):
         """Generic test setup method."""
         events = []
 
@@ -67,12 +96,13 @@ class TestFeedreaderComponent(unittest.TestCase):
             feedreader.DOMAIN))
         storage = StoredData(data_file)
         with patch("homeassistant.components.feedreader."
-                   "track_utc_time_change") as track_method:
-            manager = FeedManager(feed_data, self.hass, storage)
+                   "track_time_interval") as track_method:
+            manager = FeedManager(feed_data, DEFAULT_SCAN_INTERVAL,
+                                  max_entries, self.hass, storage)
             # Can't use 'assert_called_once' here because it's not available
             # in Python 3.5 yet.
-            track_method.assert_called_once_with(self.hass, mock.ANY, minute=0,
-                                                 second=0)
+            track_method.assert_called_once_with(self.hass, mock.ANY,
+                                                 DEFAULT_SCAN_INTERVAL)
         # Artificially trigger update.
         self.hass.bus.fire(EVENT_HOMEASSISTANT_START)
         # Collect events.
@@ -116,12 +146,18 @@ class TestFeedreaderComponent(unittest.TestCase):
             manager3, events3 = self.setup_manager(feed_data3)
             assert len(events3) == 0
 
-    def test_feed_max_length(self):
-        """Test long feed beyond the 20 entry limit."""
+    def test_feed_default_max_length(self):
+        """Test long feed beyond the default 20 entry limit."""
         feed_data = load_fixture('feedreader2.xml')
         manager, events = self.setup_manager(feed_data)
         assert len(events) == 20
 
+    def test_feed_max_length(self):
+        """Test long feed beyond a configured 5 entry limit."""
+        feed_data = load_fixture('feedreader2.xml')
+        manager, events = self.setup_manager(feed_data, max_entries=5)
+        assert len(events) == 5
+
     def test_feed_without_publication_date(self):
         """Test simple feed with entry without publication date."""
         feed_data = load_fixture('feedreader3.xml')
@@ -141,7 +177,8 @@ class TestFeedreaderComponent(unittest.TestCase):
         data_file = self.hass.config.path("{}.pickle".format(
             feedreader.DOMAIN))
         storage = StoredData(data_file)
-        manager = FeedManager("FEED DATA", self.hass, storage)
+        manager = FeedManager("FEED DATA", DEFAULT_SCAN_INTERVAL,
+                              DEFAULT_MAX_ENTRIES, self.hass, storage)
         # Artificially trigger update.
         self.hass.bus.fire(EVENT_HOMEASSISTANT_START)
         # Collect events.