Exception chaining and wrapping improvements (#39320)
* Remove unnecessary exception re-wraps * Preserve exception chains on re-raise We slap "from cause" to almost all possible cases here. In some cases it could conceivably be better to do "from None" if we really want to hide the cause. However those should be in the minority, and "from cause" should be an improvement over the corresponding raise without a "from" in all cases anyway. The only case where we raise from None here is in plex, where the exception for an original invalid SSL cert is not the root cause for failure to validate a newly fetched one. Follow local convention on exception variable names if there is a consistent one, otherwise `err` to match with majority of codebase. * Fix mistaken re-wrap in homematicip_cloud/hap.py Missed the difference between HmipConnectionError and HmipcConnectionError. * Do not hide original error on plex new cert validation error Original is not the cause for the new one, but showing old in the traceback is useful nevertheless.
This commit is contained in:
1 parent
d768fd4de9
commit
b4bac0f7a0
204 files changed
+550
-518
No files matched your search
@@ -28,15 +28,15 @@ async def _validate_input(data: Dict[str, Any]) -> str:
|
||||
version = await bond.version()
|
||||
# call to non-version API is needed to validate authentication
|
||||
await bond.devices()
|
||||
except ClientConnectionError:
|
||||
raise InputValidationError("cannot_connect")
|
||||
except ClientConnectionError as error:
|
||||
raise InputValidationError("cannot_connect") from error
|
||||
except ClientResponseError as error:
|
||||
if error.status == 401:
|
||||
raise InputValidationError("invalid_auth")
|
||||
raise InputValidationError("unknown")
|
||||
except Exception:
|
||||
raise InputValidationError("invalid_auth") from error
|
||||
raise InputValidationError("unknown") from error
|
||||
except Exception as error:
|
||||
_LOGGER.exception("Unexpected exception")
|
||||
raise InputValidationError("unknown")
|
||||
raise InputValidationError("unknown") from error
|
||||
|
||||
# Return unique ID from the hub to be stored in the config entry.
|
||||
bond_id = version.get("bondid")
|
||||
|
||||
Reference in new issue
Block a user