Add HomeKit low battery threshold config (#23363)

This commit is contained in:
Austin Drummond authored and cdce8p committed 2019-04-30 02:02:53 +02:00
1 parent 2aee31ec6a
commit b4e2a0ef84
5 files changed
+61 -27

No files matched your search

+15 -7
View File
@@ -13,7 +13,8 @@ from homeassistant.components.homekit.const import (
ATTR_DISPLAY_NAME, ATTR_VALUE,
BRIDGE_MODEL, BRIDGE_NAME, BRIDGE_SERIAL_NUMBER, CHAR_FIRMWARE_REVISION,
CHAR_MANUFACTURER, CHAR_MODEL, CHAR_NAME, CHAR_SERIAL_NUMBER,
CONF_LINKED_BATTERY_SENSOR, MANUFACTURER, SERV_ACCESSORY_INFO)
CONF_LINKED_BATTERY_SENSOR, CONF_LOW_BATTERY_THRESHOLD,
DEFAULT_LOW_BATTERY_THRESHOLD, MANUFACTURER, SERV_ACCESSORY_INFO)
from homeassistant.const import (
__version__, ATTR_BATTERY_CHARGING, ATTR_BATTERY_LEVEL, ATTR_ENTITY_ID,
ATTR_SERVICE, ATTR_NOW, EVENT_TIME_CHANGED)
@@ -106,7 +107,9 @@ async def test_battery_service(hass, hk_driver, caplog):
hass.states.async_set(entity_id, None, {ATTR_BATTERY_LEVEL: 50})
await hass.async_block_till_done()
acc = HomeAccessory(hass, hk_driver, 'Battery Service', entity_id, 2, None)
acc = HomeAccessory(hass, hk_driver, 'Battery Service', entity_id, 2,
{CONF_LOW_BATTERY_THRESHOLD:
DEFAULT_LOW_BATTERY_THRESHOLD})
acc.update_state = lambda x: None
assert acc._char_battery.value == 0
assert acc._char_low_battery.value == 0
@@ -136,7 +139,9 @@ async def test_battery_service(hass, hk_driver, caplog):
ATTR_BATTERY_LEVEL: 10, ATTR_BATTERY_CHARGING: True})
await hass.async_block_till_done()
acc = HomeAccessory(hass, hk_driver, 'Battery Service', entity_id, 2, None)
acc = HomeAccessory(hass, hk_driver, 'Battery Service', entity_id, 2,
{CONF_LOW_BATTERY_THRESHOLD:
DEFAULT_LOW_BATTERY_THRESHOLD})
acc.update_state = lambda x: None
assert acc._char_battery.value == 0
assert acc._char_low_battery.value == 0
@@ -165,7 +170,9 @@ async def test_linked_battery_sensor(hass, hk_driver, caplog):
await hass.async_block_till_done()
acc = HomeAccessory(hass, hk_driver, 'Battery Service', entity_id, 2,
{CONF_LINKED_BATTERY_SENSOR: linked_battery})
{CONF_LINKED_BATTERY_SENSOR: linked_battery,
CONF_LOW_BATTERY_THRESHOLD:
DEFAULT_LOW_BATTERY_THRESHOLD})
acc.update_state = lambda x: None
assert acc.linked_battery_sensor == linked_battery
@@ -191,17 +198,18 @@ async def test_linked_battery_sensor(hass, hk_driver, caplog):
assert acc._char_battery.value == 10
assert 'ERROR' not in caplog.text
# Test charging
# Test charging & low battery threshold
hass.states.async_set(linked_battery, 20, {ATTR_BATTERY_CHARGING: True})
await hass.async_block_till_done()
acc = HomeAccessory(hass, hk_driver, 'Battery Service', entity_id, 2,
{CONF_LINKED_BATTERY_SENSOR: linked_battery})
{CONF_LINKED_BATTERY_SENSOR: linked_battery,
CONF_LOW_BATTERY_THRESHOLD: 50})
acc.update_state = lambda x: None
await hass.async_add_job(acc.run)
await hass.async_block_till_done()
assert acc._char_battery.value == 20
assert acc._char_low_battery.value == 0
assert acc._char_low_battery.value == 1
assert acc._char_charging.value == 1
hass.states.async_set(linked_battery, 100, {ATTR_BATTERY_CHARGING: False})