Fix trend binary sensor and tests (#22686)

This commit is contained in:
Jason Hu authored and Paulus Schoutsen committed 2019-04-03 09:04:30 -07:00
1 parent 048b100eea
commit b4fc1d77ea
2 files changed
+26 -11

No files matched your search

@@ -141,7 +141,7 @@ class SensorTrend(BinarySensorDevice):
else: else:
state = new_state.state state = new_state.state
if state not in (STATE_UNKNOWN, STATE_UNAVAILABLE): if state not in (STATE_UNKNOWN, STATE_UNAVAILABLE):
sample = (utcnow().timestamp(), float(state)) sample = (new_state.last_updated.timestamp(), float(state))
self.samples.append(sample) self.samples.append(sample)
self.async_schedule_update_ha_state(True) self.async_schedule_update_ha_state(True)
except (ValueError, TypeError) as ex: except (ValueError, TypeError) as ex:
+25 -10
View File
@@ -1,5 +1,9 @@
"""The test for the Trend sensor platform.""" """The test for the Trend sensor platform."""
from datetime import timedelta
from unittest.mock import patch
from homeassistant import setup from homeassistant import setup
import homeassistant.util.dt as dt_util
from tests.common import get_test_home_assistant, assert_setup_component from tests.common import get_test_home_assistant, assert_setup_component
@@ -46,7 +50,7 @@ class TestTrendBinarySensor:
'sensors': { 'sensors': {
'test_trend_sensor': { 'test_trend_sensor': {
'entity_id': "sensor.test_state", 'entity_id': "sensor.test_state",
'sample_duration': 300, 'sample_duration': 10000,
'min_gradient': 1, 'min_gradient': 1,
'max_samples': 25, 'max_samples': 25,
} }
@@ -54,16 +58,22 @@ class TestTrendBinarySensor:
} }
}) })
for val in [1, 0, 2, 3]: now = dt_util.utcnow()
self.hass.states.set('sensor.test_state', val) for val in [10, 0, 20, 30]:
with patch('homeassistant.util.dt.utcnow', return_value=now):
self.hass.states.set('sensor.test_state', val)
self.hass.block_till_done() self.hass.block_till_done()
now += timedelta(seconds=2)
state = self.hass.states.get('binary_sensor.test_trend_sensor') state = self.hass.states.get('binary_sensor.test_trend_sensor')
assert state.state == 'on' assert state.state == 'on'
for val in [0, 1, 0, 0]: # have to change state value, otherwise sample will lost
self.hass.states.set('sensor.test_state', val) for val in [0, 30, 1, 0]:
with patch('homeassistant.util.dt.utcnow', return_value=now):
self.hass.states.set('sensor.test_state', val)
self.hass.block_till_done() self.hass.block_till_done()
now += timedelta(seconds=2)
state = self.hass.states.get('binary_sensor.test_trend_sensor') state = self.hass.states.get('binary_sensor.test_trend_sensor')
assert state.state == 'off' assert state.state == 'off'
@@ -76,7 +86,7 @@ class TestTrendBinarySensor:
'sensors': { 'sensors': {
'test_trend_sensor': { 'test_trend_sensor': {
'entity_id': "sensor.test_state", 'entity_id': "sensor.test_state",
'sample_duration': 300, 'sample_duration': 10000,
'min_gradient': 1, 'min_gradient': 1,
'max_samples': 25, 'max_samples': 25,
'invert': 'Yes' 'invert': 'Yes'
@@ -85,16 +95,21 @@ class TestTrendBinarySensor:
} }
}) })
for val in [3, 2, 3, 1]: now = dt_util.utcnow()
self.hass.states.set('sensor.test_state', val) for val in [30, 20, 30, 10]:
with patch('homeassistant.util.dt.utcnow', return_value=now):
self.hass.states.set('sensor.test_state', val)
self.hass.block_till_done() self.hass.block_till_done()
now += timedelta(seconds=2)
state = self.hass.states.get('binary_sensor.test_trend_sensor') state = self.hass.states.get('binary_sensor.test_trend_sensor')
assert state.state == 'on' assert state.state == 'on'
for val in [4, 2, 4, 4]: for val in [30, 0, 45, 50]:
self.hass.states.set('sensor.test_state', val) with patch('homeassistant.util.dt.utcnow', return_value=now):
self.hass.states.set('sensor.test_state', val)
self.hass.block_till_done() self.hass.block_till_done()
now += timedelta(seconds=2)
state = self.hass.states.get('binary_sensor.test_trend_sensor') state = self.hass.states.get('binary_sensor.test_trend_sensor')
assert state.state == 'off' assert state.state == 'off'