bugfix: ensure the google_assistant component respects allow_unlock (#18874)
The `Config` object specific to the `google_assistant` component had a default value for `allow_unlock`. We were not overriding this default when constructing the Config object during `google_assistant` component setup, whereas we do when setting up the `cloud` component. To fix, we thread the `allow_unlock` parameter down through http setup, and ensure that it's set correctly. Moreover, we also change the ordering of the `Config` parameters, and remove the default. Future refactoring should not miss it, as it is now a required parameter.
This commit is contained in:
1 parent
a62fc7ca04
commit
b7e2522083
5 files changed
+12
-5
No files matched your search
@@ -16,8 +16,8 @@ class SmartHomeError(Exception):
|
||||
class Config:
|
||||
"""Hold the configuration for Google Assistant."""
|
||||
|
||||
def __init__(self, should_expose, agent_user_id, entity_config=None,
|
||||
allow_unlock=False):
|
||||
def __init__(self, should_expose, allow_unlock, agent_user_id,
|
||||
entity_config=None):
|
||||
"""Initialize the configuration."""
|
||||
self.should_expose = should_expose
|
||||
self.agent_user_id = agent_user_id
|
||||
|
||||
Reference in new issue
Block a user