Do not use pychromecast.Chromecast for Cast Groups (#8786)
* Do not use pychromecast.Chromecast for Cast Groups pychromecast.Chromecast creates Chromecast instance with friendly_name and cast_type of the device and not of a group. Which leads to collisions * Update cast.py * using hass.data * Fixed and extended tests * Line length in tests * Lint in tests
This commit is contained in:
1 parent
99a20c845c
commit
c49cce7243
2 files changed
+67
-10
No files matched your search
@@ -6,6 +6,7 @@ from unittest.mock import patch, MagicMock
|
||||
import pytest
|
||||
|
||||
from homeassistant.components.media_player import cast
|
||||
from tests.common import get_test_home_assistant
|
||||
|
||||
|
||||
@pytest.fixture(autouse=True)
|
||||
@@ -29,6 +30,14 @@ class FakeChromeCast(object):
|
||||
class TestCastMediaPlayer(unittest.TestCase):
|
||||
"""Test the media_player module."""
|
||||
|
||||
def setUp(self):
|
||||
"""Setup things to be run when tests are started."""
|
||||
self.hass = get_test_home_assistant()
|
||||
|
||||
def tearDown(self):
|
||||
"""Stop everything that was started."""
|
||||
self.hass.stop()
|
||||
|
||||
@patch('homeassistant.components.media_player.cast.CastDevice')
|
||||
@patch('pychromecast.get_chromecasts')
|
||||
def test_filter_duplicates(self, mock_get_chromecasts, mock_device):
|
||||
@@ -38,7 +47,7 @@ class TestCastMediaPlayer(unittest.TestCase):
|
||||
]
|
||||
|
||||
# Test chromecasts as if they were hardcoded in configuration.yaml
|
||||
cast.setup_platform(None, {
|
||||
cast.setup_platform(self.hass, {
|
||||
'host': 'some_host'
|
||||
}, lambda _: _)
|
||||
|
||||
@@ -48,8 +57,44 @@ class TestCastMediaPlayer(unittest.TestCase):
|
||||
assert not mock_device.called
|
||||
|
||||
# Test chromecasts as if they were automatically discovered
|
||||
cast.setup_platform(None, {}, lambda _: _, {
|
||||
cast.setup_platform(self.hass, {}, lambda _: _, {
|
||||
'host': 'some_host',
|
||||
'port': cast.DEFAULT_PORT,
|
||||
})
|
||||
assert not mock_device.called
|
||||
|
||||
@patch('homeassistant.components.media_player.cast.CastDevice')
|
||||
@patch('pychromecast.get_chromecasts')
|
||||
@patch('pychromecast.Chromecast')
|
||||
def test_fallback_cast(self, mock_chromecast, mock_get_chromecasts,
|
||||
mock_device):
|
||||
"""Test falling back to creating Chromecast when not discovered."""
|
||||
mock_get_chromecasts.return_value = [
|
||||
FakeChromeCast('some_host', cast.DEFAULT_PORT)
|
||||
]
|
||||
|
||||
# Test chromecasts as if they were hardcoded in configuration.yaml
|
||||
cast.setup_platform(self.hass, {
|
||||
'host': 'some_other_host'
|
||||
}, lambda _: _)
|
||||
|
||||
assert mock_chromecast.called
|
||||
assert mock_device.called
|
||||
|
||||
@patch('homeassistant.components.media_player.cast.CastDevice')
|
||||
@patch('pychromecast.get_chromecasts')
|
||||
@patch('pychromecast.Chromecast')
|
||||
def test_fallback_cast_group(self, mock_chromecast, mock_get_chromecasts,
|
||||
mock_device):
|
||||
"""Test not creating Cast Group when not discovered."""
|
||||
mock_get_chromecasts.return_value = [
|
||||
FakeChromeCast('some_host', cast.DEFAULT_PORT)
|
||||
]
|
||||
|
||||
# Test chromecasts as if they were automatically discovered
|
||||
cast.setup_platform(self.hass, {}, lambda _: _, {
|
||||
'host': 'some_other_host',
|
||||
'port': 43546,
|
||||
})
|
||||
assert not mock_chromecast.called
|
||||
assert not mock_device.called
|
||||
Reference in new issue
Block a user