Don't use len(SEQUENCE) as condition value (#7249)

* Don't use len(SEQUENCE) as condition value

* Update volvooncall.py
This commit is contained in:
Fabian Affolter authored and Paulus Schoutsen committed 2017-04-23 20:41:09 -07:00
1 parent 15b2473224
commit cfc023e128
43 files changed
+319 -355

No files matched your search

+29 -30
View File
@@ -36,7 +36,7 @@ CONFIG_SCHEMA = vol.Schema({
def setup(hass, config):
"""Setup the feedreader component."""
"""Set up the Feedreader component."""
urls = config.get(DOMAIN)[CONF_URLS]
data_file = hass.config.path("{}.pickle".format(DOMAIN))
storage = StoredData(data_file)
@@ -45,7 +45,7 @@ def setup(hass, config):
class FeedManager(object):
"""Abstraction over feedparser module."""
"""Abstraction over Feedparser module."""
def __init__(self, url, hass, storage):
"""Initialize the FeedManager object, poll every hour."""
@@ -56,46 +56,45 @@ class FeedManager(object):
self._storage = storage
self._last_entry_timestamp = None
self._has_published_parsed = False
hass.bus.listen_once(EVENT_HOMEASSISTANT_START,
lambda _: self._update())
track_utc_time_change(hass, lambda now: self._update(),
minute=0, second=0)
hass.bus.listen_once(
EVENT_HOMEASSISTANT_START, lambda _: self._update())
track_utc_time_change(
hass, lambda now: self._update(), minute=0, second=0)
def _log_no_entries(self):
"""Send no entries log at debug level."""
_LOGGER.debug('No new entries to be published in feed "%s"', self._url)
_LOGGER.debug("No new entries to be published in feed %s", self._url)
def _update(self):
"""Update the feed and publish new entries to the event bus."""
import feedparser
_LOGGER.info('Fetching new data from feed "%s"', self._url)
_LOGGER.info("Fetching new data from feed %s", self._url)
self._feed = feedparser.parse(self._url,
etag=None if not self._feed
else self._feed.get('etag'),
modified=None if not self._feed
else self._feed.get('modified'))
if not self._feed:
_LOGGER.error('Error fetching feed data from "%s"', self._url)
_LOGGER.error("Error fetching feed data from %s", self._url)
else:
if self._feed.bozo != 0:
_LOGGER.error('Error parsing feed "%s"', self._url)
_LOGGER.error("Error parsing feed %s", self._url)
# Using etag and modified, if there's no new data available,
# the entries list will be empty
elif len(self._feed.entries) > 0:
_LOGGER.debug('%s entri(es) available in feed "%s"',
len(self._feed.entries),
self._url)
elif self._feed.entries:
_LOGGER.debug("%s entri(es) available in feed %s",
len(self._feed.entries), self._url)
if len(self._feed.entries) > MAX_ENTRIES:
_LOGGER.debug('Processing only the first %s entries '
'in feed "%s"', MAX_ENTRIES, self._url)
_LOGGER.debug("Processing only the first %s entries "
"in feed %s", MAX_ENTRIES, self._url)
self._feed.entries = self._feed.entries[0:MAX_ENTRIES]
self._publish_new_entries()
if self._has_published_parsed:
self._storage.put_timestamp(self._url,
self._last_entry_timestamp)
self._storage.put_timestamp(
self._url, self._last_entry_timestamp)
else:
self._log_no_entries()
_LOGGER.info('Fetch from feed "%s" completed', self._url)
_LOGGER.info("Fetch from feed %s completed", self._url)
def _update_and_fire_entry(self, entry):
"""Update last_entry_timestamp and fire entry."""
@@ -103,12 +102,12 @@ class FeedManager(object):
# it to publish only new available entries since the last run
if 'published_parsed' in entry.keys():
self._has_published_parsed = True
self._last_entry_timestamp = max(entry.published_parsed,
self._last_entry_timestamp)
self._last_entry_timestamp = max(
entry.published_parsed, self._last_entry_timestamp)
else:
self._has_published_parsed = False
_LOGGER.debug('No `published_parsed` info available '
'for entry "%s"', entry.title)
_LOGGER.debug("No published_parsed info available for entry %s",
entry.title)
entry.update({'feed_url': self._url})
self._hass.bus.fire(EVENT_FEEDREADER, entry)
@@ -129,7 +128,7 @@ class FeedManager(object):
self._update_and_fire_entry(entry)
new_entries = True
else:
_LOGGER.debug('Entry "%s" already processed', entry.title)
_LOGGER.debug("Entry %s already processed", entry.title)
if not new_entries:
self._log_no_entries()
self._firstrun = False
@@ -150,13 +149,13 @@ class StoredData(object):
"""Fetch data stored into pickle file."""
if self._cache_outdated and exists(self._data_file):
try:
_LOGGER.debug('Fetching data from file %s', self._data_file)
_LOGGER.debug("Fetching data from file %s", self._data_file)
with self._lock, open(self._data_file, 'rb') as myfile:
self._data = pickle.load(myfile) or {}
self._cache_outdated = False
# pylint: disable=bare-except
except:
_LOGGER.error('Error loading data from pickled file %s',
_LOGGER.error("Error loading data from pickled file %s",
self._data_file)
def get_timestamp(self, url):
@@ -165,16 +164,16 @@ class StoredData(object):
return self._data.get(url)
def put_timestamp(self, url, timestamp):
"""Update timestamp for given url."""
"""Update timestamp for given URL."""
self._fetch_data()
with self._lock, open(self._data_file, 'wb') as myfile:
self._data.update({url: timestamp})
_LOGGER.debug('Overwriting feed "%s" timestamp in storage file %s',
_LOGGER.debug("Overwriting feed %s timestamp in storage file %s",
url, self._data_file)
try:
pickle.dump(self._data, myfile)
# pylint: disable=bare-except
except:
_LOGGER.error('Error saving pickled data to %s',
self._data_file)
_LOGGER.error(
"Error saving pickled data to %s", self._data_file)
self._cache_outdated = True