RFC: Call services directly (#18720)
* Call services directly * Simplify * Type * Lint * Update name * Fix tests * Catch exceptions in HTTP view * Lint * Handle ServiceNotFound in API endpoints that call services * Type * Don't crash recorder on non-JSON serializable objects
This commit is contained in:
1 parent
53cbb28926
commit
df21dd21f2
30 files changed
+312
-186
No files matched your search
@@ -1,8 +1,25 @@
|
||||
"""Tests for Home Assistant View."""
|
||||
from aiohttp.web_exceptions import HTTPInternalServerError
|
||||
import pytest
|
||||
from unittest.mock import Mock
|
||||
|
||||
from homeassistant.components.http.view import HomeAssistantView
|
||||
from aiohttp.web_exceptions import (
|
||||
HTTPInternalServerError, HTTPBadRequest, HTTPUnauthorized)
|
||||
import pytest
|
||||
import voluptuous as vol
|
||||
|
||||
from homeassistant.components.http.view import (
|
||||
HomeAssistantView, request_handler_factory)
|
||||
from homeassistant.exceptions import ServiceNotFound, Unauthorized
|
||||
|
||||
from tests.common import mock_coro_func
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def mock_request():
|
||||
"""Mock a request."""
|
||||
return Mock(
|
||||
app={'hass': Mock(is_running=True)},
|
||||
match_info={},
|
||||
)
|
||||
|
||||
|
||||
async def test_invalid_json(caplog):
|
||||
@@ -13,3 +30,30 @@ async def test_invalid_json(caplog):
|
||||
view.json(float("NaN"))
|
||||
|
||||
assert str(float("NaN")) in caplog.text
|
||||
|
||||
|
||||
async def test_handling_unauthorized(mock_request):
|
||||
"""Test handling unauth exceptions."""
|
||||
with pytest.raises(HTTPUnauthorized):
|
||||
await request_handler_factory(
|
||||
Mock(requires_auth=False),
|
||||
mock_coro_func(exception=Unauthorized)
|
||||
)(mock_request)
|
||||
|
||||
|
||||
async def test_handling_invalid_data(mock_request):
|
||||
"""Test handling unauth exceptions."""
|
||||
with pytest.raises(HTTPBadRequest):
|
||||
await request_handler_factory(
|
||||
Mock(requires_auth=False),
|
||||
mock_coro_func(exception=vol.Invalid('yo'))
|
||||
)(mock_request)
|
||||
|
||||
|
||||
async def test_handling_service_not_found(mock_request):
|
||||
"""Test handling unauth exceptions."""
|
||||
with pytest.raises(HTTPInternalServerError):
|
||||
await request_handler_factory(
|
||||
Mock(requires_auth=False),
|
||||
mock_coro_func(exception=ServiceNotFound('test', 'test'))
|
||||
)(mock_request)
|
||||
Reference in new issue
Block a user