Add support for fan direction in bond integration (#37789)

* Add support for fan direction in bond integration

* Add support for fan direction (PR feedback)
This commit is contained in:
Eugene Prystupa authored and GitHub committed 2020-07-12 15:30:24 -05:00
1 parent 53844488d8
commit e9440c49d5
3 files changed
+98 -9

No files matched your search

+28 -2
View File
@@ -1,13 +1,16 @@
"""Support for Bond fans."""
from typing import Any, Callable, List, Optional
from bond import DeviceTypes
from bond import DeviceTypes, Directions
from homeassistant.components.fan import (
DIRECTION_FORWARD,
DIRECTION_REVERSE,
SPEED_HIGH,
SPEED_LOW,
SPEED_MEDIUM,
SPEED_OFF,
SUPPORT_DIRECTION,
SUPPORT_SET_SPEED,
FanEntity,
)
@@ -48,13 +51,17 @@ class BondFan(BondEntity, FanEntity):
self._power: Optional[bool] = None
self._speed: Optional[int] = None
self._direction: Optional[int] = None
@property
def supported_features(self) -> int:
"""Flag supported features."""
features = 0
if self._device.supports_command("SetSpeed"):
if self._device.supports_speed():
features |= SUPPORT_SET_SPEED
if self._device.supports_direction():
features |= SUPPORT_DIRECTION
return features
@property
@@ -72,11 +79,23 @@ class BondFan(BondEntity, FanEntity):
"""Get the list of available speeds."""
return [SPEED_OFF, SPEED_LOW, SPEED_MEDIUM, SPEED_HIGH]
@property
def current_direction(self) -> Optional[str]:
"""Return fan rotation direction."""
direction = None
if self._direction == Directions.FORWARD:
direction = DIRECTION_FORWARD
elif self._direction == Directions.REVERSE:
direction = DIRECTION_REVERSE
return direction
def update(self):
"""Fetch assumed state of the fan from the hub using API."""
state: dict = self._hub.bond.getDeviceState(self._device.device_id)
self._power = state.get("power")
self._speed = state.get("speed")
self._direction = state.get("direction")
def set_speed(self, speed: str) -> None:
"""Set the desired speed for the fan."""
@@ -92,3 +111,10 @@ class BondFan(BondEntity, FanEntity):
def turn_off(self, **kwargs: Any) -> None:
"""Turn the fan off."""
self._hub.bond.turnOff(self._device.device_id)
def set_direction(self, direction: str) -> None:
"""Set fan rotation direction."""
bond_direction = (
Directions.REVERSE if direction == DIRECTION_REVERSE else Directions.FORWARD
)
self._hub.bond.setDirection(self._device.device_id, bond_direction)
+18 -4
View File
@@ -2,7 +2,7 @@
from typing import List, Optional
from bond import Bond
from bond import Actions, Bond
class BondDevice:
@@ -23,10 +23,24 @@ class BondDevice:
"""Get the type of this device."""
return self._attrs["type"]
def supports_command(self, command: str) -> bool:
"""Return True if this device supports specified command."""
def supports_speed(self) -> bool:
"""Return True if this device supports any of the speed related commands."""
actions: List[str] = self._attrs["actions"]
return command in actions
return len([action for action in actions if action in [Actions.SET_SPEED]]) > 0
def supports_direction(self) -> bool:
"""Return True if this device supports any of the direction related commands."""
actions: List[str] = self._attrs["actions"]
return (
len(
[
action
for action in actions
if action in [Actions.SET_DIRECTION, Actions.TOGGLE_DIRECTION]
]
)
> 0
)
class BondHub: