Significantly improve logging performance when no integrations are requesting debug level (#37776)

This commit is contained in:
J. Nick Koston authored and GitHub committed 2020-07-11 22:33:25 -07:00
1 parent 401dd4a32a
commit f16090caf4
2 files changed
+46 -4

No files matched your search

+23
View File
@@ -37,6 +37,8 @@ async def test_logger_test_filters(hass):
"""Test resulting filter operation."""
log_filter = await async_setup_logger(hass, TEST_CONFIG)
assert logging.getLogger("").isEnabledFor(logging.DEBUG) is True
# Blocked default record
assert not log_filter.filter(RECORD("asdf", logging.DEBUG))
@@ -66,13 +68,27 @@ async def test_set_filter_empty_config(hass):
"""Test change log level from empty configuration."""
log_filter = await async_setup_logger(hass, NO_LOGS_CONFIG)
assert logging.getLogger("").isEnabledFor(logging.DEBUG) is False
assert not log_filter.filter(RECORD("test", logging.DEBUG))
await hass.services.async_call(
logger.DOMAIN, "set_default_level", {"level": "warning"}
)
await hass.async_block_till_done()
assert not log_filter.filter(RECORD("test", logging.DEBUG))
assert logging.getLogger("").isEnabledFor(logging.DEBUG) is False
assert logging.getLogger("").isEnabledFor(logging.WARNING) is True
await hass.services.async_call(logger.DOMAIN, "set_level", {"test": "debug"})
await hass.async_block_till_done()
assert log_filter.filter(RECORD("test", logging.DEBUG))
assert logging.getLogger("").isEnabledFor(logging.DEBUG) is True
async def test_set_filter(hass):
"""Test change log level of existing filter."""
@@ -94,6 +110,9 @@ async def test_set_default_filter_empty_config(hass):
"""Test change default log level from empty configuration."""
log_filter = await async_setup_logger(hass, NO_DEFAULT_CONFIG)
assert logging.getLogger("").isEnabledFor(logging.DEBUG) is True
assert logging.getLogger("").isEnabledFor(logging.WARNING) is True
assert log_filter.filter(RECORD("test", logging.DEBUG))
await hass.services.async_call(
@@ -103,6 +122,10 @@ async def test_set_default_filter_empty_config(hass):
assert not log_filter.filter(RECORD("test", logging.DEBUG))
assert logging.getLogger("").isEnabledFor(logging.DEBUG) is False
assert logging.getLogger("").isEnabledFor(logging.INFO) is False
assert logging.getLogger("").isEnabledFor(logging.WARNING) is True
async def test_set_default_filter(hass):
"""Test change default log level with existing default."""