Add and use percentage constant (#32094)

* Add and use percentage constant

* Fix pylint error and broken test
This commit is contained in:
springstan authored and GitHub committed 2020-02-28 11:46:48 -08:00
1 parent c7f128f286
commit f1a0ca7cd3
155 files changed
+735 -459

No files matched your search

+16 -9
View File
@@ -6,7 +6,12 @@ from homeassistant.components.mold_indicator.sensor import (
ATTR_DEWPOINT,
)
import homeassistant.components.sensor as sensor
from homeassistant.const import ATTR_UNIT_OF_MEASUREMENT, STATE_UNKNOWN, TEMP_CELSIUS
from homeassistant.const import (
ATTR_UNIT_OF_MEASUREMENT,
STATE_UNKNOWN,
TEMP_CELSIUS,
UNIT_PERCENTAGE,
)
from homeassistant.setup import setup_component
from tests.common import get_test_home_assistant
@@ -25,7 +30,7 @@ class TestSensorMoldIndicator(unittest.TestCase):
"test.outdoortemp", "10", {ATTR_UNIT_OF_MEASUREMENT: TEMP_CELSIUS}
)
self.hass.states.set(
"test.indoorhumidity", "50", {ATTR_UNIT_OF_MEASUREMENT: "%"}
"test.indoorhumidity", "50", {ATTR_UNIT_OF_MEASUREMENT: UNIT_PERCENTAGE}
)
def tearDown(self):
@@ -50,7 +55,7 @@ class TestSensorMoldIndicator(unittest.TestCase):
moldind = self.hass.states.get("sensor.mold_indicator")
assert moldind
assert "%" == moldind.attributes.get("unit_of_measurement")
assert UNIT_PERCENTAGE == moldind.attributes.get("unit_of_measurement")
def test_invalidcalib(self):
"""Test invalid sensor values."""
@@ -61,7 +66,7 @@ class TestSensorMoldIndicator(unittest.TestCase):
"test.outdoortemp", "10", {ATTR_UNIT_OF_MEASUREMENT: TEMP_CELSIUS}
)
self.hass.states.set(
"test.indoorhumidity", "0", {ATTR_UNIT_OF_MEASUREMENT: "%"}
"test.indoorhumidity", "0", {ATTR_UNIT_OF_MEASUREMENT: UNIT_PERCENTAGE}
)
assert setup_component(
@@ -94,7 +99,7 @@ class TestSensorMoldIndicator(unittest.TestCase):
"test.outdoortemp", "10", {ATTR_UNIT_OF_MEASUREMENT: TEMP_CELSIUS}
)
self.hass.states.set(
"test.indoorhumidity", "-1", {ATTR_UNIT_OF_MEASUREMENT: "%"}
"test.indoorhumidity", "-1", {ATTR_UNIT_OF_MEASUREMENT: UNIT_PERCENTAGE}
)
assert setup_component(
@@ -120,7 +125,7 @@ class TestSensorMoldIndicator(unittest.TestCase):
assert moldind.attributes.get(ATTR_CRITICAL_TEMP) is None
self.hass.states.set(
"test.indoorhumidity", "A", {ATTR_UNIT_OF_MEASUREMENT: "%"}
"test.indoorhumidity", "A", {ATTR_UNIT_OF_MEASUREMENT: UNIT_PERCENTAGE}
)
self.hass.block_till_done()
moldind = self.hass.states.get("sensor.mold_indicator")
@@ -220,7 +225,9 @@ class TestSensorMoldIndicator(unittest.TestCase):
"test.outdoortemp", "25", {ATTR_UNIT_OF_MEASUREMENT: TEMP_CELSIUS}
)
self.hass.states.set(
"test.indoorhumidity", STATE_UNKNOWN, {ATTR_UNIT_OF_MEASUREMENT: "%"}
"test.indoorhumidity",
STATE_UNKNOWN,
{ATTR_UNIT_OF_MEASUREMENT: UNIT_PERCENTAGE},
)
self.hass.block_till_done()
moldind = self.hass.states.get("sensor.mold_indicator")
@@ -230,7 +237,7 @@ class TestSensorMoldIndicator(unittest.TestCase):
assert moldind.attributes.get(ATTR_CRITICAL_TEMP) is None
self.hass.states.set(
"test.indoorhumidity", "20", {ATTR_UNIT_OF_MEASUREMENT: "%"}
"test.indoorhumidity", "20", {ATTR_UNIT_OF_MEASUREMENT: UNIT_PERCENTAGE}
)
self.hass.block_till_done()
moldind = self.hass.states.get("sensor.mold_indicator")
@@ -276,7 +283,7 @@ class TestSensorMoldIndicator(unittest.TestCase):
assert self.hass.states.get("sensor.mold_indicator").state == "57"
self.hass.states.set(
"test.indoorhumidity", "20", {ATTR_UNIT_OF_MEASUREMENT: "%"}
"test.indoorhumidity", "20", {ATTR_UNIT_OF_MEASUREMENT: UNIT_PERCENTAGE}
)
self.hass.block_till_done()
assert self.hass.states.get("sensor.mold_indicator").state == "23"