Feature/min max improvements (#6786)

* Fix #6783, remove a test that makes no sense anymore

* Fix #6784

* Fix typo in docstring

* Fix handling of known->unknown state, extended test, fix lint errors

* Better handling of mismatch in unit of measurement.

Set state to "unkown" and unit of measurement to "ERR" if unit of measurement differs between aggregatet states.
Add entity_id to logged warning.

* Make icon configurable

* Fix typo

* Fix lint

* Fix lint

* Fix lint

* Add option to set entity_id on min_max sensor

* Fix lint logging-not-lazy

* Revert "Add option to set entity_id on min_max sensor"

This reverts commit 4685f266477dfaba92cf8a256ecfe62c929c877b.

* Revert "Make icon configurable"

This reverts commit fe45aec82d9a07e730bebb4d47dc9618fb695fe6.

* Fixes
This commit is contained in:
micw authored and Fabian Affolter committed 2017-04-11 13:52:12 +02:00
1 parent 197db6bded
commit f76a4b2806
2 files changed
+79 -28

No files matched your search

+23 -13
View File
@@ -30,7 +30,7 @@ class TestMinMaxSensor(unittest.TestCase):
config = {
'sensor': {
'platform': 'min_max',
'name': 'test',
'name': 'test_min',
'type': 'min',
'entity_ids': [
'sensor.test_1',
@@ -59,7 +59,7 @@ class TestMinMaxSensor(unittest.TestCase):
config = {
'sensor': {
'platform': 'min_max',
'name': 'test',
'name': 'test_max',
'type': 'max',
'entity_ids': [
'sensor.test_1',
@@ -88,7 +88,7 @@ class TestMinMaxSensor(unittest.TestCase):
config = {
'sensor': {
'platform': 'min_max',
'name': 'test',
'name': 'test_mean',
'type': 'mean',
'entity_ids': [
'sensor.test_1',
@@ -117,7 +117,7 @@ class TestMinMaxSensor(unittest.TestCase):
config = {
'sensor': {
'platform': 'min_max',
'name': 'test',
'name': 'test_mean',
'type': 'mean',
'round_digits': 1,
'entity_ids': [
@@ -147,7 +147,7 @@ class TestMinMaxSensor(unittest.TestCase):
config = {
'sensor': {
'platform': 'min_max',
'name': 'test',
'name': 'test_mean',
'type': 'mean',
'round_digits': 4,
'entity_ids': [
@@ -177,7 +177,7 @@ class TestMinMaxSensor(unittest.TestCase):
config = {
'sensor': {
'platform': 'min_max',
'name': 'test',
'name': 'test_max',
'type': 'max',
'entity_ids': [
'sensor.test_1',
@@ -191,7 +191,7 @@ class TestMinMaxSensor(unittest.TestCase):
entity_ids = config['sensor']['entity_ids']
self.hass.states.set(entity_ids[0], self.values[0])
self.hass.states.set(entity_ids[0], STATE_UNKNOWN)
self.hass.block_till_done()
state = self.hass.states.get('sensor.test_max')
@@ -201,14 +201,20 @@ class TestMinMaxSensor(unittest.TestCase):
self.hass.block_till_done()
state = self.hass.states.get('sensor.test_max')
self.assertEqual(STATE_UNKNOWN, state.state)
self.assertNotEqual(STATE_UNKNOWN, state.state)
self.hass.states.set(entity_ids[2], self.values[2])
self.hass.states.set(entity_ids[2], STATE_UNKNOWN)
self.hass.block_till_done()
state = self.hass.states.get('sensor.test_max')
self.assertNotEqual(STATE_UNKNOWN, state.state)
self.hass.states.set(entity_ids[1], STATE_UNKNOWN)
self.hass.block_till_done()
state = self.hass.states.get('sensor.test_max')
self.assertEqual(STATE_UNKNOWN, state.state)
def test_different_unit_of_measurement(self):
"""Test for different unit of measurement."""
config = {
@@ -232,21 +238,25 @@ class TestMinMaxSensor(unittest.TestCase):
{ATTR_UNIT_OF_MEASUREMENT: TEMP_CELSIUS})
self.hass.block_till_done()
state = self.hass.states.get('sensor.test_mean')
state = self.hass.states.get('sensor.test')
self.assertEqual(STATE_UNKNOWN, state.state)
self.assertEqual(str(float(self.values[0])), state.state)
self.assertEqual('°C', state.attributes.get('unit_of_measurement'))
self.hass.states.set(entity_ids[1], self.values[1],
{ATTR_UNIT_OF_MEASUREMENT: TEMP_FAHRENHEIT})
self.hass.block_till_done()
state = self.hass.states.get('sensor.test')
self.assertEqual(STATE_UNKNOWN, state.state)
self.assertEqual('°C', state.attributes.get('unit_of_measurement'))
self.assertEqual('ERR', state.attributes.get('unit_of_measurement'))
self.hass.states.set(entity_ids[2], self.values[2],
{ATTR_UNIT_OF_MEASUREMENT: '%'})
self.hass.block_till_done()
state = self.hass.states.get('sensor.test')
self.assertEqual(STATE_UNKNOWN, state.state)
self.assertEqual('°C', state.attributes.get('unit_of_measurement'))
self.assertEqual('ERR', state.attributes.get('unit_of_measurement'))