Mobile App: Register devices into the registry (#21856)
* Register devices into the registry * Switch to device ID instead of webhook ID * Rearchitect mobile_app to support config entries * Kill DATA_REGISTRATIONS by migrating registrations into config entries * Fix tests * Improve how we get the config_entry_id * Remove single_instance_allowed * Simplify setup_registration * Move webhook registering functions into __init__.py since they are only ever used once * Kill get_registration websocket command * Support description_placeholders in async_abort * Add link to mobile_app implementing apps in abort dialog * Store config entry and device registry entry in hass.data instead of looking it up * Add testing to ensure that the config entry is created at registration * Fix busted async_abort test * Remove unnecessary check for entry is None
This commit is contained in:
1 parent
3fd1e8d382
commit
f7dcfe28b6
15 files changed
+254
-212
No files matched your search
@@ -1,5 +1,6 @@
|
||||
"""Webhook tests for mobile_app."""
|
||||
# pylint: disable=redefined-outer-name,unused-import
|
||||
import logging
|
||||
import pytest
|
||||
|
||||
from homeassistant.components.mobile_app.const import CONF_SECRET
|
||||
@@ -8,16 +9,20 @@ from homeassistant.core import callback
|
||||
|
||||
from tests.common import async_mock_service
|
||||
|
||||
from . import authed_api_client, webhook_client # noqa: F401
|
||||
from . import (authed_api_client, create_registrations, # noqa: F401
|
||||
webhook_client) # noqa: F401
|
||||
|
||||
from .const import (CALL_SERVICE, FIRE_EVENT, REGISTER_CLEARTEXT,
|
||||
RENDER_TEMPLATE, UPDATE)
|
||||
|
||||
_LOGGER = logging.getLogger(__name__)
|
||||
|
||||
async def test_webhook_handle_render_template(webhook_client): # noqa: F811
|
||||
|
||||
async def test_webhook_handle_render_template(create_registrations, # noqa: F401, F811, E501
|
||||
webhook_client): # noqa: F811
|
||||
"""Test that we render templates properly."""
|
||||
resp = await webhook_client.post(
|
||||
'/api/webhook/mobile_app_test_cleartext',
|
||||
'/api/webhook/{}'.format(create_registrations[1]['webhook_id']),
|
||||
json=RENDER_TEMPLATE
|
||||
)
|
||||
|
||||
@@ -27,12 +32,13 @@ async def test_webhook_handle_render_template(webhook_client): # noqa: F811
|
||||
assert json == {'one': 'Hello world'}
|
||||
|
||||
|
||||
async def test_webhook_handle_call_services(hass, webhook_client): # noqa: E501 F811
|
||||
async def test_webhook_handle_call_services(hass, create_registrations, # noqa: F401, F811, E501
|
||||
webhook_client): # noqa: E501 F811
|
||||
"""Test that we call services properly."""
|
||||
calls = async_mock_service(hass, 'test', 'mobile_app')
|
||||
|
||||
resp = await webhook_client.post(
|
||||
'/api/webhook/mobile_app_test_cleartext',
|
||||
'/api/webhook/{}'.format(create_registrations[1]['webhook_id']),
|
||||
json=CALL_SERVICE
|
||||
)
|
||||
|
||||
@@ -41,7 +47,8 @@ async def test_webhook_handle_call_services(hass, webhook_client): # noqa: E501
|
||||
assert len(calls) == 1
|
||||
|
||||
|
||||
async def test_webhook_handle_fire_event(hass, webhook_client): # noqa: F811
|
||||
async def test_webhook_handle_fire_event(hass, create_registrations, # noqa: F401, F811, E501
|
||||
webhook_client): # noqa: F811
|
||||
"""Test that we can fire events."""
|
||||
events = []
|
||||
|
||||
@@ -53,7 +60,7 @@ async def test_webhook_handle_fire_event(hass, webhook_client): # noqa: F811
|
||||
hass.bus.async_listen('test_event', store_event)
|
||||
|
||||
resp = await webhook_client.post(
|
||||
'/api/webhook/mobile_app_test_cleartext',
|
||||
'/api/webhook/{}'.format(create_registrations[1]['webhook_id']),
|
||||
json=FIRE_EVENT
|
||||
)
|
||||
|
||||
@@ -93,10 +100,12 @@ async def test_webhook_update_registration(webhook_client, hass_client): # noqa
|
||||
assert CONF_SECRET not in update_json
|
||||
|
||||
|
||||
async def test_webhook_returns_error_incorrect_json(webhook_client, caplog): # noqa: E501 F811
|
||||
async def test_webhook_returns_error_incorrect_json(webhook_client, # noqa: F401, F811, E501
|
||||
create_registrations, # noqa: F401, F811, E501
|
||||
caplog): # noqa: E501 F811
|
||||
"""Test that an error is returned when JSON is invalid."""
|
||||
resp = await webhook_client.post(
|
||||
'/api/webhook/mobile_app_test_cleartext',
|
||||
'/api/webhook/{}'.format(create_registrations[1]['webhook_id']),
|
||||
data='not json'
|
||||
)
|
||||
|
||||
@@ -106,7 +115,8 @@ async def test_webhook_returns_error_incorrect_json(webhook_client, caplog): #
|
||||
assert 'invalid JSON' in caplog.text
|
||||
|
||||
|
||||
async def test_webhook_handle_decryption(webhook_client): # noqa: F811
|
||||
async def test_webhook_handle_decryption(webhook_client, # noqa: F811
|
||||
create_registrations): # noqa: F401, F811, E501
|
||||
"""Test that we can encrypt/decrypt properly."""
|
||||
try:
|
||||
# pylint: disable=unused-import
|
||||
@@ -119,7 +129,7 @@ async def test_webhook_handle_decryption(webhook_client): # noqa: F811
|
||||
import json
|
||||
|
||||
keylen = SecretBox.KEY_SIZE
|
||||
key = "58eb127991594dad934d1584bdee5f27".encode("utf-8")
|
||||
key = create_registrations[0]['secret'].encode("utf-8")
|
||||
key = key[:keylen]
|
||||
key = key.ljust(keylen, b'\0')
|
||||
|
||||
@@ -135,7 +145,7 @@ async def test_webhook_handle_decryption(webhook_client): # noqa: F811
|
||||
}
|
||||
|
||||
resp = await webhook_client.post(
|
||||
'/api/webhook/mobile_app_test',
|
||||
'/api/webhook/{}'.format(create_registrations[0]['webhook_id']),
|
||||
json=container
|
||||
)
|
||||
|
||||
@@ -151,10 +161,11 @@ async def test_webhook_handle_decryption(webhook_client): # noqa: F811
|
||||
assert json.loads(decrypted_data) == {'one': 'Hello world'}
|
||||
|
||||
|
||||
async def test_webhook_requires_encryption(webhook_client): # noqa: F811
|
||||
async def test_webhook_requires_encryption(webhook_client, # noqa: F811
|
||||
create_registrations): # noqa: F401, F811, E501
|
||||
"""Test that encrypted registrations only accept encrypted data."""
|
||||
resp = await webhook_client.post(
|
||||
'/api/webhook/mobile_app_test',
|
||||
'/api/webhook/{}'.format(create_registrations[0]['webhook_id']),
|
||||
json=RENDER_TEMPLATE
|
||||
)
|
||||
|
||||
|
||||
Reference in new issue
Block a user