Ruckus Unleashed Requested Changes (#41824)
This commit is contained in:
1 parent
a2574a4ed5
commit
ffb4a9112b
12 files changed
+351
-79
No files matched your search
@@ -1,18 +1,42 @@
|
||||
"""Tests for the Ruckus Unleashed integration."""
|
||||
from homeassistant.components.ruckus_unleashed import DOMAIN
|
||||
from homeassistant.const import (
|
||||
CONF_HOST,
|
||||
CONF_IP_ADDRESS,
|
||||
CONF_MAC,
|
||||
CONF_NAME,
|
||||
CONF_PASSWORD,
|
||||
CONF_USERNAME,
|
||||
from homeassistant.components.ruckus_unleashed.const import (
|
||||
API_ACCESS_POINT,
|
||||
API_AP,
|
||||
API_DEVICE_NAME,
|
||||
API_ID,
|
||||
API_IP,
|
||||
API_MAC,
|
||||
API_MODEL,
|
||||
API_NAME,
|
||||
API_SERIAL,
|
||||
API_SYSTEM_OVERVIEW,
|
||||
API_VERSION,
|
||||
)
|
||||
from homeassistant.const import CONF_HOST, CONF_PASSWORD, CONF_USERNAME
|
||||
|
||||
from tests.async_mock import patch
|
||||
from tests.common import MockConfigEntry
|
||||
|
||||
DEFAULT_TITLE = "Ruckus Mesh"
|
||||
DEFAULT_UNIQUE_ID = "123456789012"
|
||||
DEFAULT_SYSTEM_INFO = {
|
||||
API_SYSTEM_OVERVIEW: {
|
||||
API_SERIAL: DEFAULT_UNIQUE_ID,
|
||||
API_VERSION: "v1.0.0",
|
||||
}
|
||||
}
|
||||
DEFAULT_AP_INFO = {
|
||||
API_AP: {
|
||||
API_ID: {
|
||||
"1": {
|
||||
API_MAC: "00:11:22:33:44:55",
|
||||
API_DEVICE_NAME: "Test Device",
|
||||
API_MODEL: "r510",
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
CONFIG = {
|
||||
CONF_HOST: "1.1.1.1",
|
||||
@@ -22,9 +46,10 @@ CONFIG = {
|
||||
|
||||
TEST_CLIENT_ENTITY_ID = "device_tracker.ruckus_test_device"
|
||||
TEST_CLIENT = {
|
||||
CONF_IP_ADDRESS: "1.1.1.2",
|
||||
CONF_MAC: "AA:BB:CC:DD:EE:FF",
|
||||
CONF_NAME: "Ruckus Test Device",
|
||||
API_IP: "1.1.1.2",
|
||||
API_MAC: "AA:BB:CC:DD:EE:FF",
|
||||
API_NAME: "Ruckus Test Device",
|
||||
API_ACCESS_POINT: "00:11:22:33:44:55",
|
||||
}
|
||||
|
||||
|
||||
@@ -33,7 +58,7 @@ def mock_config_entry() -> MockConfigEntry:
|
||||
return MockConfigEntry(
|
||||
domain=DOMAIN,
|
||||
title=DEFAULT_TITLE,
|
||||
unique_id="1.1.1.1",
|
||||
unique_id=DEFAULT_UNIQUE_ID,
|
||||
data=CONFIG,
|
||||
options=None,
|
||||
)
|
||||
@@ -49,9 +74,15 @@ async def init_integration(hass) -> MockConfigEntry:
|
||||
"homeassistant.components.ruckus_unleashed.Ruckus.mesh_name",
|
||||
return_value=DEFAULT_TITLE,
|
||||
), patch(
|
||||
"homeassistant.components.ruckus_unleashed.Ruckus.clients",
|
||||
"homeassistant.components.ruckus_unleashed.Ruckus.system_info",
|
||||
return_value=DEFAULT_SYSTEM_INFO,
|
||||
), patch(
|
||||
"homeassistant.components.ruckus_unleashed.Ruckus.ap_info",
|
||||
return_value=DEFAULT_AP_INFO,
|
||||
), patch(
|
||||
"homeassistant.components.ruckus_unleashed.RuckusUnleashedDataUpdateCoordinator._fetch_clients",
|
||||
return_value={
|
||||
TEST_CLIENT[CONF_MAC]: TEST_CLIENT,
|
||||
TEST_CLIENT[API_MAC]: TEST_CLIENT,
|
||||
},
|
||||
):
|
||||
entry.add_to_hass(hass)
|
||||
|
||||
@@ -1,16 +1,19 @@
|
||||
"""Test the Ruckus Unleashed config flow."""
|
||||
from datetime import timedelta
|
||||
|
||||
from pyruckus.exceptions import AuthenticationError
|
||||
|
||||
from homeassistant import config_entries, setup
|
||||
from homeassistant import config_entries
|
||||
from homeassistant.components.ruckus_unleashed.const import DOMAIN
|
||||
from homeassistant.util import utcnow
|
||||
|
||||
from tests.async_mock import patch
|
||||
from tests.components.ruckus_unleashed import CONFIG, DEFAULT_TITLE
|
||||
from tests.common import async_fire_time_changed
|
||||
from tests.components.ruckus_unleashed import CONFIG, DEFAULT_SYSTEM_INFO, DEFAULT_TITLE
|
||||
|
||||
|
||||
async def test_form(hass):
|
||||
"""Test we get the form."""
|
||||
await setup.async_setup_component(hass, "persistent_notification", {})
|
||||
result = await hass.config_entries.flow.async_init(
|
||||
DOMAIN, context={"source": config_entries.SOURCE_USER}
|
||||
)
|
||||
@@ -23,6 +26,9 @@ async def test_form(hass):
|
||||
), patch(
|
||||
"homeassistant.components.ruckus_unleashed.Ruckus.mesh_name",
|
||||
return_value=DEFAULT_TITLE,
|
||||
), patch(
|
||||
"homeassistant.components.ruckus_unleashed.Ruckus.system_info",
|
||||
return_value=DEFAULT_SYSTEM_INFO,
|
||||
), patch(
|
||||
"homeassistant.components.ruckus_unleashed.async_setup", return_value=True
|
||||
) as mock_setup, patch(
|
||||
@@ -97,3 +103,70 @@ async def test_form_unknown_error(hass):
|
||||
|
||||
assert result2["type"] == "form"
|
||||
assert result2["errors"] == {"base": "unknown"}
|
||||
|
||||
|
||||
async def test_form_cannot_connect_unknown_serial(hass):
|
||||
"""Test we handle cannot connect error on invalid serial number."""
|
||||
result = await hass.config_entries.flow.async_init(
|
||||
DOMAIN, context={"source": config_entries.SOURCE_USER}
|
||||
)
|
||||
assert result["type"] == "form"
|
||||
assert result["errors"] == {}
|
||||
|
||||
with patch(
|
||||
"homeassistant.components.ruckus_unleashed.Ruckus.connect",
|
||||
return_value=None,
|
||||
), patch(
|
||||
"homeassistant.components.ruckus_unleashed.Ruckus.mesh_name",
|
||||
return_value=DEFAULT_TITLE,
|
||||
), patch(
|
||||
"homeassistant.components.ruckus_unleashed.Ruckus.system_info",
|
||||
return_value={},
|
||||
):
|
||||
result2 = await hass.config_entries.flow.async_configure(
|
||||
result["flow_id"],
|
||||
CONFIG,
|
||||
)
|
||||
|
||||
assert result2["type"] == "form"
|
||||
assert result2["errors"] == {"base": "cannot_connect"}
|
||||
|
||||
|
||||
async def test_form_duplicate_error(hass):
|
||||
"""Test we handle duplicate error."""
|
||||
result = await hass.config_entries.flow.async_init(
|
||||
DOMAIN, context={"source": config_entries.SOURCE_USER}
|
||||
)
|
||||
|
||||
with patch(
|
||||
"homeassistant.components.ruckus_unleashed.Ruckus.connect",
|
||||
return_value=None,
|
||||
), patch(
|
||||
"homeassistant.components.ruckus_unleashed.Ruckus.mesh_name",
|
||||
return_value=DEFAULT_TITLE,
|
||||
), patch(
|
||||
"homeassistant.components.ruckus_unleashed.Ruckus.system_info",
|
||||
return_value=DEFAULT_SYSTEM_INFO,
|
||||
):
|
||||
await hass.config_entries.flow.async_configure(
|
||||
result["flow_id"],
|
||||
CONFIG,
|
||||
)
|
||||
|
||||
future = utcnow() + timedelta(minutes=60)
|
||||
async_fire_time_changed(hass, future)
|
||||
await hass.async_block_till_done()
|
||||
|
||||
result = await hass.config_entries.flow.async_init(
|
||||
DOMAIN, context={"source": config_entries.SOURCE_USER}
|
||||
)
|
||||
assert result["type"] == "form"
|
||||
assert result["errors"] == {}
|
||||
|
||||
result2 = await hass.config_entries.flow.async_configure(
|
||||
result["flow_id"],
|
||||
CONFIG,
|
||||
)
|
||||
|
||||
assert result2["type"] == "abort"
|
||||
assert result2["reason"] == "already_configured"
|
||||
@@ -1,15 +1,20 @@
|
||||
"""The sensor tests for the Ruckus Unleashed platform."""
|
||||
from datetime import timedelta
|
||||
|
||||
from homeassistant.components.ruckus_unleashed import DOMAIN
|
||||
from homeassistant.const import CONF_MAC, STATE_HOME, STATE_NOT_HOME, STATE_UNAVAILABLE
|
||||
from homeassistant.components.ruckus_unleashed import API_MAC, DOMAIN
|
||||
from homeassistant.components.ruckus_unleashed.const import API_AP, API_ID, API_NAME
|
||||
from homeassistant.const import STATE_HOME, STATE_NOT_HOME, STATE_UNAVAILABLE
|
||||
from homeassistant.helpers import entity_registry
|
||||
from homeassistant.helpers.device_registry import CONNECTION_NETWORK_MAC
|
||||
from homeassistant.util import utcnow
|
||||
|
||||
from tests.async_mock import patch
|
||||
from tests.common import async_fire_time_changed
|
||||
from tests.components.ruckus_unleashed import (
|
||||
DEFAULT_AP_INFO,
|
||||
DEFAULT_SYSTEM_INFO,
|
||||
DEFAULT_TITLE,
|
||||
DEFAULT_UNIQUE_ID,
|
||||
TEST_CLIENT,
|
||||
TEST_CLIENT_ENTITY_ID,
|
||||
init_integration,
|
||||
@@ -23,17 +28,17 @@ async def test_client_connected(hass):
|
||||
|
||||
future = utcnow() + timedelta(minutes=60)
|
||||
with patch(
|
||||
"homeassistant.components.ruckus_unleashed.Ruckus.clients",
|
||||
"homeassistant.components.ruckus_unleashed.RuckusUnleashedDataUpdateCoordinator._fetch_clients",
|
||||
return_value={
|
||||
TEST_CLIENT[CONF_MAC]: TEST_CLIENT,
|
||||
TEST_CLIENT[API_MAC]: TEST_CLIENT,
|
||||
},
|
||||
):
|
||||
async_fire_time_changed(hass, future)
|
||||
await hass.async_block_till_done()
|
||||
|
||||
await hass.helpers.entity_component.async_update_entity(TEST_CLIENT_ENTITY_ID)
|
||||
test_client = hass.states.get(TEST_CLIENT_ENTITY_ID)
|
||||
assert test_client.state == STATE_HOME
|
||||
|
||||
test_client = hass.states.get(TEST_CLIENT_ENTITY_ID)
|
||||
assert test_client.state == STATE_HOME
|
||||
|
||||
|
||||
async def test_client_disconnected(hass):
|
||||
@@ -42,7 +47,7 @@ async def test_client_disconnected(hass):
|
||||
|
||||
future = utcnow() + timedelta(minutes=60)
|
||||
with patch(
|
||||
"homeassistant.components.ruckus_unleashed.Ruckus.clients",
|
||||
"homeassistant.components.ruckus_unleashed.RuckusUnleashedDataUpdateCoordinator._fetch_clients",
|
||||
return_value={},
|
||||
):
|
||||
async_fire_time_changed(hass, future)
|
||||
@@ -59,7 +64,7 @@ async def test_clients_update_failed(hass):
|
||||
|
||||
future = utcnow() + timedelta(minutes=60)
|
||||
with patch(
|
||||
"homeassistant.components.ruckus_unleashed.Ruckus.clients",
|
||||
"homeassistant.components.ruckus_unleashed.RuckusUnleashedDataUpdateCoordinator._fetch_clients",
|
||||
side_effect=ConnectionError,
|
||||
):
|
||||
async_fire_time_changed(hass, future)
|
||||
@@ -79,7 +84,7 @@ async def test_restoring_clients(hass):
|
||||
registry.async_get_or_create(
|
||||
"device_tracker",
|
||||
DOMAIN,
|
||||
TEST_CLIENT[CONF_MAC],
|
||||
DEFAULT_UNIQUE_ID,
|
||||
suggested_object_id="ruckus_test_device",
|
||||
config_entry=entry,
|
||||
)
|
||||
@@ -91,7 +96,13 @@ async def test_restoring_clients(hass):
|
||||
"homeassistant.components.ruckus_unleashed.Ruckus.mesh_name",
|
||||
return_value=DEFAULT_TITLE,
|
||||
), patch(
|
||||
"homeassistant.components.ruckus_unleashed.Ruckus.clients",
|
||||
"homeassistant.components.ruckus_unleashed.Ruckus.system_info",
|
||||
return_value=DEFAULT_SYSTEM_INFO,
|
||||
), patch(
|
||||
"homeassistant.components.ruckus_unleashed.Ruckus.ap_info",
|
||||
return_value=DEFAULT_AP_INFO,
|
||||
), patch(
|
||||
"homeassistant.components.ruckus_unleashed.RuckusUnleashedDataUpdateCoordinator._fetch_clients",
|
||||
return_value={},
|
||||
):
|
||||
entry.add_to_hass(hass)
|
||||
@@ -101,3 +112,24 @@ async def test_restoring_clients(hass):
|
||||
device = hass.states.get(TEST_CLIENT_ENTITY_ID)
|
||||
assert device is not None
|
||||
assert device.state == STATE_NOT_HOME
|
||||
|
||||
|
||||
async def test_client_device_setup(hass):
|
||||
"""Test a client device is created."""
|
||||
await init_integration(hass)
|
||||
|
||||
router_info = DEFAULT_AP_INFO[API_AP][API_ID]["1"]
|
||||
|
||||
device_registry = await hass.helpers.device_registry.async_get_registry()
|
||||
client_device = device_registry.async_get_device(
|
||||
identifiers={},
|
||||
connections={(CONNECTION_NETWORK_MAC, TEST_CLIENT[API_MAC])},
|
||||
)
|
||||
router_device = device_registry.async_get_device(
|
||||
identifiers={(CONNECTION_NETWORK_MAC, router_info[API_MAC])},
|
||||
connections={(CONNECTION_NETWORK_MAC, router_info[API_MAC])},
|
||||
)
|
||||
|
||||
assert client_device
|
||||
assert client_device.name == TEST_CLIENT[API_NAME]
|
||||
assert client_device.via_device_id == router_device.id
|
||||
@@ -1,15 +1,32 @@
|
||||
"""Test the Ruckus Unleashed config flow."""
|
||||
from pyruckus.exceptions import AuthenticationError
|
||||
|
||||
from homeassistant.components.ruckus_unleashed import DOMAIN
|
||||
from homeassistant.components.ruckus_unleashed import (
|
||||
API_AP,
|
||||
API_DEVICE_NAME,
|
||||
API_ID,
|
||||
API_MAC,
|
||||
API_MODEL,
|
||||
API_SYSTEM_OVERVIEW,
|
||||
API_VERSION,
|
||||
DOMAIN,
|
||||
MANUFACTURER,
|
||||
)
|
||||
from homeassistant.config_entries import (
|
||||
ENTRY_STATE_LOADED,
|
||||
ENTRY_STATE_NOT_LOADED,
|
||||
ENTRY_STATE_SETUP_RETRY,
|
||||
)
|
||||
from homeassistant.helpers.device_registry import CONNECTION_NETWORK_MAC
|
||||
|
||||
from tests.async_mock import patch
|
||||
from tests.components.ruckus_unleashed import init_integration, mock_config_entry
|
||||
from tests.components.ruckus_unleashed import (
|
||||
DEFAULT_AP_INFO,
|
||||
DEFAULT_SYSTEM_INFO,
|
||||
DEFAULT_TITLE,
|
||||
init_integration,
|
||||
mock_config_entry,
|
||||
)
|
||||
|
||||
|
||||
async def test_setup_entry_login_error(hass):
|
||||
@@ -40,6 +57,26 @@ async def test_setup_entry_connection_error(hass):
|
||||
assert entry.state == ENTRY_STATE_SETUP_RETRY
|
||||
|
||||
|
||||
async def test_router_device_setup(hass):
|
||||
"""Test a router device is created."""
|
||||
await init_integration(hass)
|
||||
|
||||
device_info = DEFAULT_AP_INFO[API_AP][API_ID]["1"]
|
||||
|
||||
device_registry = await hass.helpers.device_registry.async_get_registry()
|
||||
device = device_registry.async_get_device(
|
||||
identifiers={(CONNECTION_NETWORK_MAC, device_info[API_MAC])},
|
||||
connections={(CONNECTION_NETWORK_MAC, device_info[API_MAC])},
|
||||
)
|
||||
|
||||
assert device
|
||||
assert device.manufacturer == MANUFACTURER
|
||||
assert device.model == device_info[API_MODEL]
|
||||
assert device.name == device_info[API_DEVICE_NAME]
|
||||
assert device.sw_version == DEFAULT_SYSTEM_INFO[API_SYSTEM_OVERVIEW][API_VERSION]
|
||||
assert device.via_device_id is None
|
||||
|
||||
|
||||
async def test_unload_entry(hass):
|
||||
"""Test successful unload of entry."""
|
||||
entry = await init_integration(hass)
|
||||
@@ -52,3 +89,26 @@ async def test_unload_entry(hass):
|
||||
|
||||
assert entry.state == ENTRY_STATE_NOT_LOADED
|
||||
assert not hass.data.get(DOMAIN)
|
||||
|
||||
|
||||
async def test_config_not_ready_during_setup(hass):
|
||||
"""Test we throw a ConfigNotReady if Coordinator update fails."""
|
||||
entry = mock_config_entry()
|
||||
with patch(
|
||||
"homeassistant.components.ruckus_unleashed.Ruckus.connect",
|
||||
return_value=None,
|
||||
), patch(
|
||||
"homeassistant.components.ruckus_unleashed.Ruckus.mesh_name",
|
||||
return_value=DEFAULT_TITLE,
|
||||
), patch(
|
||||
"homeassistant.components.ruckus_unleashed.Ruckus.system_info",
|
||||
return_value=DEFAULT_SYSTEM_INFO,
|
||||
), patch(
|
||||
"homeassistant.components.ruckus_unleashed.RuckusUnleashedDataUpdateCoordinator._async_update_data",
|
||||
side_effect=ConnectionError,
|
||||
):
|
||||
entry.add_to_hass(hass)
|
||||
await hass.config_entries.async_setup(entry.entry_id)
|
||||
await hass.async_block_till_done()
|
||||
|
||||
assert entry.state == ENTRY_STATE_SETUP_RETRY
|
||||
Reference in new issue
Block a user