From 49ee4ee4d83da801f13556ea44e3d7cdd2124b34 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Gil=20P=C3=A9rez?= Date: Tue, 21 Apr 2026 00:05:14 +0200 Subject: [PATCH] fix(people): reset page to 1 when filters change; drop stale onClick on sort menu MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Two small fixes in PeopleFilters: 1. `handleChange` preserved the current page when any other filter changed. Symptom: the user is on page 2, types a name in the search box, and the list shows zero results until they click back to page 1 manually. The new query returns fewer total people, so page=2 is past the end. Fix: force page=1 whenever the change doesn't explicitly set `page`. 2. The DropdownMenuTrigger for the sort menu had a leftover `onClick={() => handleChange({ page: nextPage })}` — looks copy-pasted from the "next page" button right above it. Opening the sort menu would silently advance the pagination. Dropped; Radix's DropdownMenuTrigger opens the popover by itself. --- src/components/people/PeopleFilters.tsx | 32 +++++++++++++++---------- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/src/components/people/PeopleFilters.tsx b/src/components/people/PeopleFilters.tsx index c3ab871..d0db79c 100644 --- a/src/components/people/PeopleFilters.tsx +++ b/src/components/people/PeopleFilters.tsx @@ -23,19 +23,24 @@ export function PeopleFilters() { const { updateContext, page, maximumAssetCount, type = "all", query = "", visibility = "all" } = filters; const handleChange = (data: Partial) => { - updateContext(data); + // Any filter change other than an explicit page navigation must reset + // pagination: without this, typing a name while on page 2 keeps page=2 + // and the now-smaller result set returns nothing until the user clicks + // back to page 1 manually. + const nextData = "page" in data ? data : { ...data, page: 1 }; + updateContext(nextData); router.push({ pathname: router.pathname, query: { ...router.query, - ...data, - page: data.page || undefined, - type: data.type || undefined, - visibility: data.visibility || undefined, - query: data.query || undefined, - maximumAssetCount: data.maximumAssetCount || undefined, - sort: data.sort || undefined, - sortOrder: data.sortOrder || undefined, + ...nextData, + page: nextData.page || undefined, + type: nextData.type || undefined, + visibility: nextData.visibility || undefined, + query: nextData.query || undefined, + maximumAssetCount: nextData.maximumAssetCount || undefined, + sort: nextData.sort || undefined, + sortOrder: nextData.sortOrder || undefined, }, }); } @@ -109,10 +114,11 @@ export function PeopleFilters() { -