From b473bfdc5dd61963ccaf81f19ac27e482c9ecac2 Mon Sep 17 00:00:00 2001
From: jonvdveen <196496658+jonvdveen@users.noreply.github.com>
Date: Thu, 2 Jul 2026 21:23:57 -0600
Subject: [PATCH] feat: resolution condition for workflow IF/SWITCH nodes
 (megapixels, short/long edge)

Adds a "Resolution" condition type filtering assets by image
dimensions, useful for isolating low-resolution images for cleanup or
selecting high-resolution ones.

Three metrics with optional min/max bounds:
- Megapixels (width x height / 1e6, fractional values allowed)
- Short edge in pixels (LEAST of width/height)
- Long edge in pixels (GREATEST of width/height)

Short/long edge are orientation-agnostic, so a 4000x3000 landscape and
a 3000x4000 portrait are treated identically. Uses the exifImageWidth/
exifImageHeight columns on asset_exif, which the condition queries
already join; assets without recorded dimensions never match.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 .../workflows/config/ConditionEditor.tsx      | 20 +++++++++++++++++++
 .../workflows/nodes/conditionSummary.ts       | 11 ++++++++++
 src/lib/workflow/conditionBuilder.ts          | 15 ++++++++++++++
 src/types/workflow.d.ts                       |  2 +-
 4 files changed, 47 insertions(+), 1 deletion(-)

diff --git a/src/components/workflows/config/ConditionEditor.tsx b/src/components/workflows/config/ConditionEditor.tsx
index 084e63b..edd15da 100644
--- a/src/components/workflows/config/ConditionEditor.tsx
+++ b/src/components/workflows/config/ConditionEditor.tsx
@@ -27,6 +27,7 @@ const conditionTypeLabels: Record<ConditionType, string> = {
   asset_type: "Asset Type",
   iso_range: "ISO Range",
   focal_length: "Focal Length",
+  resolution: "Resolution",
   rating: "Rating",
   is_favorited: "Favorited",
   not_in_album: "Not in Any Album",
@@ -192,6 +193,25 @@ function ConditionFields({ condition, onChange }: { condition: ICondition; onCha
           <Input className="h-7 text-xs w-16" type="number" min={1} max={5} placeholder="Max" value={condition.max ?? ""} onChange={(e) => onChange({ ...condition, max: parseInt(e.target.value) || undefined })} />
         </div>
       );
+    case "resolution": {
+      const unit = (condition.metric || "megapixels") === "megapixels" ? "MP" : "px";
+      return (
+        <div className="space-y-2">
+          <Select value={condition.metric || "megapixels"} onValueChange={(v) => onChange({ ...condition, metric: v })}>
+            <SelectTrigger className="h-7 text-xs"><SelectValue /></SelectTrigger>
+            <SelectContent>
+              <SelectItem value="megapixels">Megapixels</SelectItem>
+              <SelectItem value="short_edge">Short Edge (px)</SelectItem>
+              <SelectItem value="long_edge">Long Edge (px)</SelectItem>
+            </SelectContent>
+          </Select>
+          <div className="flex items-center gap-2">
+            <Input className="h-7 text-xs" type="number" min={0} step="any" placeholder={`Min ${unit}`} value={condition.min ?? ""} onChange={(e) => onChange({ ...condition, min: e.target.value === "" ? undefined : parseFloat(e.target.value) })} />
+            <Input className="h-7 text-xs" type="number" min={0} step="any" placeholder={`Max ${unit}`} value={condition.max ?? ""} onChange={(e) => onChange({ ...condition, max: e.target.value === "" ? undefined : parseFloat(e.target.value) })} />
+          </div>
+        </div>
+      );
+    }
     case "is_favorited":
       return (
         <Select value={condition.value === false ? "false" : "true"} onValueChange={(v) => onChange({ ...condition, value: v === "true" })}>
diff --git a/src/components/workflows/nodes/conditionSummary.ts b/src/components/workflows/nodes/conditionSummary.ts
index 5cc441c..360966c 100644
--- a/src/components/workflows/nodes/conditionSummary.ts
+++ b/src/components/workflows/nodes/conditionSummary.ts
@@ -16,6 +16,7 @@ const conditionTypeLabels: Record<ConditionType, string> = {
   asset_type: "Asset Type",
   iso_range: "ISO Range",
   focal_length: "Focal Length",
+  resolution: "Resolution",
   rating: "Rating",
   is_favorited: "Favorited",
   not_in_album: "Not in Any Album",
@@ -95,6 +96,16 @@ export function formatConditionSummary(c: ICondition): string {
       if (c.max != null) return `${label}: ≤${c.max}`;
       return label;
     }
+    case "resolution": {
+      const metricNames: Record<string, string> = { megapixels: "MP", short_edge: "short edge", long_edge: "long edge" };
+      const metric = c.metric || "megapixels";
+      const unit = metric === "megapixels" ? "MP" : "px";
+      const name = metric === "megapixels" ? "" : `${metricNames[metric]} `;
+      if (c.min != null && c.max != null) return `${label}: ${name}${c.min}–${c.max}${unit}`;
+      if (c.min != null) return `${label}: ${name}≥${c.min}${unit}`;
+      if (c.max != null) return `${label}: ${name}≤${c.max}${unit}`;
+      return label;
+    }
     case "is_favorited":
       return c.value === false ? "Not Favorited" : "Favorited";
     case "not_in_album":
diff --git a/src/lib/workflow/conditionBuilder.ts b/src/lib/workflow/conditionBuilder.ts
index e695515..a1899cc 100644
--- a/src/lib/workflow/conditionBuilder.ts
+++ b/src/lib/workflow/conditionBuilder.ts
@@ -92,6 +92,21 @@ function buildSingleCondition(c: ICondition): SQL | undefined {
       return parts.length > 0 ? and(...parts)! : undefined;
     }
 
+    case "resolution": {
+      // Short/long edge are orientation-agnostic; megapixels = width × height / 1e6.
+      const metric = c.metric || "megapixels";
+      const value =
+        metric === "short_edge"
+          ? sql`LEAST(${exif.exifImageWidth}, ${exif.exifImageHeight})`
+          : metric === "long_edge"
+            ? sql`GREATEST(${exif.exifImageWidth}, ${exif.exifImageHeight})`
+            : sql`(${exif.exifImageWidth}::bigint * ${exif.exifImageHeight}) / 1000000.0`;
+      const parts: SQL[] = [];
+      if (c.min !== undefined && c.min !== null) parts.push(sql`${value} >= ${c.min}`);
+      if (c.max !== undefined && c.max !== null) parts.push(sql`${value} <= ${c.max}`);
+      return parts.length > 0 ? and(...parts)! : undefined;
+    }
+
     case "person": {
       const ids: string[] = c.personIds || (c.personId ? [c.personId] : []);
       if (ids.length === 0) return undefined;
diff --git a/src/types/workflow.d.ts b/src/types/workflow.d.ts
index fd1367b..bb2442a 100644
--- a/src/types/workflow.d.ts
+++ b/src/types/workflow.d.ts
@@ -54,7 +54,7 @@ export type ConditionType =
   | "date_range" | "date_relative" | "day_of_week"
   | "camera_make" | "camera_model" | "lens"
   | "asset_type" | "iso_range" | "focal_length"
-  | "rating" | "is_favorited"
+  | "rating" | "is_favorited" | "resolution"
   | "not_in_album" | "not_in_specific_album";
 
 export interface ICondition {